From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yymBGJ0Tr2llkSAAWB0awg (envelope-from ) for ; Mon, 09 Mar 2026 14:38:21 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=rt16Qz0i; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 42FC51E0DD; Mon, 09 Mar 2026 14:38:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0D30D1E089 for ; Mon, 09 Mar 2026 14:38:20 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 921284B9DB44 for ; Mon, 9 Mar 2026 18:38:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 921284B9DB44 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=rt16Qz0i Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 4CF494BA2E0B for ; Mon, 9 Mar 2026 18:37:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4CF494BA2E0B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4CF494BA2E0B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773081449; cv=none; b=mruKbxS+KUEQX38OmiCXyI2ilfdej0Hj/GNf3ojULPc78PRSXGZ75tqB4M9puVJbN2yXPjaPVi4S4apsPBTUB4N5+Q8qNLFrDDwIO9Ak/dMK3c2pxyL+PsQrd3R08/zLkoIsEalNlGAxyrf8be6d1FuuBrj7i6GyQCiNDNzMOjk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773081449; c=relaxed/simple; bh=Kwnyfj/FKXaPifQGuN5L2SHaZIs7/0ebZ93QK9TSl2E=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=kJv0k2ErsPXQYotQSt1K2IrEUDVddk6TV59CtE3x0qOTBSJTsoJ0KiMsOvnsg6ukOcnYKS3cXKGJB5zamSEAUd8ZLUPpcHjt3YdnDJb0Zjr0ubp7CTvnmJMs+Nj6TxUgKqE9xu/+aweMVSM4k/azdJsjxwK+Piu6wKbV9r4KeyU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4CF494BA2E0B Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 629IbLbZ018951 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 9 Mar 2026 14:37:26 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 629IbLbZ018951 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1773081446; bh=Wj/f4OIWzB2EN0Sv2C1g0YZbFz3q/Fx189WSHT4wyJs=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=rt16Qz0ibSrgK7AoWTT4otarLByVdVeNqIaX2vmIkRrfzH3DCJGgCZ2AerHIrXXoZ nsqYugHREvdhd4vxOow4DZZyeiy4n8XaHLLF9KR7ponrK4YZl1pC9pQV0Ja8jb8DvT ao2pytNrjAYaR/qYmrT2Z4A0EYvJtv4j69yMK9JHPJsXcGa1VFqaFu/L3dnTJ3ZRdl kTHgTYWkY7bzKElfgFeEywd0k+0KXuGoh1BbzdRGX4VPUyVAcO0CDzhauA3r9kaCeI ExVKfFNsaJCtybZGBAUKFXnFnfADK9x98E59Ut1CK64nrgHO1H5zNwgVjo3Fv1yuAB oqRwhrTp59fiw== Received: by simark.ca (Postfix) id 2C78E1E089; Mon, 09 Mar 2026 14:37:21 -0400 (EDT) Message-ID: Date: Mon, 9 Mar 2026 14:37:20 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gdb/corelow: mark bytes unavailable when reading from unavailable mapping To: Tom Tromey Cc: gdb-patches@sourceware.org, Simon Marchi References: <20260228022059.117785-1-simon.marchi@efficios.com> <20260302032333.2287923-1-simon.marchi@polymtl.ca> <87ms0npn5b.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87ms0npn5b.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 9 Mar 2026 18:37:21 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/4/26 11:36 AM, Tom Tromey wrote: >>>>>> "Simon" == simon marchi writes: > > Simon> The main motivation for this change is to nicely support "lightweight" > Simon> core files on ROCm (more on this below), but I think that the change > Simon> also makes sense for regular core files. > > FWIW this all makes sense to me. > > Simon> diff --git a/gdb/corelow.c b/gdb/corelow.c > Simon> index a28a707c293a..57d05504fa3c 100644 > Simon> --- a/gdb/corelow.c > Simon> +++ b/gdb/corelow.c > Simon> @@ -1470,7 +1470,8 @@ core_target::xfer_partial (enum target_object object, const char *annex, > Simon> if (xfer_status == TARGET_XFER_OK) > Simon> return TARGET_XFER_OK; > > Simon> - return TARGET_XFER_E_IO; > Simon> + *xfered_len = len; > Simon> + return TARGET_XFER_UNAVAILABLE; > Simon> } > Simon> } > > Just before this is a comment ending with > > If that fails, but the access is within an unavailable region, > then the access itself should fail. */ > > but perhaps this could be reworded to not say "fail" but something about > unavailability. > > Though honestly this is kind of a nit since the code speaks for itself. It's an easy enough fix and it's good to be precise. Changed it to: If that fails, but the access is within an unavailable region, then report the bytes as unavailable. */ > Anyway I think this is good. > Approved-By: Tom Tromey Thanks, pushed. Simon