Re: [PATCH v5 00/16] SME support for AArch64 gdb/gdbserver on Linux

Thiago Jung Bauermann via Gdb-patches
2023-09-13T03:04:07Z

Hello Luis,

Luis Machado <luis.machado@arm.com> writes:

> The following series enables SME 1 (Scalable Matrix Extension) support for
> AArch64 gdb and gdbserver.
>
> SME expands on SVE by having a variable-sized matrix (ZA) of dimensions
> SVL x SVL bytes.
>
> The first few patches and some intermediate ones refactor the code and fix
> issues prior to enabling SME support, and thus could go in independently.
>
> I've kept them in the series as they are closely/logically related.
>
> Luis Machado (16):
> [gdb/aarch64] Fix register fetch/store order for native AArch64 Linux
> [gdb/aarch64] refactor: Rename SVE-specific files
> [gdb/gdbserver] refactor: Simplify SVE interface to read/write
> registers
> [gdb/aarch64] sve: Fix return command when using V registers in a
> SVE-enabled target
> [gdb/aarch64] sme: Enable SME registers and pseudo-registers
> [gdbserver/aarch64] refactor: Adjust expedited registers dynamically
> [gdbserver/aarch64] sme: Add support for SME
> [gdb/aarch64] sve: Fix signal frame z/v register restore
> [gdb/aarch64] sme: Signal frame support
> [gdb/aarch64] sme: Fixup sigframe gdbarch when vg/svg changes
> [gdb/aarch64] sme: Support TPIDR2 signal frame context
> [gdb/generic] corefile/bug: Use thread-specific gdbarch when dumping
> register state to core files
> [gdb/generic] corefile/bug: Fixup (gcore) core file target description
> reading order
> [gdb/aarch64] sme: Core file support for Linux
> [gdb/testsuite] sme: Add SVE/SME testcases
> [gdb/docs] sme: Document SME registers and features

FWIW, I have gone through the patch series and haven't found any issues.
Thank you for addressing my comments.

So apart from the patches where Simon found some issues:

Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>

--
Thiago