From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125152 invoked by alias); 26 Jan 2017 19:32:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124901 invoked by uid 89); 26 Jan 2017 19:32:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:1485453, H*MI:sk:1485453, H*i:sk:1485453 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Jan 2017 19:32:40 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B5EA03DBD5; Thu, 26 Jan 2017 19:32:40 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0QJWboS003941; Thu, 26 Jan 2017 14:32:39 -0500 Subject: Re: [PATCH,v3] Harden tests that deal with memory regions To: Luis Machado , gdb-patches@sourceware.org References: <1485206680-4402-1-git-send-email-lgustavo@codesourcery.com> <1485453806-31216-1-git-send-email-lgustavo@codesourcery.com> From: Pedro Alves Message-ID: Date: Thu, 26 Jan 2017 19:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1485453806-31216-1-git-send-email-lgustavo@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg00601.txt.bz2 OK with ... > Changes in v3: > > - Fixed up comments. > - Renamed lib/gdb-memory.exp to lib/memory.exp. > - Moved memory region deletion closer to where we run to main in > gdb.base/breakpoint-in-ro-regions.exp. > > Changes in v2: > > - Addressed comments by Pedro. > - Removed stale comments, fixed copyright year. > - Updated comment for proc delete_memory_regions. > ... these removed from the final commit log ... > > OK? ... and this too, and ... > +++ b/gdb/testsuite/lib/memory.exp > @@ -0,0 +1,33 @@ > +# Copyright 2012 Free Software Foundation, Inc. 2012-2017 Thanks, Pedro Alves