From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2178 invoked by alias); 10 Oct 2016 18:31:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2148 invoked by uid 89); 10 Oct 2016 18:31:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=remembered X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Oct 2016 18:31:18 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B1FC1466FA; Mon, 10 Oct 2016 18:31:17 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9AIVGZZ006998; Mon, 10 Oct 2016 14:31:17 -0400 Subject: Re: [RFA 22/22] Convert dwarf_expr_context_funcs to methods To: Tom Tromey , gdb-patches@sourceware.org References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-23-git-send-email-tom@tromey.com> <599458e7-1d18-2dc8-413e-1e449914e2dc@redhat.com> From: Pedro Alves Message-ID: Date: Mon, 10 Oct 2016 18:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <599458e7-1d18-2dc8-413e-1e449914e2dc@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00230.txt.bz2 On 10/09/2016 08:11 PM, Pedro Alves wrote: > On 09/27/2016 05:08 AM, Tom Tromey wrote: >> This patch converts the function pointers in dwarf_expr_context_funcs >> into methods on dwarf_expr_context, and then updates the various >> implementations and callers to follow. >> >> NB this patch uses "override" (which caught a couple of renaming bugs >> during development) -- but this is C++11, so this patch at least has >> to wait for Pedro's patch that adds the OVERRIDE macro. > > We can pull that bit in now, or remove the "override". No need to hold > this patch back. I remembered that I had proposed on the gcc list a while ago to move their OVERRIDE/FINAL macros to ansidecl.h instead, so we could share it. I'm testing a patch that does that. Thanks, Pedro Alves