Re: [PATCH 0/9] Convert breakpoint iteration macros to ranges

Simon Marchi via Gdb-patches
2021-05-27T18:59:41Z

On 2021-05-27 2:14 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> This all started with me finding that the update_global_location_list
> Simon> function was hard to read, notably because the breakpoint iteration
> Simon> macros are a bit hard to read (require multiple local variables and
> Simon> pointers to pointers). So this removes all breakpoint-related iteration
> Simon> macros in favor of functions that return iterable ranges.
>
> This all looks good to me. I prefer external iteration like this when
> possible, as I think it's easier to understand and write. Thank you.
>
> Tom
>

Thanks, pushed with the things you pointed out fixed.

Simon