Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Luis Machado <lgustavo@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Improve load command's help text
Date: Fri, 06 Jan 2017 18:29:00 -0000	[thread overview]
Message-ID: <bb262136745fba57a5d68803426e4c90@polymtl.ca> (raw)
In-Reply-To: <1483720888-6467-1-git-send-email-lgustavo@codesourcery.com>

On 2017-01-06 11:41, Luis Machado wrote:
> diff --git a/gdb/symfile.c b/gdb/symfile.c
> index 61b9e5b..0af1900 100644
> --- a/gdb/symfile.c
> +++ b/gdb/symfile.c
> @@ -3952,7 +3952,8 @@ that lies within the boundaries of this symbol
> file in memory."),
>    c = add_cmd ("load", class_files, load_command, _("\
>  Dynamically load FILE into the running program, and record its 
> symbols\n\
>  for access from GDB.\n\
> -A load OFFSET may also be given."), &cmdlist);
> +A load offset may also be given.\n\
> +Usage: load [FILE] [offset expression]"), &cmdlist);

For consistency, I think this would look better:

   Usage: load [FILE] [OFFSET]

The fact that offset can be an expression can be specified in the text 
just before.


  reply	other threads:[~2017-01-06 18:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06 16:41 Luis Machado
2017-01-06 18:29 ` Simon Marchi [this message]
2017-01-06 18:31   ` Luis Machado
2017-01-10 14:59 ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb262136745fba57a5d68803426e4c90@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox