From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Uda8MK8Jsmj0ig8AWB0awg (envelope-from ) for ; Fri, 29 Aug 2025 16:12:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1756498351; bh=iVGRtW/3P8FPEgjHQm/Xi8L9HjkpKT6KsPdEkTQfb+k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=lM8M3yUPv9rJ6Fv0dvvQab3+GLSF5X3/6SK1VUkdVBOhN7UHEi6aazEMErgj1h1le h8x79s9o9L7dPf9o2JF4Ba3gh3jkjjrCjR5G4CwOiI1H/s6+offEhWg5E4U8H5CLeM JDLeoAgbukn+pWYOA8H88FDPnLcYV5M1IHmQnK14= Received: by simark.ca (Postfix, from userid 112) id C136A1E04C; Fri, 29 Aug 2025 16:12:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=is6WmxsS; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 16EB61E023 for ; Fri, 29 Aug 2025 16:12:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 96B903844013 for ; Fri, 29 Aug 2025 20:12:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 96B903844013 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=is6WmxsS Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 818AE3858409 for ; Fri, 29 Aug 2025 20:11:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 818AE3858409 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 818AE3858409 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756498312; cv=none; b=fn5XtMOc6PjSV6nhrUtw/qUPmIoloH5RYWfxcLRcLy8gscNwGv6wlTGcnGg7VeD1DkiGHITFImnd+0jWh2KXnu9/GqLNL/ZZ1LoY1HSCqV4o0RRv8yJYMfeqJci80At/BJFPsqq165Nsu4axTZxxDhp/pRlOJlywyhmNz6XopQE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756498312; c=relaxed/simple; bh=iVGRtW/3P8FPEgjHQm/Xi8L9HjkpKT6KsPdEkTQfb+k=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=AlzGZ7uUv2KZxPR4tK2pHeZGSFqYxS40CNA4J/J5hCAWEqgPcnxrYV4u6vlU5JXbA/bk2ufLkEjSJzaW4qHA2h5TpVJ7XmhiPdE8IsfVt7b22qP3za9yQ8mTMHcQqofLNcVwG6yX3g8/JuCDwANznesWyBPHN42gOowhJoEFBdQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 818AE3858409 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1756498311; bh=iVGRtW/3P8FPEgjHQm/Xi8L9HjkpKT6KsPdEkTQfb+k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=is6WmxsSD0JE1LiL7ljyaw9efk2heXisPb3XyHqNzYAWZJpFlsCal4cLGGDeHvQJq tO/uYXeJ4FWeCMUU9thQYN7+MQEU0ETeX/OSdr5OjWATYRcPKV/1zbaVQNsP8cnelW QoNhjc9sBi/3uCzG1l984lK7eQLRTsKTS0VfuYKU= Received: by simark.ca (Postfix) id 2E4BE1E023; Fri, 29 Aug 2025 16:11:51 -0400 (EDT) Message-ID: Date: Fri, 29 Aug 2025 16:11:50 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] gdbsupport: make filtered_iterator work with pointers To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20250828151100.84594-1-simon.marchi@efficios.com> <20250828151100.84594-2-simon.marchi@efficios.com> <875xe6utyx.fsf@tromey.com> <87sehat4bc.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87sehat4bc.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-08-29 13:39, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > >>> I also wonder what this constructor is even needed for since it seems >>> like a filtered iterator should just wrap an ordinary one anyway. > > Simon> I think it's just a shortcut to have less boilerplate when you need to > Simon> instantiate a filtered_iterator. I think I would prefer having just the > Simon> begin/end version, so that there is less magic involved, making it > Simon> easier to debug compilation errors, at the expense of having to be more > Simon> explicit at the call sites. I think I tried it in a previous iteration > Simon> of this series and gave up, but if you think it's a good idea, I can try > Simon> it again. > > I think you should go ahead, we can try to remove the template > constructor after. > > Approved-By: Tom Tromey > > Tom All right, I'll push this patch and do some further cleanups. Thanks, Simon