From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kEMzGtOkGmoG8ygAWB0awg (envelope-from ) for ; Sat, 30 May 2026 04:50:27 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xAyZQTE1; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2shXzdNv; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xAyZQTE1; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2shXzdNv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5CB9D1E062; Sat, 30 May 2026 04:50:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 76CD01E062 for ; Sat, 30 May 2026 04:50:26 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D99004BA7991 for ; Sat, 30 May 2026 08:50:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D99004BA7991 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xAyZQTE1; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2shXzdNv; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xAyZQTE1; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2shXzdNv Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id C38ED4BA540B for ; Sat, 30 May 2026 08:49:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C38ED4BA540B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C38ED4BA540B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780130998; cv=none; b=pi2z9zkfULsBFf2VNFy2IGsyq4OzbgWhV32hwf7vM1BZcvML2wL+SyKu5Sn9I9XdlRhAKfze0HKQs+IUNZUR9jIe+wBj/42RpnbrQ06j5v3yRp8gNTsh9CnxN9PDeanSzNuCcrlMWNF1b9jfzj36S6mFPxbAJ8EhDfRmllYaxRs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780130998; c=relaxed/simple; bh=GVh27Zs44ZPmPS3oLbOS1gKKIcHD4H+LTgs8bUzkyzw=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=Y7p951PMtQxOqda+0pm7xqgdGmuY6/PKcNfIs5S7u8pwmIttm8Y5aidAhUUeVePB0M1gDE3sUCQGCoZLazKnGHsBVN9HR2PiRxcO9ArE7vOfILqKGIA9kVKcMqhst4MZ/rHz/3Dv0uOCeJQT3SAsgZcKindpkbPVcybF3S2v0EU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xAyZQTE1; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2shXzdNv; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xAyZQTE1; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2shXzdNv DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C38ED4BA540B Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E080C67925; Sat, 30 May 2026 08:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780130997; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l+uytgq+qIzbBWcQltcZRttaCLi5IHBuMeICNqxjmSs=; b=xAyZQTE1r1TptQz0MKNUbFMy1PwJEhO2odRJCGqq3n4zdqW2GyBKEY8wEAAVtY5vT0ft1x krv8u6vRqojuhHzrY+UYHPE9UiUc/yLAth35IQ9bx2fk1ppkhGpiyrKGszh2FEDrtbjABm mCNklAof0ZW5jgmrGWxWLpXaioVooZA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780130997; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l+uytgq+qIzbBWcQltcZRttaCLi5IHBuMeICNqxjmSs=; b=2shXzdNvGlM0IjaNEZ6zeeblMjoaUUQig9zUO1dNTPyJ9oBpUoNMGRWoVKc98R/AasQB5c dicCm4xHzWFvxFCg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780130997; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l+uytgq+qIzbBWcQltcZRttaCLi5IHBuMeICNqxjmSs=; b=xAyZQTE1r1TptQz0MKNUbFMy1PwJEhO2odRJCGqq3n4zdqW2GyBKEY8wEAAVtY5vT0ft1x krv8u6vRqojuhHzrY+UYHPE9UiUc/yLAth35IQ9bx2fk1ppkhGpiyrKGszh2FEDrtbjABm mCNklAof0ZW5jgmrGWxWLpXaioVooZA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780130997; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l+uytgq+qIzbBWcQltcZRttaCLi5IHBuMeICNqxjmSs=; b=2shXzdNvGlM0IjaNEZ6zeeblMjoaUUQig9zUO1dNTPyJ9oBpUoNMGRWoVKc98R/AasQB5c dicCm4xHzWFvxFCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C582F779A7; Sat, 30 May 2026 08:49:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +bq/LrWkGmrHGwAAD6G6ig (envelope-from ); Sat, 30 May 2026 08:49:57 +0000 Message-ID: Date: Sat, 30 May 2026 10:49:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb/testsuite] Use Wno-non-c-typedef-for-linkage for gcc 16 To: Keith Seitz , gdb-patches@sourceware.org References: <20260529125149.2027857-1-tdevries@suse.de> <20260529125149.2027857-3-tdevries@suse.de> <48defad3-5b7b-4e68-8367-1468fabaeee8@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <48defad3-5b7b-4e68-8367-1468fabaeee8@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/29/26 6:25 PM, Keith Seitz wrote: > Hi, > > On 5/29/26 5:51 AM, Tom de Vries wrote: >> With gcc 16 and test-case gdb.cp/classes.exp I run into: >> ... >> classes.cc:440:15: warning: anonymous non-C-compatible type given name >> for linkage purposes by 'typedef' declaration [-Wnon-c-typedef-for- >> linkage]^M >>    440 | typedef class {^M >>        |               ^^M >>        |               DynamicBase2^M >> classes.cc:443:15: note: type is not C-compatible because it contains >> 'virtual int DynamicBase2::get_x()' declaration^M >>    443 |   virtual int get_x () { return x; }^M >>        |               ^~~~~^M >> ... >> >> Fix this by applying Wno-non-c-typedef-for-linkage, which is already >> done for >> clang. >> >> Likewise for gdb.cp/class2.exp. > > This LGTM, just one little nit. > >> diff --git a/gdb/testsuite/gdb.cp/class2.exp b/gdb/testsuite/gdb.cp/ >> class2.exp >> index 705f51ac3e0..aa2a04467f4 100644 >> --- a/gdb/testsuite/gdb.cp/class2.exp >> +++ b/gdb/testsuite/gdb.cp/class2.exp >> @@ -21,7 +21,8 @@ standard_testfile .cc >>   set flags [list debug c++] >>   # When using recent Clangs, this test fails to compile without this >> warning >>   # being disabled.  However, older Clangs fail to recognize the flag. > > This comment could use a small update. > Hi Keith, thanks for the reviews. I've updated the comment to use "Clangs/GCCs". I'll push this series after retesting on x86_64-linux. Thanks, - Tom >> -if { [gcc_major_version "clang-*" "c++"] > 10 } { >> +if { [gcc_major_version "clang-*" "c++"] > 10 >> +     || [gcc_major_version "gcc-*" "c++"] >= 16} { >>       lappend flags additional_flags=-Wno-non-c-typedef-for-linkage >>   } > > Reviewed-By: Keith Seitz > > Thank you for fixing these. > > Keith >