From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2517 invoked by alias); 9 Aug 2008 15:10:52 -0000 Received: (qmail 2493 invoked by uid 22791); 9 Aug 2008 15:10:51 -0000 X-Spam-Check-By: sourceware.org Received: from fg-out-1718.google.com (HELO fg-out-1718.google.com) (72.14.220.157) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 09 Aug 2008 15:10:16 +0000 Received: by fg-out-1718.google.com with SMTP id e12so718861fga.0 for ; Sat, 09 Aug 2008 08:10:13 -0700 (PDT) Received: by 10.86.50.8 with SMTP id x8mr4788473fgx.30.1218294613528; Sat, 09 Aug 2008 08:10:13 -0700 (PDT) Received: by 10.86.98.13 with HTTP; Sat, 9 Aug 2008 08:10:13 -0700 (PDT) Message-ID: Date: Sat, 09 Aug 2008 15:10:00 -0000 From: "Rob Quill" To: "Mark Kettenis" , rob.quill@gmail.com, gdb-patches@sourceware.org, "Daniel Jacobowitz" Subject: Re: Remove deprecated_set_value_type (part 1) In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080129195506.GE9019@caradoc.them.org> <200801301804.m0UI4eWR018093@brahms.sibelius.xs4all.nl> <20080226012037.GA4456@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00242.txt.bz2 Ping :) Rob 2008/7/27 Rob Quill : > 2008/2/26 Daniel Jacobowitz : >> On Wed, Jan 30, 2008 at 07:04:40PM +0100, Mark Kettenis wrote: >>> There are some code style problems here too, and although they're not >>> your fault, it'd be nice to fix them while you're there. Actually, it >>> looks to me as if the temparg variable is completely redundant now, so >>> the above could be simplified to >>> >>> val = value_addr (val); >> >> Mark's right; also, there are still formatting problems with the patch >> that I commented on the last time I reviewed it :-( Rob, let me know if >> you'd like me to point them out individually. > > Hi all, > > This has been a long time coming, but I've finally managed to find > some time to get this finished. Please find attached what I believe > should be the final version of this patch, checked against the current > head with no regressions. > > Rob >