From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24516 invoked by alias); 28 Jul 2008 10:31:43 -0000 Received: (qmail 24500 invoked by uid 22791); 28 Jul 2008 10:31:42 -0000 X-Spam-Check-By: sourceware.org Received: from fg-out-1718.google.com (HELO fg-out-1718.google.com) (72.14.220.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 28 Jul 2008 10:31:24 +0000 Received: by fg-out-1718.google.com with SMTP id e12so2080008fga.0 for ; Mon, 28 Jul 2008 03:31:21 -0700 (PDT) Received: by 10.86.31.18 with SMTP id e18mr2439297fge.52.1217241081788; Mon, 28 Jul 2008 03:31:21 -0700 (PDT) Received: by 10.86.98.13 with HTTP; Mon, 28 Jul 2008 03:31:21 -0700 (PDT) Message-ID: Date: Mon, 28 Jul 2008 10:31:00 -0000 From: "Rob Quill" To: "Eli Zaretskii" Subject: Re: New scope checking patch Cc: jimb@red-bean.com, gdb-patches@sourceware.org In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_13456_27420049.1217241081788" References: <8f2776cb0801301557t2e265b62u56d6df7cbcec1c84@mail.gmail.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00514.txt.bz2 ------=_Part_13456_27420049.1217241081788 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 1111 2008/7/28 Eli Zaretskii : >> Date: Mon, 28 Jul 2008 00:45:03 +0100 >> From: "Rob Quill" >> Cc: "Jim Blandy" , gdb-patches@sourceware.org >> >> This patch (like the remove deprecated_set_value_type one) has been a >> long time coming. Please find attached what I believe should be the >> final version of this patch. > > Thanks. > >> --- gdb/NEWS 18 Jul 2008 20:55:32 -0000 1.282 >> +++ gdb/NEWS 27 Jul 2008 23:02:48 -0000 >> @@ -3,6 +3,12 @@ >> >> *** Changes since GDB 6.8 >> >> +* New expression type >> + >> +$in_scope(...) >> + The value of this expression is 1 if the variable within the >> + parentheses is within the current scope, 0 otherwise. > > This is okay. > >> +provided that you check if it is in scope before you test it's value. The operator > ^^^^ > "its" I thought about that before I submitted it but couldn't make up my mind as to which was right, as the scope belongs to the variable so maybe it needed an apostrophe. Anyway, I've attached the fixed patch. Rob ------=_Part_13456_27420049.1217241081788 Content-Type: text/x-diff; name=in_scope.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_fj6xsgvt0 Content-Disposition: attachment; filename=in_scope.patch Content-length: 5775 MjAwOC0wNy0yNyAgIFJvYiBRdWlsbCA8cm9iLnF1aWxsQGdtYWlsLmNvbT4K CglBZGQgJGluX3Njb3BlIGFzIGEgdHlwZSBvZiBleHByZXNzaW9uLgoJKiBj LWV4cC55IChJTl9TQ09QRSk6IE5ldyB0b2tlbi4KCSAgKGV4cCk6IElOX1ND T1BFIChuYW1lKTogZXZhbHVhdGVzIHRvIDEgaWYgbmFtZSBpcyBpbiBzY29w ZSwKCSAgMCBvdGhlcndpc2UuCgkoeXlsZXgpOiBNYXRjaCAiJGluX3Njb3Bl IiBhcyBJTl9TQ09QRSB0b2tlbgogICAgICAgKiBnZGIudGV4aW5mbyAoZXhw cmVzc2lvbnMpOiBBZGQgYSBzbWFsbCBwYXJhZ3JhcGggKHdpdGggYW4KCSBl eGFtcGxlKSBhYm91dCB0aGUgJGluX3Njb3BlIG9wZXJhdG9yLgogICAgICAg KiBORVdTOiBNZW50aW9ucyAkaW5fc2NvcGUuCgpJbmRleDogZ2RiL05FV1MK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3Jj L2dkYi9ORVdTLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjI4MgpkaWZmIC11 IC1wIC1yMS4yODIgTkVXUwotLS0gZ2RiL05FV1MJMTggSnVsIDIwMDggMjA6 NTU6MzIgLTAwMDAJMS4yODIKKysrIGdkYi9ORVdTCTI3IEp1bCAyMDA4IDIz OjAyOjQ4IC0wMDAwCkBAIC0zLDYgKzMsMTIgQEAKIAogKioqIENoYW5nZXMg c2luY2UgR0RCIDYuOAogCisqIE5ldyBleHByZXNzaW9uIHR5cGUKKworJGlu X3Njb3BlKC4uLikKKyAgVGhlIHZhbHVlIG9mIHRoaXMgZXhwcmVzc2lvbiBp cyAxIGlmIHRoZSB2YXJpYWJsZSB3aXRoaW4gdGhlCisgIHBhcmVudGhlc2Vz IGlzIHdpdGhpbiB0aGUgY3VycmVudCBzY29wZSwgMCBvdGhlcndpc2UuCisK ICogQ29tbWFuZHMgYHNldCBkZWJ1Zy1maWxlLWRpcmVjdG9yeScsIGBzZXQg c29saWItc2VhcmNoLXBhdGgnIGFuZCBgc2V0IGFyZ3MnCiBub3cgY29tcGxl dGUgb24gZmlsZSBuYW1lcy4KIApJbmRleDogZ2RiL2MtZXhwLnkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9j LWV4cC55LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjQ2CmRpZmYgLXUgLXAg LXIxLjQ2IGMtZXhwLnkKLS0tIGdkYi9jLWV4cC55CTI1IEp1biAyMDA4IDE1 OjQ5OjIwIC0wMDAwCTEuNDYKKysrIGdkYi9jLWV4cC55CTI3IEp1bCAyMDA4 IDIzOjAyOjQ5IC0wMDAwCkBAIC0yMDksNiArMjA5LDggQEAgc3RhdGljIGlu dCBwYXJzZV9udW1iZXIgKGNoYXIgKiwgaW50LCBpbgogJXRva2VuIFRSVUVL RVlXT1JECiAldG9rZW4gRkFMU0VLRVlXT1JECiAKKy8qICRpbl9zY29wZSBv cHBlcmF0b3IgKi8KKyV0b2tlbiBJTl9TQ09QRQogCiAlbGVmdCAnLCcKICVs ZWZ0IEFCT1ZFX0NPTU1BCkBAIC0yNTIsNiArMjU0LDMwIEBAIGV4cDEJOgll eHAKIAk7CiAKIC8qIEV4cHJlc3Npb25zLCBub3QgaW5jbHVkaW5nIHRoZSBj b21tYSBvcGVyYXRvci4gICovCitleHAgICAgOiAgICAgICBJTl9TQ09QRSAn KCcgbmFtZV9ub3RfdHlwZW5hbWUgJyknCisgICAgICAgICAgICAgICAgICAg ICAgIHsKKyAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgdHlwZSAq aW50X3R5cGU7CisgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IG1p bmltYWxfc3ltYm9sICptaW5fc3ltYm9sOworCisgICAgICAgICAgICAgICAg ICAgICAgICAgLyogSWYgdGhlcmUgYXJlIG5vIHN5bWJvbHMgdGhlbiBqdXN0 IHN0b3AgcmlnaHQgYXdheSAqLworICAgICAgICAgICAgICAgICAgICAgICAg IGlmICghaGF2ZV9mdWxsX3N5bWJvbHMgKCkgJiYgIWhhdmVfcGFydGlhbF9z eW1ib2xzICgpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgZXJyb3Ig KCJObyBzeW1ib2wgdGFibGUgaXMgbG9hZGVkLiAgVXNlIHRoZSBcImZpbGVc IiBjb21tYW5kLiIpOworCisgICAgICAgICAgICAgICAgICAgICAgICAgLyog T3RoZXJ3aXNlLCBwcmVwYXJlIHRvIHdyaXRlIG91dCB0aGUgdmFsdWUgKi8K KyAgICAgICAgICAgICAgICAgICAgICAgICBpbnRfdHlwZSA9IGJ1aWx0aW5f dHlwZSAoY3VycmVudF9nZGJhcmNoKS0+YnVpbHRpbl9pbnQ7CisgICAgICAg ICAgICAgICAgICAgICAgICAgd3JpdGVfZXhwX2VsdF9vcGNvZGUgKE9QX0xP TkcpOworICAgICAgICAgICAgICAgICAgICAgICAgIHdyaXRlX2V4cF9lbHRf dHlwZSAoaW50X3R5cGUpOworCisgICAgICAgICAgICAgICAgICAgICAgICAg bWluX3N5bWJvbCA9CisgICAgICAgICAgICAgICAgICAgICAgICAgICBsb29r dXBfbWluaW1hbF9zeW1ib2wgKGNvcHlfbmFtZSgkMy5zdG9rZW4pLCBOVUxM LCBOVUxMKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoJDMuc3lt IHx8IG1pbl9zeW1ib2wpCisgICAgICAgICAgICAgICAgICAgICAgICAgICB3 cml0ZV9leHBfZWx0X2xvbmdjc3QgKChMT05HRVNUKSAxKTsKKyAgICAgICAg ICAgICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgICAgICAg ICAgICB3cml0ZV9leHBfZWx0X2xvbmdjc3QgKChMT05HRVNUKSAwKTsKKwor ICAgICAgICAgICAgICAgICAgICAgICAgIHdyaXRlX2V4cF9lbHRfb3Bjb2Rl IChPUF9MT05HKTsgfQorICAgICAgIDsKKwogZXhwCToJJyonIGV4cCAgICAl cHJlYyBVTkFSWQogCQkJeyB3cml0ZV9leHBfZWx0X29wY29kZSAoVU5PUF9J TkQpOyB9CiAJOwpAQCAtMTczOSw2ICsxNzY1LDkgQEAgeXlsZXggKCkKICAg LyogQ2F0Y2ggc3BlY2lmaWMga2V5d29yZHMuICBTaG91bGQgYmUgZG9uZSB3 aXRoIGEgZGF0YSBzdHJ1Y3R1cmUuICAqLwogICBzd2l0Y2ggKG5hbWVsZW4p CiAgICAgeworICAgIGNhc2UgOToKKyAgICAgIGlmIChzdHJuY21wICh0b2tz dGFydCwgIiRpbl9zY29wZSIsIDkpID09IDApCisgICAgICAgIHJldHVybiBJ Tl9TQ09QRTsKICAgICBjYXNlIDg6CiAgICAgICBpZiAoc3RybmNtcCAodG9r c3RhcnQsICJ1bnNpZ25lZCIsIDgpID09IDApCiAJcmV0dXJuIFVOU0lHTkVE OwpJbmRleDogZ2RiL2RvYy9nZGIudGV4aW5mbwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2RvYy9nZGIudGV4 aW5mbyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS41MDkKZGlmZiAtdSAtcCAt cjEuNTA5IGdkYi50ZXhpbmZvCi0tLSBnZGIvZG9jL2dkYi50ZXhpbmZvCTE4 IEp1bCAyMDA4IDIwOjU1OjMzIC0wMDAwCTEuNTA5CisrKyBnZGIvZG9jL2dk Yi50ZXhpbmZvCTI3IEp1bCAyMDA4IDIzOjAzOjExIC0wMDAwCkBAIC01NzUw LDYgKzU3NTAsMjQgQEAgbWVtb3J5LiAgQHZhcnthZGRyfSBtYXkgYmUgYW55 IGV4cHJlc3NpbwogcG9pbnRlciAoYnV0IHBhcmVudGhlc2VzIGFyZSByZXF1 aXJlZCBhcm91bmQgYmluYXJ5IG9wZXJhdG9ycywganVzdCBhcyBpbgogYSBj YXN0KS4gIFRoaXMgY29uc3RydWN0IGlzIGFsbG93ZWQgcmVnYXJkbGVzcyBv ZiB3aGF0IGtpbmQgb2YgZGF0YSBpcwogbm9ybWFsbHkgc3VwcG9zZWQgdG8g cmVzaWRlIGF0IEB2YXJ7YWRkcn0uCisKK0B2aW5kZXggJGluX3Njb3BlCitA Y2luZGV4IHZhcmlhYmxlIGluIHNjb3BlLCB0ZXN0aW5nCitAaXRlbSAkaW5f c2NvcGUKK0BzYW1weyRpbl9zY29wZX0gYWxsb3dzIHlvdSB0byBjaGVjayBp ZiBhIHZhcmlhYmxlIGlzIGluIHNjb3BlLAorcmV0dXJuaW5nIDEgaWYgaXQg aXMgYW5kIDAgaWYgaXQgaXMgbm90LiAgVGhpcyBpcyBtb3N0IHVzZWZ1bCB3 aGVuIHNjcmlwdGluZyBAdmFsdWV7R0RCTn0KK2FzIGl0IG1lYW5zIHRoYXQg dGhlIHNjcmlwdCB3aWxsIG5vdCBzdG9wIGV4ZWN1dGluZyBpZiBhIHZhcmlh YmxlIGlzIG5vdCBpbiBzY29wZSwKK3Byb3ZpZGVkIHRoYXQgeW91IGNoZWNr IGlmIGl0IGlzIGluIHNjb3BlIGJlZm9yZSB5b3UgdGVzdCBpdHMgdmFsdWUu ICBUaGUgb3BlcmF0b3IKK29ubHkgd29ya3Mgb24gdmFyaWFibGVzIGFuZCB3 aWxsIG5vdCB3b3JrIG9uIHN0cnVjdHVyZSBtZW1iZXJzIG9yIGFycmF5IGVs ZW1lbnRzCitmb3IgaW5zdGFuY2UuCisKK0FuIGV4YW1wbGUgdXNhZ2UgZnJv bSBhIEdEQiBzY3JpcHQgbWF5IGJlOgorCitAc21hbGxleGFtcGxlCitpZiAo JGluX3Njb3BlKGEpID09IDEgJiYgJGluX3Njb3BlKGIpID09IDEpCisgIHBy aW50IGErYiAgCitAZW5kIHNtYWxsZXhhbXBsZQorCiBAZW5kIHRhYmxlCiAK IEBub2RlIEFtYmlndW91cyBFeHByZXNzaW9ucwo= ------=_Part_13456_27420049.1217241081788--