From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8993 invoked by alias); 27 Jul 2008 19:16:36 -0000 Received: (qmail 8982 invoked by uid 22791); 27 Jul 2008 19:16:34 -0000 X-Spam-Check-By: sourceware.org Received: from fg-out-1718.google.com (HELO fg-out-1718.google.com) (72.14.220.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 27 Jul 2008 19:16:14 +0000 Received: by fg-out-1718.google.com with SMTP id e12so1992897fga.0 for ; Sun, 27 Jul 2008 12:16:11 -0700 (PDT) Received: by 10.86.70.11 with SMTP id s11mr1829259fga.79.1217186171440; Sun, 27 Jul 2008 12:16:11 -0700 (PDT) Received: by 10.86.98.13 with HTTP; Sun, 27 Jul 2008 12:16:11 -0700 (PDT) Message-ID: Date: Sun, 27 Jul 2008 19:16:00 -0000 From: "Rob Quill" To: "Mark Kettenis" , rob.quill@gmail.com, gdb-patches@sourceware.org, "Daniel Jacobowitz" Subject: Re: Remove deprecated_set_value_type (part 1) In-Reply-To: <20080226012037.GA4456@caradoc.them.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_6770_20562509.1217186171447" References: <20080129195506.GE9019@caradoc.them.org> <200801301804.m0UI4eWR018093@brahms.sibelius.xs4all.nl> <20080226012037.GA4456@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00505.txt.bz2 ------=_Part_6770_20562509.1217186171447 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 857 2008/2/26 Daniel Jacobowitz : > On Wed, Jan 30, 2008 at 07:04:40PM +0100, Mark Kettenis wrote: >> There are some code style problems here too, and although they're not >> your fault, it'd be nice to fix them while you're there. Actually, it >> looks to me as if the temparg variable is completely redundant now, so >> the above could be simplified to >> >> val = value_addr (val); > > Mark's right; also, there are still formatting problems with the patch > that I commented on the last time I reviewed it :-( Rob, let me know if > you'd like me to point them out individually. Hi all, This has been a long time coming, but I've finally managed to find some time to get this finished. Please find attached what I believe should be the final version of this patch, checked against the current head with no regressions. Rob ------=_Part_6770_20562509.1217186171447 Content-Type: text/x-diff; name=remove_deprecated_set_value_type.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_fj615ixy0 Content-Disposition: attachment; filename=remove_deprecated_set_value_type.patch Content-length: 9244 CVJlbW92ZXMgc29tZSB1c2VzIG9mIGRlcHJlY2F0ZWRfc2V0X3ZhbHVlX3R5 cGUKCSogYWRhLWxhbmcuYyAoYWRhX2NvZXJjZV90b19zaW1wbGVfYXJyYXlf dHlwZSk6IENyZWF0ZSBhIG5ldyB6ZXJvCgkgIHZhbHVlIG9mIHRoZSBjb3Jy ZWN0IHR5cGUgaW5zdGVhZCBvZiBjaGFuZ2luZyB0eXBlLgoJKiBjLXZhbHBy aW50LmMgKGNfdmFsdWVfcHJpbnQpOiBDYWxsIGNvcHlfdmFsdWVfYW5kX2No YW5nZV90eXBlLgoJKiBwcmludGNtZC5jIChwcmludGZfY29tbWFuZCk6IENy ZWF0ZSBhIHplcm8gdmFsdWUgb2YgdGhlCgkgIGNvcnJlY3QgdHlwZSBhbmQg Y29weSB0aGUgY29udGVudHMgb2YgdGhlIG9sZCB2YWx1ZSBpbnRvIGl0LgoJ KiB2YWxvcHMuYyAodmFsdWVfY2FzdF9wb2ludGVycywgdmFsdWVfY2FzdCwg dmFsdWVfYXNzaWduLAoJICB2YWx1ZV9hZGRyKTogQ2FsbCB2YWx1ZV92YWx1 ZV9jb3B5X2FuZF9jaGFuZ2VfdHlwZSBpbnN0ZWFkCgkgIG9mIGNvcHlpbmcg dGhlIHZhbHVlIGFuZCB0aGVuIGNoYW5naW5nIHRoZSB0eXBlLgoJKiB2YWx1 ZS5jICh2YWx1ZV9jb3B5X2FuZF9jaGFuZ2VfdHlwZSk6IERlZmluZS4KCSog dmFsdWUuaCAodmFsdWVfY29weV9hbmRfY2hhbmdlX3R5cGUpOiBEZWNsYXJl LgoKSW5kZXg6IGFkYS1sYW5nLmMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpS Q1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9hZGEtbGFuZy5jLHYKcmV0cmll dmluZyByZXZpc2lvbiAxLjE1MQpkaWZmIC11IC1wIC1yMS4xNTEgYWRhLWxh bmcuYwotLS0gYWRhLWxhbmcuYwkyMSBKdWwgMjAwOCAxNjo0NzoxMCAtMDAw MAkxLjE1MQorKysgYWRhLWxhbmcuYwkyNiBKdWwgMjAwOCAyMjoxNjoyOSAt MDAwMApAQCAtMTc2Nyw5ICsxNzY3LDggQEAgc3RydWN0IHR5cGUgKgogYWRh X2NvZXJjZV90b19zaW1wbGVfYXJyYXlfdHlwZSAoc3RydWN0IHR5cGUgKnR5 cGUpCiB7CiAgIHN0cnVjdCB2YWx1ZSAqbWFyayA9IHZhbHVlX21hcmsgKCk7 Ci0gIHN0cnVjdCB2YWx1ZSAqZHVtbXkgPSB2YWx1ZV9mcm9tX2xvbmdlc3Qg KGJ1aWx0aW5fdHlwZV9sb25nLCAwKTsKKyAgc3RydWN0IHZhbHVlICpkdW1t eSA9IHZhbHVlX3plcm8gKHR5cGUsIG5vdF9sdmFsKTsKICAgc3RydWN0IHR5 cGUgKnJlc3VsdDsKLSAgZGVwcmVjYXRlZF9zZXRfdmFsdWVfdHlwZSAoZHVt bXksIHR5cGUpOwogICByZXN1bHQgPSBhZGFfdHlwZV9vZl9hcnJheSAoZHVt bXksIDApOwogICB2YWx1ZV9mcmVlX3RvX21hcmsgKG1hcmspOwogICByZXR1 cm4gcmVzdWx0OwpJbmRleDogYy12YWxwcmludC5jCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvYy12YWxwcmlu dC5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjUwCmRpZmYgLXUgLXAgLXIx LjUwIGMtdmFscHJpbnQuYwotLS0gYy12YWxwcmludC5jCTE5IE1heSAyMDA4 IDE1OjUwOjA5IC0wMDAwCTEuNTAKKysrIGMtdmFscHJpbnQuYwkyNiBKdWwg MjAwOCAyMjoxNjoyOSAtMDAwMApAQCAtNTYyLDEwICs1NjIsNyBAQCBjX3Zh bHVlX3ByaW50IChzdHJ1Y3QgdmFsdWUgKnZhbCwgc3RydWN0CiAJICAgICAg LyogQ29weSB2YWx1ZSwgY2hhbmdlIHRvIHBvaW50ZXIsIHNvIHdlIGRvbid0 IGdldCBhbgogCSAgICAgICAqIGVycm9yIGFib3V0IGEgbm9uLXBvaW50ZXIg dHlwZSBpbiB2YWx1ZV9ydHRpX3RhcmdldF90eXBlCiAJICAgICAgICovCi0J ICAgICAgc3RydWN0IHZhbHVlICp0ZW1wYXJnOwotCSAgICAgIHRlbXBhcmc9 dmFsdWVfY29weSh2YWwpOwotCSAgICAgIGRlcHJlY2F0ZWRfc2V0X3ZhbHVl X3R5cGUgKHRlbXBhcmcsIGxvb2t1cF9wb2ludGVyX3R5cGUgKFRZUEVfVEFS R0VUX1RZUEUodHlwZSkpKTsKLQkgICAgICB2YWw9dGVtcGFyZzsKKwkgICAg ICB2YWw9dmFsdWVfYWRkciAodmFsKTsKIAkgICAgfQogCSAgLyogUG9pbnRl ciB0byBjbGFzcywgY2hlY2sgcmVhbCB0eXBlIG9mIG9iamVjdCAqLwogCSAg ZnByaW50Zl9maWx0ZXJlZCAoc3RyZWFtLCAiKCIpOwpJbmRleDogcHJpbnRj bWQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Ny Yy9zcmMvZ2RiL3ByaW50Y21kLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEu MTI3CmRpZmYgLXUgLXAgLXIxLjEyNyBwcmludGNtZC5jCi0tLSBwcmludGNt ZC5jCTYgSnVuIDIwMDggMjA6NTg6MDggLTAwMDAJMS4xMjcKKysrIHByaW50 Y21kLmMJMjYgSnVsIDIwMDggMjI6MTY6MzAgLTAwMDAKQEAgLTIwMDUsOSAr MjAwNSwyMSBAQCBwcmludGZfY29tbWFuZCAoY2hhciAqYXJnLCBpbnQgZnJv bV90dHkpCiAJICB7CiAJICAgIHN0cnVjdCB0eXBlICp0eXBlID0gdmFsdWVf dHlwZSAodmFsX2FyZ3NbbmFyZ3NdKTsKIAkgICAgaWYgKFRZUEVfTEVOR1RI ICh0eXBlKSA9PSBzaXplb2YgKGZsb2F0KSkKLQkgICAgICBkZXByZWNhdGVk X3NldF92YWx1ZV90eXBlICh2YWxfYXJnc1tuYXJnc10sIGJ1aWx0aW5fdHlw ZV9mbG9hdCk7CisgICAgICAgIHsKKyAgICAgICAgICBzdHJ1Y3QgdmFsdWUg KnRlbXAgPSB2YWx1ZV96ZXJvIChidWlsdGluX3R5cGVfZmxvYXQsIG5vdF9s dmFsKTsKKyAgICAgICAgICBtZW1jcHkgKHZhbHVlX2NvbnRlbnRzX3dyaXRl YWJsZSAodGVtcCksCisgICAgICAgICAgICAgICAgICAgICAgICAgIHZhbHVl X2NvbnRlbnRzICh2YWxfYXJnc1tuYXJnc10pLAorICAgICAgICAgICAgICAg ICAgICAgICAgICBUWVBFX0xFTkdUSCAoYnVpbHRpbl90eXBlX2Zsb2F0KSk7 CisgICAgICAgICAgdmFsX2FyZ3NbbmFyZ3NdID0gdGVtcDsKKyAgICAgICAg fQogCSAgICBpZiAoVFlQRV9MRU5HVEggKHR5cGUpID09IHNpemVvZiAoZG91 YmxlKSkKLQkgICAgICBkZXByZWNhdGVkX3NldF92YWx1ZV90eXBlICh2YWxf YXJnc1tuYXJnc10sIGJ1aWx0aW5fdHlwZV9kb3VibGUpOworICAgICAgICB7 CisgICAgICAgICAgc3RydWN0IHZhbHVlICp0ZW1wID0gdmFsdWVfemVybyAo YnVpbHRpbl90eXBlX2RvdWJsZSwgbm90X2x2YWwpOworICAgICAgICAgIG1l bWNweSAodmFsdWVfY29udGVudHNfd3JpdGVhYmxlICh0ZW1wKSwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgdmFsdWVfY29udGVudHMgKHZhbF9hcmdz W25hcmdzXSksCisgICAgICAgICAgICAgICAgICAgICAgICAgIFRZUEVfTEVO R1RIIChidWlsdGluX3R5cGVfZG91YmxlKSk7CisgICAgICAgICAgdmFsX2Fy Z3NbbmFyZ3NdID0gdGVtcDsKKyAgICAgICAgfQogCSAgfQogCW5hcmdzKys7 CiAJcyA9IHMxOwpJbmRleDogdmFsb3BzLmMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi92YWxvcHMuYyx2CnJl dHJpZXZpbmcgcmV2aXNpb24gMS4xOTIKZGlmZiAtdSAtcCAtcjEuMTkyIHZh bG9wcy5jCi0tLSB2YWxvcHMuYwkxNSBKdWwgMjAwOCAyMjoxMzo0MiAtMDAw MAkxLjE5MgorKysgdmFsb3BzLmMJMjYgSnVsIDIwMDggMjI6MTY6MzIgLTAw MDAKQEAgLTI4MSw4ICsyODEsNyBAQCB2YWx1ZV9jYXN0X3BvaW50ZXJzIChz dHJ1Y3QgdHlwZSAqdHlwZSwgCiAgICB9CiAKICAgLyogTm8gc3VwZXJjbGFz cyBmb3VuZCwganVzdCBjaGFuZ2UgdGhlIHBvaW50ZXIgdHlwZS4gICovCi0g IGFyZzIgPSB2YWx1ZV9jb3B5IChhcmcyKTsKLSAgZGVwcmVjYXRlZF9zZXRf dmFsdWVfdHlwZSAoYXJnMiwgdHlwZSk7CisgIGFyZzIgPSB2YWx1ZV9jb3B5 X2FuZF9jaGFuZ2VfdHlwZSAoYXJnMiwgdHlwZSk7CiAgIGFyZzIgPSB2YWx1 ZV9jaGFuZ2VfZW5jbG9zaW5nX3R5cGUgKGFyZzIsIHR5cGUpOwogICBzZXRf dmFsdWVfcG9pbnRlZF90b19vZmZzZXQgKGFyZzIsIDApOwkvKiBwYWk6IGNo a192YWwgKi8KICAgcmV0dXJuIGFyZzI7CkBAIC00ODAsOCArNDc5LDcgQEAg dmFsdWVfY2FzdCAoc3RydWN0IHR5cGUgKnR5cGUsIHN0cnVjdCB2YQogICAg ICAgaWYgKGNvZGUxID09IFRZUEVfQ09ERV9QVFIgJiYgY29kZTIgPT0gVFlQ RV9DT0RFX1BUUikKIAlyZXR1cm4gdmFsdWVfY2FzdF9wb2ludGVycyAodHlw ZSwgYXJnMik7CiAKLSAgICAgIGFyZzIgPSB2YWx1ZV9jb3B5IChhcmcyKTsK LSAgICAgIGRlcHJlY2F0ZWRfc2V0X3ZhbHVlX3R5cGUgKGFyZzIsIHR5cGUp OworICAgICAgYXJnMiA9IHZhbHVlX2NvcHlfYW5kX2NoYW5nZV90eXBlIChh cmcyLCB0eXBlKTsKICAgICAgIGFyZzIgPSB2YWx1ZV9jaGFuZ2VfZW5jbG9z aW5nX3R5cGUgKGFyZzIsIHR5cGUpOwogICAgICAgc2V0X3ZhbHVlX3BvaW50 ZWRfdG9fb2Zmc2V0IChhcmcyLCAwKTsJLyogcGFpOiBjaGtfdmFsICovCiAg ICAgICByZXR1cm4gYXJnMjsKQEAgLTkyNiwxMCArOTI0LDkgQEAgdmFsdWVf YXNzaWduIChzdHJ1Y3QgdmFsdWUgKnRvdmFsLCBzdHJ1YwogICAgICAgZnJv bXZhbCA9IHZhbHVlX2Zyb21fbG9uZ2VzdCAodHlwZSwgZmllbGR2YWwpOwog ICAgIH0KIAotICB2YWwgPSB2YWx1ZV9jb3B5ICh0b3ZhbCk7CisgIHZhbCA9 IHZhbHVlX2NvcHlfYW5kX2NoYW5nZV90eXBlICh0b3ZhbCwgdHlwZSk7CiAg IG1lbWNweSAodmFsdWVfY29udGVudHNfcmF3ICh2YWwpLCB2YWx1ZV9jb250 ZW50cyAoZnJvbXZhbCksCiAJICBUWVBFX0xFTkdUSCAodHlwZSkpOwotICBk ZXByZWNhdGVkX3NldF92YWx1ZV90eXBlICh2YWwsIHR5cGUpOwogICB2YWwg PSB2YWx1ZV9jaGFuZ2VfZW5jbG9zaW5nX3R5cGUgKHZhbCwgCiAJCQkJICAg ICB2YWx1ZV9lbmNsb3NpbmdfdHlwZSAoZnJvbXZhbCkpOwogICBzZXRfdmFs dWVfZW1iZWRkZWRfb2Zmc2V0ICh2YWwsIHZhbHVlX2VtYmVkZGVkX29mZnNl dCAoZnJvbXZhbCkpOwpAQCAtMTEwNiw4ICsxMTAzLDggQEAgdmFsdWVfYWRk ciAoc3RydWN0IHZhbHVlICphcmcxKQogICAgICAgICAga2VlcCB0aGUgc2Ft ZSBsb2NhdGlvbiBpbmZvcm1hdGlvbiwgd2hpY2ggaXMgZWZmaWNpZW50LCBh bmQKICAgICAgICAgIGFsbG93cyAmKCZYKSB0byBnZXQgdGhlIGxvY2F0aW9u IGNvbnRhaW5pbmcgdGhlIHJlZmVyZW5jZS4gICovCiAgICAgICBhcmcyID0g dmFsdWVfY29weSAoYXJnMSk7Ci0gICAgICBkZXByZWNhdGVkX3NldF92YWx1 ZV90eXBlIChhcmcyLCAKLQkJCQkgbG9va3VwX3BvaW50ZXJfdHlwZSAoVFlQ RV9UQVJHRVRfVFlQRSAodHlwZSkpKTsKKyAgICAgIGFyZzIgPSB2YWx1ZV9j b3B5X2FuZF9jaGFuZ2VfdHlwZSAoYXJnMSwKKyAgICAgICAgICAgICAgICAg ICAgICAgICBsb29rdXBfcG9pbnRlcl90eXBlIChUWVBFX1RBUkdFVF9UWVBF ICh0eXBlKSkpOwogICAgICAgcmV0dXJuIGFyZzI7CiAgICAgfQogICBpZiAo VFlQRV9DT0RFICh0eXBlKSA9PSBUWVBFX0NPREVfRlVOQykKSW5kZXg6IHZh bHVlLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9z cmMvc3JjL2dkYi92YWx1ZS5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjY0 CmRpZmYgLXUgLXAgLXIxLjY0IHZhbHVlLmMKLS0tIHZhbHVlLmMJMTEgSnVu IDIwMDggMTk6NTk6MDkgLTAwMDAJMS42NAorKysgdmFsdWUuYwkyNiBKdWwg MjAwOCAyMjoxNjozMyAtMDAwMApAQCAtMjc2LDYgKzI3NiwxNSBAQCBkZXBy ZWNhdGVkX3NldF92YWx1ZV90eXBlIChzdHJ1Y3QgdmFsdWUgCiAgIHZhbHVl LT50eXBlID0gdHlwZTsKIH0KIAorc3RydWN0IHZhbHVlICoKK3ZhbHVlX2Nv cHlfYW5kX2NoYW5nZV90eXBlIChzdHJ1Y3QgdmFsdWUgKmFyZywgc3RydWN0 IHR5cGUgKnR5cGUpCit7CisgIHN0cnVjdCB2YWx1ZSAqdmFsID0gdmFsdWVf Y29weSAoYXJnKTsKKyAgdmFsLT50eXBlID0gdHlwZTsKKworICByZXR1cm4g dmFsOworfQorCiBpbnQKIHZhbHVlX29mZnNldCAoc3RydWN0IHZhbHVlICp2 YWx1ZSkKIHsKSW5kZXg6IHZhbHVlLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi92YWx1ZS5oLHYKcmV0cmll dmluZyByZXZpc2lvbiAxLjExNQpkaWZmIC11IC1wIC1yMS4xMTUgdmFsdWUu aAotLS0gdmFsdWUuaAk2IEp1biAyMDA4IDIwOjU4OjA4IC0wMDAwCTEuMTE1 CisrKyB2YWx1ZS5oCTI2IEp1bCAyMDA4IDIyOjE2OjM0IC0wMDAwCkBAIC01 Nyw2ICs1NywxMiBAQCBleHRlcm4gc3RydWN0IHR5cGUgKnZhbHVlX3R5cGUg KHN0cnVjdCB2CiBleHRlcm4gdm9pZCBkZXByZWNhdGVkX3NldF92YWx1ZV90 eXBlIChzdHJ1Y3QgdmFsdWUgKnZhbHVlLAogCQkJCSAgICAgICBzdHJ1Y3Qg dHlwZSAqdHlwZSk7CiAKKy8qIENvcHkgQVJHIHRvIG5ldyB2YWx1ZS4gVGhl IG5ldyB2YWx1ZSBpcyBleGFjdGx5IHRoZSBzYW1lLCBleGNlcHQKKyAgIGZv ciBpdHMgdHlwZSwgd2hpY2ggaXMgc2V0IHRvIFRZUEUuICAqLworCitleHRl cm4gc3RydWN0IHZhbHVlICp2YWx1ZV9jb3B5X2FuZF9jaGFuZ2VfdHlwZSAo c3RydWN0IHZhbHVlICphcmcsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB0eXBlICp0eXBlKTsKKwog LyogT25seSB1c2VkIGZvciBiaXRmaWVsZHM7IG51bWJlciBvZiBiaXRzIGNv bnRhaW5lZCBpbiB0aGVtLiAgKi8KIAogZXh0ZXJuIGludCB2YWx1ZV9iaXRz aXplIChzdHJ1Y3QgdmFsdWUgKik7Cg== ------=_Part_6770_20562509.1217186171447--