2008/2/26 Daniel Jacobowitz : > On Wed, Jan 30, 2008 at 07:04:40PM +0100, Mark Kettenis wrote: >> There are some code style problems here too, and although they're not >> your fault, it'd be nice to fix them while you're there. Actually, it >> looks to me as if the temparg variable is completely redundant now, so >> the above could be simplified to >> >> val = value_addr (val); > > Mark's right; also, there are still formatting problems with the patch > that I commented on the last time I reviewed it :-( Rob, let me know if > you'd like me to point them out individually. Hi all, This has been a long time coming, but I've finally managed to find some time to get this finished. Please find attached what I believe should be the final version of this patch, checked against the current head with no regressions. Rob