From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sFoFLvr+S2hrVQwAWB0awg (envelope-from ) for ; Fri, 13 Jun 2025 06:35:38 -0400 Received: by simark.ca (Postfix, from userid 112) id A63811E102; Fri, 13 Jun 2025 06:35:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 123CC1E089 for ; Fri, 13 Jun 2025 06:35:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9899F386F1FC for ; Fri, 13 Jun 2025 10:35:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9899F386F1FC Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by sourceware.org (Postfix) with ESMTPS id 47B79386D2F1 for ; Fri, 13 Jun 2025 10:34:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47B79386D2F1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 47B79386D2F1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749810898; cv=none; b=Zi+BqfhuxGs28JYPw0Rhzf30pZ19C5m+ka5Rp4l6pFnD76MOr3BhHds4JlgAuhZPYqMDmKCDeX2uuMDZMjtftTR0kkOzRqTvDDOEBs1awSZyrTxB2nMoqa3gGmaKk5t8VNaFsl7Uro8sLlJXOwMCov5n1zCOT42mDLTmxG3ca+w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749810898; c=relaxed/simple; bh=jt1A0qO7rsVThJIACxxJ8isf/YPj9QumK9AitCfSKXc=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=j2tloMv1ezStR9qknAbAiOdQDXi+5S/VxQ3h07h3obttOH29u6AEvfIjc4vwgf3sijcoCZKAxOI+bYxqwtWQ9JJvJQ39Ki2VF3OpbGCYZJgBAV8JZqtNU9jHisc0hG2Sm2EdsGk8lkGbKahQiV5VTQ6jYVqhm+IIqQAErfDZYDo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 47B79386D2F1 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-450ce671a08so11971065e9.3 for ; Fri, 13 Jun 2025 03:34:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749810897; x=1750415697; h=in-reply-to:content-language:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JeDGzEbsbDPK3cjr+yZxEJHRrSDfnlDZrdvb2l4eZ7U=; b=Fi9HI9CPagA39BexSb2Z6uPp9zZA7V6YFLAd4fKvPiW+93Z8mTnLG05NXvQ2ajhYvf 2LeelFKTTweGUYKnwxVuN6Hloy+wgRJ8zljZk3KlS2XPtXfz+ohJ119NjkJturH16QGA ArgHJ6JPB0KU8dlP3xLHlmiQtDNDq8LgvTCeH3H+paggQntUzuJkDgiQ99OIHpwGDSIN o1xwpYzOjV0fhP+1iQwGhnZ1l0BrnB43aoTvwzVaB68gqgUMYT3zIneNYVA5V2uRMUxW sjGz0I/aJUOjbK04FNxa3gda+RVUDlrOk4wizak2fmSVv845k7CyEQE2AoyRkR8r2QQ/ Vuqg== X-Gm-Message-State: AOJu0YxZ2zbsuQ4d5uSPHh0iAKYYrUgkDdbmhFq4/jMPSI/oWminkbEr FPewMIG4LYXxn0BF2ZyYDvJKOQRxTAXjQXOvNQKSN6pwvDuFwj8lHBkULlmgTT/1 X-Gm-Gg: ASbGncsy7xgkX4WjypRML10CP2MLX5OPS+Q2I+qM/HO/VfwtXyuAm53MAkdeJRL7+Uh Ve3cImvg27dFVeBcV6S7rpXiSZEHa0p9vp59IyJarnFmjToYjy3KbUpVEexAP6utTb7OiS4yLEY 2D4lpL6eBjHquhDgptck6zNqRgUp1L8ttvET1UCCUCv7j1YrvsAPpRcG0rl1NUwWwe7JKEopNCe 8w9e9TiJ9YD+Vr1oDlbB5UYQFBEp2aYFiEOLWuC1kzly/hT4BbAn+tflYg5HM8nzyif1VAJuKqn 02EWSqRyCRCuiDkQMudE7zhRayoskEWiGtv0108u+VgWd0doRZt9BWtmNjfyiDIBFUytBjdjfdt KQ54wnMebeRNPH88cbMtsIf7TOi8PvQ== X-Google-Smtp-Source: AGHT+IHzVX6DGLIxgQ/x36pCJInulOxW3Ec1WMk1krIjJ2rAvtUlE9yN8CkDTL9yPF7dUoBBNLEqOw== X-Received: by 2002:a05:600c:1d8f:b0:44b:1f5b:8c85 with SMTP id 5b1f17b1804b1-45334a83da6mr29349285e9.13.1749810896647; Fri, 13 Jun 2025 03:34:56 -0700 (PDT) Received: from ?IPV6:2001:8a0:facf:2b00:c8f9:cf08:f10f:e494? ([2001:8a0:facf:2b00:c8f9:cf08:f10f:e494]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea1925sm49369385e9.12.2025.06.13.03.34.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 03:34:55 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------uwnT5U08zbJo5iKsQy3KtHqH" Message-ID: Date: Fri, 13 Jun 2025 11:34:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 00/47] Windows non-stop mode To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250519132308.3553663-1-pedro@palves.net> <87ldq6ax6c.fsf@tromey.com> <747c4557-0eb3-4f5a-8ad0-cf734d69d59e@palves.net> <87h60kn4rh.fsf@tromey.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <87h60kn4rh.fsf@tromey.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This is a multi-part message in MIME format. --------------uwnT5U08zbJo5iKsQy3KtHqH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2025-06-12 20:23, Tom Tromey wrote: > Pedro> Is the test using scheduler locking (and was previously ignoring the error > Pedro> that "set scheduler-locking on" currently issues on Windows) ? > > Nope. The test is fairly basic. I've appended the two files (the test > script and the Ada source) , since I don't think there's anything > particularly proprietary about them. They seem to be pretty old. Thanks! Indeed. It doesn't look that different from what I've tried, then. I had made the test use threads just in case it was easier to adapt it that way toward what AdaCore's test was doing, but I removed all of that now that it's clear it's not necessary, and the result is the same for me. I've attached the simplified testcase. You mentioned that you merged my branch into AdaCore's local tree. I wonder if this is some local change in the AdaCore gdb that might need some adjustment. Is it possible to run that test in AdaCore's testsuite with a GDB straight based on my branch on top of master, instead of AdaCore's local tree? Like, the equivalent of: $ make check RUNTESTFLAGS="GDB=/path/to/pedros/gdb" TESTS="gdb.base/continue-break-command.exp" > > Pedro> I ask because that is expected output if you continue with scheduler locking enabled, > Pedro> and the thread exits. E.g., the new gdb.threads/leader-exit-schedlock.exp testcase added > Pedro> by the series, has: > > Pedro> Maybe some logs like: > Pedro> set debug infrun > Pedro> set debugevents on > Pedro> set debugexceptions on > Pedro> set debugexec on > Pedro> would help see what's going on. > > I will try to do this soon. Thank you! If you end up debugging this, windows_nat_target::any_resumed_thread() is where we decide whether to report a TARGET_WAITKIND_NO_RESUMED event. Maybe that is returning true in a situation that it shouldn't, for some reason. Pedro Alves --------------uwnT5U08zbJo5iKsQy3KtHqH Content-Type: text/x-patch; charset=UTF-8; name="0001-New-gdb.base-continue-break-command.exp-testcase.patch" Content-Disposition: attachment; filename*0="0001-New-gdb.base-continue-break-command.exp-testcase.patch" Content-Transfer-Encoding: base64 RnJvbSA1ODFkZDUwMmY2ODk4YmEzODM3M2MyZmYzMDJiODQwYjNlZGZlZDc5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZWRybyBBbHZlcyA8cGVkcm9AcGFsdmVzLm5ldD4K RGF0ZTogV2VkLCAxMSBKdW4gMjAyNSAyMzozNTo1NyArMDEwMApTdWJqZWN0OiBbUEFUQ0hd IE5ldyBnZGIuYmFzZS9jb250aW51ZS1icmVhay1jb21tYW5kLmV4cCB0ZXN0Y2FzZQoKQ2hh bmdlLUlkOiBJZTU3NDkzYmI1MDMyZjI4NjE5ZGI0MThkOWQ4MDY4YWFlMmQ0MGIwOQotLS0K IC4uLi9nZGIuYmFzZS9jb250aW51ZS1icmVhay1jb21tYW5kLmMgICAgICAgICB8IDQyICsr KysrKysrKysrCiAuLi4vZ2RiLmJhc2UvY29udGludWUtYnJlYWstY29tbWFuZC5leHAgICAg ICAgfCA3NSArKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDExNyBpbnNl cnRpb25zKCspCiBjcmVhdGUgbW9kZSAxMDA2NDQgZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9j b250aW51ZS1icmVhay1jb21tYW5kLmMKIGNyZWF0ZSBtb2RlIDEwMDY0NCBnZGIvdGVzdHN1 aXRlL2dkYi5iYXNlL2NvbnRpbnVlLWJyZWFrLWNvbW1hbmQuZXhwCgpkaWZmIC0tZ2l0IGEv Z2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9jb250aW51ZS1icmVhay1jb21tYW5kLmMgYi9nZGIv dGVzdHN1aXRlL2dkYi5iYXNlL2NvbnRpbnVlLWJyZWFrLWNvbW1hbmQuYwpuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uNTg1NDc2YWE4MzgKLS0tIC9kZXYvbnVs bAorKysgYi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2NvbnRpbnVlLWJyZWFrLWNvbW1hbmQu YwpAQCAtMCwwICsxLDQyIEBACisvKiBUaGlzIHRlc3RjYXNlIGlzIHBhcnQgb2YgR0RCLCB0 aGUgR05VIGRlYnVnZ2VyLgorCisgICBDb3B5cmlnaHQgMjAyNSBGcmVlIFNvZnR3YXJlIEZv dW5kYXRpb24sIEluYy4KKworICAgVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlv dSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKKyAgIGl0IHVuZGVyIHRoZSB0 ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5 CisgICB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIgdmVyc2lvbiAzIG9m IHRoZSBMaWNlbnNlLCBvcgorICAgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lv bi4KKworICAgVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQg aXQgd2lsbCBiZSB1c2VmdWwsCisgICBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhv dXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorICAgTUVSQ0hBTlRBQklMSVRZIG9y IEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQorICAgR05VIEdl bmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKworICAgWW91IHNob3Vs ZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vu c2UKKyAgIGFsb25nIHdpdGggdGhpcyBwcm9ncmFtLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93 d3cuZ251Lm9yZy9saWNlbnNlcy8+LiAgKi8KKworc3RhdGljIHZvaWQKK2ZvbyAoKQorewor fQorCitzdGF0aWMgdm9pZAorYmFyICgpCit7Cit9CisKK2ludAorbWFpbiAodm9pZCkKK3sK KyAgLyogVGhlIHRlc3RjYXNlIHNldHMgYnJlYWtwb2ludHMgb24gdGhlc2UgdHdvLCB0aGF0 IHdoZW4gaGl0LCBhcmUKKyAgICAgcmVtb3ZlZCBieSB0aGVpciBjb3JyZXNwb25kaW5nIGJy ZWFrcG9pbnQgY29tbWFuZC4gICovCisgIGZvbyAoKTsKKyAgYmFyICgpOworCisgIC8qIENh bGwgdGhlbSBhZ2FpbiB0byBtYWtlIHN1cmUgdGhlIGJyZWFrcG9pbnRzIGFyZSByZWFsbHkK KyAgICAgZGVsZXRlZC4gICovCisgIGZvbyAoKTsKKyAgYmFyICgpOworCisgIHJldHVybiAw OworfQpkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9jb250aW51ZS1icmVh ay1jb21tYW5kLmV4cCBiL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvY29udGludWUtYnJlYWst Y29tbWFuZC5leHAKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLjZk NzdkMjgyZDc4Ci0tLSAvZGV2L251bGwKKysrIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9j b250aW51ZS1icmVhay1jb21tYW5kLmV4cApAQCAtMCwwICsxLDc1IEBACisjIENvcHlyaWdo dCAyMDI1IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgorCisjIFRoaXMgcHJvZ3Jh bSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9k aWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExp Y2Vuc2UgYXMgcHVibGlzaGVkIGJ5CisjIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247 IGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCisjIChhdCB5b3VyIG9wdGlv bikgYW55IGxhdGVyIHZlcnNpb24uCisjCisjIFRoaXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRl ZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAorIyBidXQgV0lUSE9VVCBB TlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorIyBN RVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBT ZWUgdGhlCisjIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMu CisjCisjIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBHZW5l cmFsIFB1YmxpYyBMaWNlbnNlCisjIGFsb25nIHdpdGggdGhpcyBwcm9ncmFtLiAgSWYgbm90 LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+LgorCisjIFhYWCwgc29tZSBt ZWFuaW5mdWwgZXhwbGFuYXRpb24gaGVyZS4KKworc3RhbmRhcmRfdGVzdGZpbGUgLmMKKwor aWYgeyBbYnVpbGRfZXhlY3V0YWJsZSAiZmFpbGVkIHRvIHByZXBhcmUiICR0ZXN0ZmlsZSAk c3JjZmlsZSB7ZGVidWd9XSBcCisJID09IC0xIH0geworICAgIHJldHVybgorfQorCitwcm9j IHRlc3Qge30geworICAgIGNsZWFuX3Jlc3RhcnQgJDo6YmluZmlsZQorCisgICAgaWYgIVty dW50b19tYWluXSB7CisJcmV0dXJuCisgICAgfQorCisgICAgIyBEaXNhYmxlICJbVGhyZWFk IDE0MTkyLjB4MzYxOCBleGl0ZWQgd2l0aCBjb2RlIDBdIiBtZXNzYWdlcy4KKyAgICBnZGJf dGVzdF9ub19vdXRwdXQgInNldCBwcmludCB0aHJlYWQtZXZlbnRzIG9mZiIKKworICAgIGdk Yl9icmVha3BvaW50ICJmb28iIG1lc3NhZ2UKKyAgICBnZGJfdGVzdF9tdWx0aXBsZSAiY29t bWFuZHMiICJjb21tYW5kIGZvciBmb28iIHsKKwktcmUgIkVuZCB3aXRoIiB7CisJICAgIGdk Yl90ZXN0IFwKKwkJW211bHRpX2xpbmVfaW5wdXQgXAorCQkgICAgIHtzaWxlbnR9IFwKKwkJ ICAgICB7cHJpbnRmICJCcmVha3BvaW50IGhpdCAjMS5cbiJ9IFwKKwkJICAgICB7Y2xlYXIg Zm9vfSBcCisJCSAgICAge2NvbnRpbnVlfSBcCisJCSAgICAge2VuZH1dIFwKKwkJIiIgXAor CQkkZ2RiX3Rlc3RfbmFtZQorCX0KKyAgICB9CisKKyAgICBnZGJfYnJlYWtwb2ludCAiYmFy IiBtZXNzYWdlCisgICAgZ2RiX3Rlc3RfbXVsdGlwbGUgImNvbW1hbmRzIiAiY29tbWFuZHMg Zm9yIGJhciIgeworCS1yZSAiRW5kIHdpdGgiIHsKKwkgICAgZ2RiX3Rlc3QgXAorCQlbbXVs dGlfbGluZV9pbnB1dCBcCisJCSAgICAge3NpbGVudH0gXAorCQkgICAgIHtwcmludGYgIkJy ZWFrcG9pbnQgaGl0ICMyLlxuIn0gXAorCQkgICAgIHtjbGVhciBiYXJ9IFwKKwkJICAgICB7 Y29udGludWV9IFwKKwkJICAgICB7ZW5kfV0gXAorCQkiIiBcCisJCSRnZGJfdGVzdF9uYW1l CisJfQorICAgIH0KKworICAgIGdkYl90ZXN0ICJpbmZvIGJyZWFrcG9pbnRzIiAiLioiCisK KyAgICBnZGJfdGVzdF9zZXF1ZW5jZSAiY29udGludWUiICIiIFwKKwlbbGlzdCBcCisJICAg ICAiQ29udGludWluZ1xcLiIgXAorCSAgICAgIl5cclxuQnJlYWtwb2ludCBoaXQgIzFcXC4i IFwKKwkgICAgICJeXHJcbkJyZWFrcG9pbnQgaGl0ICMyXFwuIiBcCisJICAgICAiXlxyXG4k OjppbmZlcmlvcl9leGl0ZWRfcmUgbm9ybWFsbHkiXQorfQorCit0ZXN0CgpiYXNlLWNvbW1p dDogZWI2YzkzMTBlZTRkNmNiZGU1MDlkMjUxZmFmYjU0YWU0NWY1YTViZgotLSAKMi40OS4w Cgo= --------------uwnT5U08zbJo5iKsQy3KtHqH--