From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22466 invoked by alias); 3 May 2019 22:45:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22453 invoked by uid 89); 3 May 2019 22:45:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=pm, UD:p.m, p.m X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 May 2019 22:45:28 +0000 Received: from [172.16.0.120] (192-222-157-41.qc.cable.ebox.net [192.222.157.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BAAE41E180; Fri, 3 May 2019 18:45:26 -0400 (EDT) Subject: Re: [RFC 1/8] Use std::map for MI commands in mi-cmds.c From: Simon Marchi To: Jan Vrany , gdb-patches@sourceware.org Cc: Didier Nadeau References: <20190418152337.6376-1-jan.vrany@fit.cvut.cz> <20190418152337.6376-2-jan.vrany@fit.cvut.cz> <4cddb376-4e03-4d24-1938-0bd561e03a23@simark.ca> Message-ID: Date: Fri, 03 May 2019 22:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <4cddb376-4e03-4d24-1938-0bd561e03a23@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-05/txt/msg00086.txt.bz2 On 2019-05-03 6:40 p.m., Simon Marchi wrote: > create_mi_cmd could be a constructor to mi_cmd instead. In fact, there could be > two constructors of mi_cmd for each version (the mi-based MI commands and the > cli-based MI commands), each taking the appropriate parameters. Woops, I just saw that this is done in patch 2, sorry about the noise :) Simon