From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26556 invoked by alias); 10 Feb 2020 16:46:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26541 invoked by uid 89); 10 Feb 2020 16:46:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.7 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,SPF_PASS autolearn=no version=3.3.1 spammy=H*r:172.16.0 X-HELO: mail.efficios.com Received: from mail.efficios.com (HELO mail.efficios.com) (167.114.26.124) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Feb 2020 16:46:32 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 5800E244949; Mon, 10 Feb 2020 11:46:31 -0500 (EST) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id AnLtgiaRwr2O; Mon, 10 Feb 2020 11:46:31 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 13E03244946; Mon, 10 Feb 2020 11:46:31 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 13E03244946 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1581353191; bh=4J7IU21s4CR4zWSmTIto9lnuAcCxV2sZj5yn13iml/s=; h=To:From:Message-ID:Date:MIME-Version; b=gbUWSKHoXtM9NE82GroDrKTpk2pu1T5zJzVw7E2vflxZ+3k+94vF/LCq1XCVnUavE klFHuVKdNZVH82t9pe8EOFcw2Tb5hEtCIkERiwDxQMPasttHjLOMUJA6dm6kO90im8 WoSlbnR+zGhGTa/8s5SKp5bQLdIOMOMnmO+OyklMC49zwBhsASwIXAFX+ZbDsISTit yL93yG6a+CEz8gXu/T1ahfOxzRPgWGQtHH6LW8t9X1DmS9FI8oEXPp+mNAPH74oUFu cfv1QeHelTto9ldR5UxuLREH1BMATCkpueTQkI77ltF2bT+MSgJ7eKyhxHJ7k/ZBp1 HtBR9llEijZBg== Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id puJJnherp7MI; Mon, 10 Feb 2020 11:46:31 -0500 (EST) Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) by mail.efficios.com (Postfix) with ESMTPSA id 8B3C2244B82; Mon, 10 Feb 2020 11:46:30 -0500 (EST) Subject: Re: [PATCH 3/3] Add -Wstrict-null-sentinel to gdbsupport/warning.m4 To: Christian Biesinger Cc: gdb-patches References: <20200210164024.32445-1-simon.marchi@efficios.com> <20200210164024.32445-3-simon.marchi@efficios.com> From: Simon Marchi Message-ID: Date: Mon, 10 Feb 2020 16:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00290.txt.bz2 On 2020-02-10 11:42 a.m., Christian Biesinger wrote: > Any thoughts on instead dong: > +-Wstrict-null-sentinel \ > +" > > so that future changes don't need to change the last line? Helps with blame too. Sure, I I'll do that. I like when we use a comma after the last enumerator in enums too, for the same reason. Simon