From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63707 invoked by alias); 13 Sep 2017 14:54:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63678 invoked by uid 89); 13 Sep 2017 14:54:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1394, H*M:63c4 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Sep 2017 14:54:06 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6217480F75 for ; Wed, 13 Sep 2017 14:54:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6217480F75 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id DDE076FA90; Wed, 13 Sep 2017 14:54:01 +0000 (UTC) Subject: Re: [PATCH 0/4] New "set cwd" command To: Sergio Durigan Junior , GDB Patches References: <20170912042325.14927-1-sergiodj@redhat.com> From: Pedro Alves Message-ID: Date: Wed, 13 Sep 2017 14:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170912042325.14927-1-sergiodj@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00358.txt.bz2 On 09/12/2017 05:23 AM, Sergio Durigan Junior wrote: > This patch series is a followup of the discussion that happened at: > > https://sourceware.org/ml/gdb-patches/2017-09/msg00160.html > > It implements a new GDB command, "set cwd", which is used to set the > current working directory of the inferior that will be started. This > is a GDB-only command for now; its gdbserver counterpart will come > later. I think I'd prefer that the gdbserver counterpart was included as part of the same series. I.e., I'd like to see the gdbserver side explored first before we change the native side and commit to the commands/interface. Also, I think that would help make sure that the manual documentation is adjusted in a way that naturally reads as applying to local and remote. For example, we currently say "Each time you start your program with @code{run}, it inherits its working directory from the current working directory of @value{GDBN}.", but you didn't change that particular sentence, which seems to leave it a bit incorrect. I think we should say instead say that when you start your program with run, the inferior starts with the directory specified by "set cwd", and then mention that if that is not set, then the inferior inherits gdb's current directory if native debugging, and gdbserver's if remote debugging. Right? Thanks, Pedro Alves