From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 504 invoked by alias); 21 Aug 2018 18:23:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 484 invoked by uid 89); 21 Aug 2018 18:23:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:574 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Aug 2018 18:23:47 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w7LINeod019564 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 21 Aug 2018 14:23:45 -0400 Received: by simark.ca (Postfix, from userid 112) id 6E6F51EABA; Tue, 21 Aug 2018 14:23:40 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id A83971E012; Tue, 21 Aug 2018 14:23:36 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 21 Aug 2018 18:23:00 -0000 From: Simon Marchi To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 6/8] Introduce find_pc_partial_entry_range and use it in infrun.c In-Reply-To: <20180821104957.22621602@pinnacle.lan> References: <20180820152512.671a7dc7@pinnacle.lan> <20180820154546.5a9f9c6f@pinnacle.lan> <20180821104957.22621602@pinnacle.lan> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00506.txt.bz2 On 2018-08-21 13:49, Kevin Buettner wrote: > With regard to "find_pc_partial_entry_range", it seems to me that > "find_pc_partial_function_entry_range" is overly long. Maybe > "find_pc_function_entry_range" is better? Either way is fine with me. In the end I'd like to rename everything in the form "find_X_from_Y", which in this case could be "find_function_entry_range_from_pc". If you like it we can use that, although it would make it inconsistent with what we have at the moment. Simon