Re: [PATCH] gdb: remove unused includes from dwarf2read.c

Simon Marchi
2019-10-14T15:18:47Z

On 2019-10-14 10:38, Eli Zaretskii wrote:
>> Date: Mon, 14 Oct 2019 10:21:50 -0400
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>
>> I pushed it after Tom de Vries reviewed it on Gerrit:
>>
>> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/24
>
> Does this mean that now we need to look for patches in two places?
> Can Gerrit be set up to forward the review comments to the list?
>
> Also, if some of us decides to do the review on Gerrit, does it mean
> all the others need to do that as well?

Hi Eli,

Yes, Gerrit can be set to send notifications to an arbitrary email, so
we can set it to send them to gdb-patches. We have talked about that
earlier, it's just not done yet. I'll look into it right now.

As long as we use Gerrit and mail patches in parallel, people are free
to send patches using the system they prefer. I think it's simpler if
reviewers use the system that was chosen by the patch author (reply on
Gerrit if the patch is on Gerrit, reply by email if the patch is by
email).

In theory, it is possible to reply to some of Gerrit's email
notifications:

https://gerrit-review.googlesource.com/Documentation/intro-user.html#reply-by-email

But our server isn't configured to receive emails for the moment, so
that won't work. Reading this page, I'm not sure if responding to a
"New change" notification would work, we'd have to try it.

Simon