From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14665 invoked by alias); 7 Nov 2018 15:27:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14632 invoked by uid 89); 7 Nov 2018 15:27:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Nov 2018 15:27:49 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id wA7FRhkb005857 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 7 Nov 2018 10:27:47 -0500 Received: by simark.ca (Postfix, from userid 112) id 1B78E1E514; Wed, 7 Nov 2018 10:27:43 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 2BFEF1E477; Wed, 7 Nov 2018 10:27:42 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 07 Nov 2018 15:27:00 -0000 From: Simon Marchi To: Hafiz Abid Qadeer Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: Small typo in iconv.m4 In-Reply-To: <404ed12c-79ec-7731-c013-47e7001e15a5@mentor.com> References: <404ed12c-79ec-7731-c013-47e7001e15a5@mentor.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00099.txt.bz2 On 2018-11-06 11:37, Hafiz Abid Qadeer wrote: > Hi All, > I was investigating a character set related problem with windows hosted > GDB and I tracked it down to a typo in iconv.m4. This typo caused > libiconv detection to fail and related support was not built into gdb. > > The problem is with the following line. > CPPFLAGS="$LIBS $INCICONV" > which should have been > CPPFLAGS="$CPPFLAGS $INCICONV" > > OK to commit the attached patch? > > 2018-11-06 Hafiz Abid Qadeer > > * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS. > Append $INCICONV to it. > * gcc/configure: Regenerate. > * libcpp/configure: Likewise. > * libstdc++-v3/configure: Likewise. > * intl/configure: Likewise. > > Thanks, Seems good from my point of view, but I can't approve. Simon