From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YMnjJMl8/WVjgxEAWB0awg (envelope-from ) for ; Fri, 22 Mar 2024 08:42:49 -0400 Received: by simark.ca (Postfix, from userid 112) id 935201E0C0; Fri, 22 Mar 2024 08:42:49 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7D50F1E030 for ; Fri, 22 Mar 2024 08:42:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1B41A385828B for ; Fri, 22 Mar 2024 12:42:47 +0000 (GMT) Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id B57043858D34 for ; Fri, 22 Mar 2024 12:42:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B57043858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B57043858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711111346; cv=none; b=emuuxAhy66drvONWxxlluA+V+lxyFsF7o0Va8H1B+VOxLP+FgMzyqzERvRFDCE+EfOgQR2AzcmBueS8yAGycv705kHkQVPS9VfLIk0qEnkQV3POFigENDQooPVpUCgyjNeTLcxNraam306PJeKydEaRYRPlC/i9/99w0MRhQGkE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711111346; c=relaxed/simple; bh=mruURY+wTytWBwgwPYnmKle1JGfYyTQ5R/tK+3X16pk=; h=Message-ID:Date:MIME-Version:Subject:From:To; b=CmgO1omEdP+i+pv8ZLZTrThFMlLvK7F+zGwUqYrstzuy11Z9rtHEkm0Gb/b+bsClXlE7u6O6r2TCHpcaFybLyNJ5tQ/omT9U+9ww7PTgFuQ5sf2ORwP0FHItUx0Gp4eF6MT8dy4d9DpBrepRuEUkIgteQWpKydY2j6XbUeE9+c4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [36.44.127.85]) by gateway (Coremail) with SMTP id _____8CxmeisfP1lC3ocAA--.47978S3; Fri, 22 Mar 2024 20:42:21 +0800 (CST) Received: from [192.168.0.105] (unknown [36.44.127.85]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxHs+ofP1ldhpiAA--.60509S3; Fri, 22 Mar 2024 20:42:20 +0800 (CST) Message-ID: Date: Fri, 22 Mar 2024 20:42:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] gdb: LoongArch: Clean up loongarch_iterate_over_regset_sections() Content-Language: en-US From: Tiezhu Yang To: gdb-patches@sourceware.org References: <20240322033502.28845-1-yangtiezhu@loongson.cn> In-Reply-To: <20240322033502.28845-1-yangtiezhu@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID: AQAAf8AxHs+ofP1ldhpiAA--.60509S3 X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj93XoWxurykGFWUXryUXw4DJF13Awc_yoW5Jw43pr Wj934UCr4xGrnrGa9rJ343Z3sxCwsagr42va43JryFkr1DW34jqa1Dtr9xGF1fC3W7GFWI 9wn0yanrZF4rAwcCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUv2b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07 AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02 F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jr0_Jr ylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7Cj xVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r 1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU1CP fJUUUUU== X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/22/24 11:35, Tiezhu Yang wrote: > Define a new variable gpsize as gprsize * LOONGARCH_LINUX_NUM_GREGSET > to replace the related code in the first cb(), and also make use of > tabs and spaces in indentation to force the proper alignment of code, > then remove the empty line at the end of the function. > > Signed-off-by: Tiezhu Yang > --- > gdb/loongarch-linux-tdep.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/gdb/loongarch-linux-tdep.c b/gdb/loongarch-linux-tdep.c > index db6371eb556..cc8121bb2b8 100644 > --- a/gdb/loongarch-linux-tdep.c > +++ b/gdb/loongarch-linux-tdep.c > @@ -492,11 +492,12 @@ loongarch_iterate_over_regset_sections (struct gdbarch *gdbarch, > const struct regcache *regcache) > { > int gprsize = register_size (gdbarch, 0); > + int gpsize = gprsize * LOONGARCH_LINUX_NUM_GREGSET; > int fprsize = register_size (gdbarch, LOONGARCH_FIRST_FP_REGNUM); > int fccsize = register_size (gdbarch, LOONGARCH_FIRST_FCC_REGNUM); > int fcsrsize = register_size (gdbarch, LOONGARCH_FCSR_REGNUM); > int fpsize = fprsize * LOONGARCH_LINUX_NUM_FPREGSET + > - fccsize * LOONGARCH_LINUX_NUM_FCC + fcsrsize; > + fccsize * LOONGARCH_LINUX_NUM_FCC + fcsrsize; > int lsxrsize = register_size (gdbarch, LOONGARCH_FIRST_LSX_REGNUM); > int lsxsize = lsxrsize * LOONGARCH_LINUX_NUM_LSXREGSET; > int lasxrsize = register_size (gdbarch, LOONGARCH_FIRST_LASX_REGNUM); > @@ -506,16 +507,16 @@ loongarch_iterate_over_regset_sections (struct gdbarch *gdbarch, > int ftopsize = register_size (gdbarch, LOONGARCH_FTOP_REGNUM); > int lbtsize = scrsize * LOONGARCH_LINUX_NUM_SCR + eflagssize + ftopsize; > > - cb (".reg", LOONGARCH_LINUX_NUM_GREGSET * gprsize, > - LOONGARCH_LINUX_NUM_GREGSET * gprsize, &loongarch_gregset, nullptr, cb_data); > - cb (".reg2", fpsize, fpsize, &loongarch_fpregset, nullptr, cb_data); > + cb (".reg", gpsize, gpsize, > + &loongarch_gregset, nullptr, cb_data); > + cb (".reg2", fpsize, fpsize, > + &loongarch_fpregset, nullptr, cb_data); > cb (".reg-loongarch-lsx", lsxsize, lsxsize, > &loongarch_lsxregset, nullptr, cb_data); > cb (".reg-loongarch-lasx", lasxsize, lasxsize, > &loongarch_lasxregset, nullptr, cb_data); > cb (".reg-loongarch-lbt", lbtsize, lbtsize, > &loongarch_lbtregset, nullptr, cb_data); > - > } > > /* The following value is derived from __NR_rt_sigreturn in Pushed. Thanks, Tiezhu