From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +WkcAOPSgWBVZQAAWB0awg (envelope-from ) for ; Thu, 22 Apr 2021 15:47:47 -0400 Received: by simark.ca (Postfix, from userid 112) id E14E01F104; Thu, 22 Apr 2021 15:47:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3379B1E783 for ; Thu, 22 Apr 2021 15:47:46 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 983323A1602F; Thu, 22 Apr 2021 19:47:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 983323A1602F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619120865; bh=dP47WKp4oVMDXV5WHt7myfX5E9kCPjM9pbqUzDEuCP0=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wwpODC4CUZ2/EGV3mBPGHKrjmA4eFBqbf4lW9HVrdFkWwn5SaSKi0nj2qwWjFxpoi 57tUjJNPW9YCiE1xKKcFm+YlVySC4Rg9HoN1yTirKjDFgynAEqvAk6Ph+OghI2jzes dAmhUYq3doWQFyL29vABIm/HZLJo2j38nbM34+CI= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 18557389683A for ; Thu, 22 Apr 2021 19:47:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 18557389683A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13MJlXnK005982 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Apr 2021 15:47:38 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13MJlXnK005982 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C7EB21E783; Thu, 22 Apr 2021 15:47:33 -0400 (EDT) Subject: Re: [PATCH master + gdb-10-branch] gdb: fix getting range of flexible array member in Python To: Luis Machado , Andrew Burgess References: <20210422155950.3520038-1-simon.marchi@polymtl.ca> <20210422164830.GQ2610@embecosm.com> <20210422175027.GR2610@embecosm.com> <994f03c4-d497-efa9-e01f-dabdf7082d3e@polymtl.ca> <3ac122fc-234a-9131-fe23-95962bf9d8ef@linaro.org> Message-ID: Date: Thu, 22 Apr 2021 15:47:33 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <3ac122fc-234a-9131-fe23-95962bf9d8ef@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 22 Apr 2021 19:47:33 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-04-22 3:40 p.m., Luis Machado wrote: > Hi Simon, > > On 4/22/21 4:07 PM, Simon Marchi via Gdb-patches wrote: >> On 2021-04-22 1:50 p.m., Andrew Burgess wrote: >>>> diff --git a/gdb/testsuite/gdb.python/flexible-array-member.c b/gdb/testsuite/gdb.python/flexible-array-member.c >>>> new file mode 100644 >>>> index 000000000000..79815e2d38e0 >>>> --- /dev/null >>>> +++ b/gdb/testsuite/gdb.python/flexible-array-member.c >>>> @@ -0,0 +1,70 @@ >>>> +/* This testcase is part of GDB, the GNU debugger. >>>> + >>>> + Copyright 2020-2021 Free Software Foundation, Inc. >>> >>> In this file and the .exp the date range is 2020-2021, is this >>> correct? >> >> Since I copied it from gdb.base/flexible-array-member.c, it should >> retain the original copyright date. >> >>> Otherwise, looks good. >> >> Thanks, pushed to both branches! >> >> Simon >> > > I notice this test being executed without python support. I think we need this guard: > > # Skip all tests if Python scripting is not enabled. > if { [skip_python_tests] } { continue } You're right, thanks for noticing. I pushed the patch below in the two branches: >From a87caa6d523e573ab71694233a7501c6b5b5b9f7 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Thu, 22 Apr 2021 15:45:34 -0400 Subject: [PATCH] gdb/testsuite: add Python support check in gdb.python/flexible-array-member.exp We don't want to execute this test if Python support is not compiled in GDB, add the necessary check. gdb/testsuite/ChangeLog: * gdb.python/flexible-array-member.exp: Add check for Python support. Change-Id: I853b937d2a193a0bb216566bef1a35354264b1c5 --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.python/flexible-array-member.exp | 3 +++ 2 files changed, 8 insertions(+) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 9730658299bf..266645bd6ad6 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2021-04-22 Simon Marchi + + * gdb.python/flexible-array-member.exp: Add check for Python + support. + 2021-04-22 Simon Marchi PR gdb/27757 diff --git a/gdb/testsuite/gdb.python/flexible-array-member.exp b/gdb/testsuite/gdb.python/flexible-array-member.exp index 3739c9a9e5c0..349670cb7e72 100644 --- a/gdb/testsuite/gdb.python/flexible-array-member.exp +++ b/gdb/testsuite/gdb.python/flexible-array-member.exp @@ -22,6 +22,9 @@ if { [prepare_for_testing "failed to prepare" \ return } +# Skip all tests if Python scripting is not enabled. +if { [skip_python_tests] } { continue } + if { ![runto break_here] } { untested "could not run to break_here" return -- 2.30.1