From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5lxfG+WE6WV6ADwAWB0awg (envelope-from ) for ; Thu, 07 Mar 2024 04:12:05 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DqYABC7l; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5A5901E0D2; Thu, 7 Mar 2024 04:12:05 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3EC7B1E092 for ; Thu, 7 Mar 2024 04:12:03 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CAD9F3857817 for ; Thu, 7 Mar 2024 09:12:02 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 415713858D39 for ; Thu, 7 Mar 2024 09:11:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 415713858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 415713858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709802701; cv=none; b=bMCzn0sSsxui0zsCxpVcvrNPy9EB3LSqjRsa05GQ+lXEKNwVyiQJICmhslwb+tdkRchZ6EQxCNFO0SK/SI6DYI70PwYVeNyv1Cf26prlzTnJrZHcBh5KWWy6u/TSV6lfSz23RRMjalXMmFCxZiG4mPHBoewrpgBMFSGP3/cZKaw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709802701; c=relaxed/simple; bh=3K6Kf4DpEgura8F3Bf3KvCwWG0CX/d/yI1wCNFCbOME=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=FDdYwrS+pvgo62Sg9KvAe69H7WChQkQrkVgQcBndRLtDn/vD37zwKzIVb+J3ltfumYol7kF+jkW70EZolCMQEzcVbKZCP34DzPdwKoZRSvmODCAEFFu/pXZ29tROqzwsLCx+2TfoclSg4yvsFL7+gZ0K5un9xZf6W2NgCYlb/W8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709802698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kP9vl0g5+auNQkh9OW/Yuhv34zwYicCMKO7ZKMs2L8k=; b=DqYABC7lnhDI4NaK9zo8RrXG3nrXEzCZ73nmDL1cDnrcEzaHiV6ljlsWxwp7hYL4c4fQqX eXoPTppGz4PXL8U6mq3XQM/ONxMNIDGimfNtG7chKcYI6ch9F6u0zYTuJsyUaAXZ6Hxw+B wj5mYfzMzX6tvtDPUKSLEVz7KVIrqLw= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-ENC0FytiNOWNBAtbGVfxNg-1; Thu, 07 Mar 2024 04:11:36 -0500 X-MC-Unique: ENC0FytiNOWNBAtbGVfxNg-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-5131796a4b7so592557e87.1 for ; Thu, 07 Mar 2024 01:11:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709802695; x=1710407495; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kP9vl0g5+auNQkh9OW/Yuhv34zwYicCMKO7ZKMs2L8k=; b=pBR2ABK0kt+XF7muNHfFVETspzmdY0o3PdfQjQEWTdzR1R5bZ/uYMUvR4tX8hZN5d4 fT/vbKAF2HSqpnXDc7L0ilZB8Nd+P5i5AAxW6+ozw+p4FJP3xHzEYqcCU0hMKLmegiX5 xzh6CsE+KlL1yUZYo+uQRDfRxCr1ESSr7siIbM3YLjb7pXCrKsC+F8Uva2xiDIGbxS/5 ANoAJ9Jhh5MJjxueyY9HAskyGUWX4u0xYBdXiU4C0jkq5HiCS+/i3I+AvtzWnZHLLs7W 3Uyd2otFqXxgBywOeW2MfYNFKWCua1zLQreeQmRw10bM4fr1t7wPhdAxBIoGMuomw/u8 8zgA== X-Forwarded-Encrypted: i=1; AJvYcCUObeql1htccA26w0p6xXCfjLvJ+ffeHJ8wYOfOdVmnbKXWPdN3UV7JxNXAO0EWh1tA57Na8N1byNNok6L3Sn20Oxs9lSIvx7uTsA== X-Gm-Message-State: AOJu0Yy4D7ZfLnG2MeMab1KT1scq9aDAg7m4l2524XhisoQLXE/TyXil j/3pSn8KCrP2vjhswjLJs3DsahJl80rNI/Ib1PYax47BLK1K1pIfPfJVXUFfVpk9Gv7E3X6yTEd uCYD+nuVwH93KlqRZKjO7yusZKCcHoBWxWUsfFjUJ18rHJm1s3m9h5s/IyiJKjH0KYCU= X-Received: by 2002:a05:6512:3d16:b0:513:5991:1481 with SMTP id d22-20020a0565123d1600b0051359911481mr1413072lfv.29.1709802695202; Thu, 07 Mar 2024 01:11:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IG2Diy+rrl/T8gVcRPjHbxmuQXwBkFOm+ci7QULRuQ9PJca0PsKbBVkuTCfIWpaGH7NJ5z68w== X-Received: by 2002:a05:6512:3d16:b0:513:5991:1481 with SMTP id d22-20020a0565123d1600b0051359911481mr1413044lfv.29.1709802694760; Thu, 07 Mar 2024 01:11:34 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id d14-20020adf9c8e000000b0033e42ab5114sm9106799wre.2.2024.03.07.01.11.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Mar 2024 01:11:34 -0800 (PST) Message-ID: Date: Thu, 7 Mar 2024 10:11:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] gdb/testsuite: reduce gdb.threads/threadcrash.exp reliance on libc symbols To: Tom de Vries , gdb-patches@sourceware.org References: <20240214091712.223928-2-blarsen@redhat.com> <20240214091712.223928-4-blarsen@redhat.com> From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 06/03/2024 18:16, Tom de Vries wrote: > On 2/14/24 10:17, Guinevere Larsen wrote: >> The test gdb.threads/threadcrash.exp demanded GDB to fully unwind and >> print the names of all functions. However, some of the functions are >> from the libc library, and so the test implicitly demanded libc symbols >> to be available, and would fail otherwise, as was raised in PR >> gdb/31293. >> >> This commit changes it so we only explicitly check for functions that >> are provided by threadcrash.c to fix that > > Hi Gwen, > > Nit: Missing dot at end of line. > > With that fixed, LGTM. > > Approved-By: Tom de Vries Thanks for the review! Would this apply to both patches or just this second one? -- Cheers, Guinevere Larsen She/Her/Hers > > Thanks, > - Tom > >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31293 >> --- >>   gdb/testsuite/gdb.threads/threadcrash.exp | 17 +++++++---------- >>   1 file changed, 7 insertions(+), 10 deletions(-) >> >> diff --git a/gdb/testsuite/gdb.threads/threadcrash.exp >> b/gdb/testsuite/gdb.threads/threadcrash.exp >> index bf4534179e2..2bbedcce58e 100644 >> --- a/gdb/testsuite/gdb.threads/threadcrash.exp >> +++ b/gdb/testsuite/gdb.threads/threadcrash.exp >> @@ -40,26 +40,23 @@ proc thread_apply_all {} { >>           exp_continue >>           } >>           -re "\[^\n\]*syscall_task >> .location=SIGNAL_ALT_STACK\[^\n\]*" { >> -        lappend test_list [multi_line ".*sleep.*" \ >> -                          ".*do_syscall_task >> .location=SIGNAL_ALT_STACK.*" \ >> +        lappend test_list [multi_line ".*do_syscall_task >> .location=SIGNAL_ALT_STACK.*" \ >>                             ".*signal_handler.*" \ >>                             ".*signal handler called.*" \ >> -                          ".*pthread_kill.*" \ >> +                          ".*" \ >>                             ".*thread_function.*"] >>           exp_continue >>           } >>           -re "\[^\n\]*syscall_task .location=SIGNAL_HANDLER\[^\n\]*" { >> -        lappend test_list [multi_line ".*sleep.*" \ >> -                          ".*do_syscall_task >> .location=SIGNAL_HANDLER.*" \ >> +        lappend test_list [multi_line ".*do_syscall_task >> .location=SIGNAL_HANDLER.*" \ >>                             ".*signal_handler.*" \ >>                             ".*signal handler called.*" \ >> -                          ".*pthread_kill.*" \ >> +                          ".*" \ >>                             ".*thread_function.*"] >>           exp_continue >>           } >>           -re "\[^\n\]*syscall_task .location=NORMAL\[^\n\]*" { >> -        lappend test_list [multi_line ".*sleep.*" \ >> -                          ".*do_syscall_task .location=NORMAL.*" \ >> +        lappend test_list [multi_line ".*do_syscall_task >> .location=NORMAL.*" \ >>                             ".*thread_function.*"] >>           exp_continue >>           } >> @@ -67,7 +64,7 @@ proc thread_apply_all {} { >>           lappend test_list [multi_line ".*do_spin_task >> .location=SIGNAL_ALT_STACK.*" \ >>                             ".*signal_handler.*" \ >>                             ".*signal handler called.*" \ >> -                          ".*pthread_kill.*" \ >> +                          ".*" \ >>                             ".*thread_function.*"] >>           exp_continue >>           } >> @@ -75,7 +72,7 @@ proc thread_apply_all {} { >>           lappend test_list [multi_line ".*do_spin_task >> .location=SIGNAL_HANDLER.*" \ >>                             ".*signal_handler.*" \ >>                             ".*signal handler called.*" \ >> -                          ".*pthread_kill.*" \ >> +                          ".*" \ >>                             ".*thread_function.*"] >>           exp_continue >>           } >