From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IedZNeMfZWMfCBQAWB0awg (envelope-from ) for ; Fri, 04 Nov 2022 10:21:23 -0400 Received: by simark.ca (Postfix, from userid 112) id CBB201E124; Fri, 4 Nov 2022 10:21:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A,RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 326A61E0D3 for ; Fri, 4 Nov 2022 10:21:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A35DD3858294 for ; Fri, 4 Nov 2022 14:21:19 +0000 (GMT) Received: from sa-prd-fep-047.btinternet.com (mailomta30-sa.btinternet.com [213.120.69.36]) by sourceware.org (Postfix) with ESMTPS id 65F2D3858C54 for ; Fri, 4 Nov 2022 14:21:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 65F2D3858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from sa-prd-rgout-001.btmx-prd.synchronoss.net ([10.2.38.4]) by sa-prd-fep-047.btinternet.com with ESMTP id <20221104142105.IXHN8034.sa-prd-fep-047.btinternet.com@sa-prd-rgout-001.btmx-prd.synchronoss.net>; Fri, 4 Nov 2022 14:21:05 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 62E573CC0EFD79B4 X-Originating-IP: [81.153.98.206] X-OWM-Source-IP: 81.153.98.206 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvgedrvddugdehjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurheptgfkffggfgfuvfhfhfgjsehmtderredtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeehhfeigeeukedtgfefkeelgedvgeffvdejheevgfffgfduveejffelvedtffekfeenucfkphepkedurdduheefrdelkedrvddtieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtiegnpdhinhgvthepkedurdduheefrdelkedrvddtiedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepghgusgdqphgrthgthhgvshesshhouhhrtggvfigrrhgvrdhorhhgpdhrtghpthhtohepthhrohhmvgihsegruggrtghorhgvrdgtohhm X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.153.98.206) by sa-prd-rgout-001.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 62E573CC0EFD79B4; Fri, 4 Nov 2022 14:21:05 +0000 Content-Type: multipart/mixed; boundary="------------N5zqEb0AnU1ywA0DVrUt0uet" Message-ID: Date: Fri, 4 Nov 2022 14:21:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] Use strwinerror in gdb/windows-nat.c Content-Language: en-GB To: Tom Tromey , gdb-patches@sourceware.org References: <20220728170555.85143-1-tromey@adacore.com> <877d38e1f7.fsf@tromey.com> From: Jon Turney In-Reply-To: <877d38e1f7.fsf@tromey.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" This is a multi-part message in MIME format. --------------N5zqEb0AnU1ywA0DVrUt0uet Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16/08/2022 14:57, Tom Tromey via Gdb-patches wrote: >>>>>> "Tom" == Tom Tromey via Gdb-patches writes: > > Tom> When working on windows-nat.c, it's useful to see an error message in > Tom> addition to the error number given by GetLastError. This patch moves > Tom> strwinerror from gdbserver to gdbsupport, and then updates > Tom> windows-nat.c to use it. A couple of minor changes to strwinerror > Tom> (constify the return type and use the ARRAY_SIZE macro) are also > Tom> included. > > I'm checking this in now. As is traditional by now, this breaks the Cygwin build. I'd suggest the attached to fix this, but I don't think this qualifies as obvious, since it's not obvious what USE_WIN32API is supposed to mean, so a review would be useful. --------------N5zqEb0AnU1ywA0DVrUt0uet Content-Type: text/plain; charset=UTF-8; name="0001-Fix-Cygwin-build-after-02d04eac.patch" Content-Disposition: attachment; filename="0001-Fix-Cygwin-build-after-02d04eac.patch" Content-Transfer-Encoding: base64 RnJvbSA0ZTZiNzJhOThmMWYwM2M2NjgwMWFmNGYzNjg3MTg3ODRmODA5YmI0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gVHVybmV5IDxqb24udHVybmV5QGRyb25lY29k ZS5vcmcudWs+CkRhdGU6IFdlZCwgMiBOb3YgMjAyMiAxMzoxNjoxNiArMDAwMApTdWJqZWN0 OiBbUEFUQ0hdIEZpeCBDeWd3aW4gYnVpbGQgYWZ0ZXIgMDJkMDRlYWMKCkNvbW1pdCAwMmQw NGVhYyAiVXNlIHN0cndpbmVycm9yIGluIGdkYi93aW5kb3dzLW5hdC5jIiBhbHNvIG1vdmVz CnN0cndpbmVycm9yKCkgdW5kZXIgdGhlIFVTRV9XSU4zMkFQSSBjb25kaXRpb25hbCwgd2hp Y2ggaXMgbm90IGRlZmluZWQKZm9yIEN5Z3dpbiAoYW5kIGxvb2tzIGxpa2UgaXQgc2hvdWxk bid0IGJlLCBhcyBhcHBlYXJzIHRvIGltcGx5Cm5vbi1QT1NJWCBhbmQgTWlOR1cgYW5kIFdp blNvY2suLi4pCgpBbHNvIGVuYWJsZSB0aGUgZGVjbGFyYXRpb24gYW5kIGRlZmluaXRpb24g b2Ygc3Ryd2luZXJyb3IoKSB3aGVuCl9fQ1lHV0lOX18gaXMgZGVmaW5lZC4KLS0tCiBnZGJz dXBwb3J0L2Vycm9ycy5jYyB8IDQgKystLQogZ2Ric3VwcG9ydC9lcnJvcnMuaCAgfCAyICst CiAyIGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9nZGJzdXBwb3J0L2Vycm9ycy5jYyBiL2dkYnN1cHBvcnQvZXJyb3JzLmNj CmluZGV4IDc0NjRkZjNkMDY3Li45M2ZjNzBhZDI5NiAxMDA2NDQKLS0tIGEvZ2Ric3VwcG9y dC9lcnJvcnMuY2MKKysrIGIvZ2Ric3VwcG9ydC9lcnJvcnMuY2MKQEAgLTE5LDcgKzE5LDcg QEAKIAogI2luY2x1ZGUgImNvbW1vbi1kZWZzLmgiCiAjaW5jbHVkZSAiZXJyb3JzLmgiCi0j aWZkZWYgVVNFX1dJTjMyQVBJCisjaWYgZGVmaW5lZCAoVVNFX1dJTjMyQVBJKSB8fCBkZWZp bmVkKF9fQ1lHV0lOX18pCiAjaW5jbHVkZSA8d2luZG93cy5oPgogI2VuZGlmIC8qIFVTRV9X SU4zMkFQSSAqLwogCkBAIC03MSw3ICs3MSw3IEBAIGludGVybmFsX3dhcm5pbmdfbG9jIChj b25zdCBjaGFyICpmaWxlLCBpbnQgbGluZSwgY29uc3QgY2hhciAqZm10LCAuLi4pCiAgIHZh X2VuZCAoYXApOwogfQogCi0jaWZkZWYgVVNFX1dJTjMyQVBJCisjaWYgZGVmaW5lZCAoVVNF X1dJTjMyQVBJKSB8fCBkZWZpbmVkKF9fQ1lHV0lOX18pCiAKIC8qIFNlZSBlcnJvcnMuaC4g ICovCiAKZGlmZiAtLWdpdCBhL2dkYnN1cHBvcnQvZXJyb3JzLmggYi9nZGJzdXBwb3J0L2Vy cm9ycy5oCmluZGV4IDVhOTI1Nzg5ODkzLi5kNjdkNjkyZTRjYiAxMDA2NDQKLS0tIGEvZ2Ri c3VwcG9ydC9lcnJvcnMuaAorKysgYi9nZGJzdXBwb3J0L2Vycm9ycy5oCkBAIC05OSw3ICs5 OSw3IEBAIGV4dGVybiB2b2lkIG1hbGxvY19mYWlsdXJlIChsb25nIHNpemUpIEFUVFJJQlVU RV9OT1JFVFVSTjsKIAogZXh0ZXJuIHZvaWQgZmx1c2hfc3RyZWFtcyAoKTsKIAotI2lmZGVm IFVTRV9XSU4zMkFQSQorI2lmIGRlZmluZWQoVVNFX1dJTjMyQVBJKSB8fCBkZWZpbmVkKF9f Q1lHV0lOX18pCiAKIC8qIE1hcCB0aGUgV2luZG93cyBlcnJvciBudW1iZXIgaW4gRVJST1Ig dG8gYSBsb2NhbGUtZGVwZW5kZW50IGVycm9yCiAgICBtZXNzYWdlIHN0cmluZyBhbmQgcmV0 dXJuIGEgcG9pbnRlciB0byBpdC4gIFR5cGljYWxseSwgdGhlIHZhbHVlcwotLSAKMi4zOC4x Cgo= --------------N5zqEb0AnU1ywA0DVrUt0uet--