On 16/08/2022 14:57, Tom Tromey via Gdb-patches wrote:
>>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tom> When working on windows-nat.c, it's useful to see an error message in
> Tom> addition to the error number given by GetLastError.  This patch moves
> Tom> strwinerror from gdbserver to gdbsupport, and then updates
> Tom> windows-nat.c to use it.  A couple of minor changes to strwinerror
> Tom> (constify the return type and use the ARRAY_SIZE macro) are also
> Tom> included.
> 
> I'm checking this in now.

As is traditional by now, this breaks the Cygwin build.

I'd suggest the attached to fix this, but I don't think this qualifies 
as obvious, since it's not obvious what USE_WIN32API is supposed to 
mean, so a review would be useful.