From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-137311-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 58742 invoked by alias); 24 Feb 2017 17:25:02 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 58720 invoked by uid 89); 24 Feb 2017 17:25:02 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:b501b4a, H*f:sk:b501b4a, H*MI:sk:b501b4a
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Feb 2017 17:25:01 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 81E45C054C4D;	Fri, 24 Feb 2017 17:25:01 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1OHOxWH023990;	Fri, 24 Feb 2017 12:24:59 -0500
Subject: Re: [PATCH, v17] Add support for setting disassembler-options in GDB for POWER, ARM and S390
To: Peter Bergner <bergner@vnet.ibm.com>
References: <a752c132-4933-866a-3cc9-a463ebf86427@vnet.ibm.com> <3b6b8153-cfff-8fb3-2cc0-2612f3d2d710@redhat.com> <98f0a8a0-ed6d-10b6-08be-2dd86cc7af44@vnet.ibm.com> <46d6c25a-3d33-8e2a-043a-b46ae004d8b3@redhat.com> <b501b4af-dcfd-666d-3572-e4392a24def3@vnet.ibm.com>
Cc: gdb-patches@sourceware.org, Yao Qi <qiyaoltc@gmail.com>,        Alan Modra <amodra@gmail.com>, Ulrich Weigand <uweigand@de.ibm.com>,        binutils <binutils@sourceware.org>
From: Pedro Alves <palves@redhat.com>
Message-ID: <b93f3c4a-25fd-7d7a-623a-1d536acf7ed9@redhat.com>
Date: Fri, 24 Feb 2017 17:25:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <b501b4af-dcfd-666d-3572-e4392a24def3@vnet.ibm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-02/txt/msg00688.txt.bz2

On 02/24/2017 05:13 PM, Peter Bergner wrote:

>   if (valid_options->description != NULL)
>     {
>       ...
>     }
>   else
>     {
>       size_t i;
>       fprintf_filtered (file, "  ");
>       for (i = 0; valid_options->name[i] != NULL; i++)
>         {
>           fprintf_filtered (file, "%s", valid_options->name[i]);
>           if (valid_options->name[i+1] != NULL)
>             fprintf_filtered (file, ", ");
>           wrap_here ("  ");
>         }
>       fprintf_filtered (file, "\n");
>     }
> 

Yup, that looks fine.  (with spaces around the '+' operator).

Thanks,
Pedro Alves