From: Simon Marchi <simon.marchi@polymtl.ca>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: simon.marchi@ericsson.com, palves@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/7] Pass ptid to target_ops register methods
Date: Fri, 10 Mar 2017 17:51:00 -0000 [thread overview]
Message-ID: <b92e5f50904fc9babb71cb14addb62bb@polymtl.ca> (raw)
In-Reply-To: <20170310171230.A9A22D806B1@oc3748833570.ibm.com>
On 2017-03-10 12:12, Ulrich Weigand wrote:
> Basically, we should move the above from the call site into all
> implementations of the routine, and then push it down as far as
> possible until it hopefully disappears in most cases.
That makes senses. The good news is that this can be done
incrementally, unlike the present patch series, which required changing
the signature of methods used all over the place. At least one
implentation of target_fetch/store_registers (bsd-uthread) needs to read
or write memory, and therefore will need to save/restore inferior_ptid.
But the big majority of them won't need to do it.
> Yes, the target routines must only be called on a regcache that is
> associated with a ptid.
>
> You'll probably need to add a get_regcache_ptid() routine or so;
> that routine should assert that the regcache has a ptid.
That sounds right. Thanks for the tips!
Simon
prev parent reply other threads:[~2017-03-10 17:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 16:42 Simon Marchi
2017-03-08 16:42 ` [PATCH 2/7] Add overload of s390_inferior_tid with a parameter Simon Marchi
2017-03-08 16:42 ` [PATCH 7/7] Pass ptid to to_prepare_to_store Simon Marchi
2017-03-08 16:42 ` [PATCH 5/7] Pass ptid to target_fetch_registers Simon Marchi
2017-03-08 21:08 ` Simon Marchi
2017-03-08 16:42 ` [PATCH 3/7] Define and use typedefs for bsd_uthread_ops fields Simon Marchi
2017-03-08 16:42 ` [PATCH 1/7] windows: Don't use current_thread for register fetch/store Simon Marchi
2017-03-08 16:42 ` [PATCH 4/7] Pass down ptid in bsd_uthread_ops layer Simon Marchi
2017-03-08 16:42 ` [PATCH 6/7] Pass ptid to target_store_registers Simon Marchi
2017-03-08 17:03 ` [PATCH 0/7] Pass ptid to target_ops register methods Simon Marchi
2017-03-08 23:31 ` Pedro Alves
2017-03-10 16:06 ` Simon Marchi
2017-03-10 17:12 ` Ulrich Weigand
2017-03-10 17:51 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b92e5f50904fc9babb71cb14addb62bb@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox