From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15200 invoked by alias); 15 Oct 2019 01:16:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15186 invoked by uid 89); 15 Oct 2019 01:16:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Oct 2019 01:16:11 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x9F1FxP3015794 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Oct 2019 21:16:04 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x9F1FxP3015794 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1571102166; bh=3eR/tfVoQspq5TkHNKns76zAYgzvxR3Cbvv/EXimG1g=; h=Subject:From:To:Cc:References:Date:In-Reply-To:From; b=VzFqXzcTrgoaU50eEr/wEqSio0TUeX/LQxD7a+/gJQvWQNapNVgPHQWkmtcRcxwH+ SbAaAl7fobMV4yuGYddKdvUM/avcZgPU8EAG23rS98xMHNhK26Da6TaB+SuK8c6bDz XQWFklZktatln6TIqwy+MI21leTRKlQ3pmMWfdLQ= Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2584D1E4C2; Mon, 14 Oct 2019 21:15:59 -0400 (EDT) Subject: Re: Gerrit request (Was: Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...) From: Simon Marchi To: Tom Tromey , "Tom de Vries (Code Review)" Cc: gdb-patches@sourceware.org, tdevries@suse.de, sergiodj@sergiodj.net, andrew.burgess@embecosm.com References: <20191014160117.2C9AA29ECF@gnutoolchain-gerrit.osci.io> <875zkrtd56.fsf_-_@tromey.com> Message-ID: Date: Tue, 15 Oct 2019 01:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00392.txt.bz2 On 2019-10-14 8:44 p.m., Simon Marchi wrote: > On 2019-10-14 2:06 p.m., Tom Tromey wrote: >> Hi. I've been looking at the gerrit review email. >> I'd like to suggest a way it could be improved. >> >> Consider this review: >> >> Tom> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp >> Tom> File gdb/testsuite/gdb.mi/list-thread-groups-available.exp: >> >> Tom> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp@74 >> Tom> PS5, Line 74: pass $test >> Tom> You could do pass $gdb_test_name and get rid of the test variable. >> >> This would be a lot better if the email included more of the patch >> context. As is, it's not very readable on the list. While I do want to >> use gerrit, at the same time I think it would be nice to be able to >> following the mailing list and get a reasonably complete idea of what's >> going on. >> >> Tom > > I'll take a look if it's possible to modify the templates to do so. It doesn't seem to be possible out of the box. The template can only work with the data passed by Gerrit. For a line comment, we only get the single line it refers to: https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/server/mail/send/CommentSender.java#328 Simon