From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16278 invoked by alias); 18 Apr 2018 14:20:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16258 invoked by uid 89); 18 Apr 2018 14:20:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Apr 2018 14:20:24 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A9E5E4070208; Wed, 18 Apr 2018 14:20:22 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1D1521C723; Wed, 18 Apr 2018 14:20:19 +0000 (UTC) Subject: Re: [PATCH 31/40] target_ops/C++: Base FreeBSD target To: John Baldwin References: <20180414190953.24481-1-palves@redhat.com> <2651054.rGX2nUqyEc@ralph.baldwin.cx> <4c3b320e-ecbe-4e97-9ee4-91cacca60b8d@redhat.com> <2336080.G2aX46TNlR@ralph.baldwin.cx> <0b900391-f06d-278c-cbed-b89b207bd12e@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 18 Apr 2018 14:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <0b900391-f06d-278c-cbed-b89b207bd12e@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-04/txt/msg00370.txt.bz2 On 04/18/2018 12:21 PM, Pedro Alves wrote: > On 04/18/2018 01:37 AM, John Baldwin wrote: >> I've pushed a target_ops-cxx branch to github.com/bsdjhb/gdb.git that has >> some small fixups (compile fixes). > > Thank you! I've now merged/squashed those fixes to the patches in the branch, and added your name to the WIP ChangeLog entry. I diff my branch against yours to double-checked whether I was missing anything, then rebased on top of current master. I force-pushed the result to users/palves/target_ops-cxx on sourceware.org. Thanks again. > There's a small set of target methods that must always be > implemented by native targets, to avoid falling down to the > target beneath (since the target may not be pushed when the > method is called). See target.c:complete_target_initialization > in current master. Since all native targets inherit from inf-child > (just like in current master), in the C++ version, we can override > it there. Like below. This fixes it for me. > > diff --git c/gdb/inf-child.h w/gdb/inf-child.h > index d3f8b71589..956cee2a0a 100644 > --- c/gdb/inf-child.h > +++ w/gdb/inf-child.h > @@ -72,6 +72,7 @@ public: > target that can run. */ > bool can_async_p () override { return false; } > bool supports_non_stop () override { return false; } > + bool supports_disable_randomization () override { return false; } > > char *pid_to_exec_file (int pid) override; This is in the branch too now. Thanks, Pedro Alves