From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cJuPN7ANnmjUZgMAWB0awg (envelope-from ) for ; Thu, 14 Aug 2025 12:24:16 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i6P+5gyl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D33241E0B3; Thu, 14 Aug 2025 12:24:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6E6D81E04C for ; Thu, 14 Aug 2025 12:24:16 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0B9C23858C40 for ; Thu, 14 Aug 2025 16:24:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0B9C23858C40 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i6P+5gyl Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id DA7C63858D20 for ; Thu, 14 Aug 2025 16:23:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA7C63858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DA7C63858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755188622; cv=none; b=EXzTE4c5C1cVReQHmtiFTt/SSeQ7ZiaGc02gk3C2G2wNWWA9qtJ1dbkwygCXsiFRR0vcibfkw367dB9sv0Y9HkjwMozoUxhu9mwfGfUYHjDY6/7720yFOxyfKmh1uzTSzjAw090tiuhtQI7eLhgRmBBonuq3fWG/KFsSW2A3ZWY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755188622; c=relaxed/simple; bh=eg1/Fe3zcqL7d3zTY0PLhT6W80pOScnYCTan72F+oC4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=FOi/OJLb2IVxs66jGUBITpOscvbvsAfIte07grmXAqyhrUwfepiOggViWcukU0HFtkH09hDg6cVfpWd0ev5VNYhfkBQ3NDHLB8TikvWvy/XHPWJ3qQTwY0DqvCNqrdfitpzUffx98w6S8nBRw3NR4ZxB1vvqGKOSAfK7FVozpW4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA7C63858D20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755188622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VeyAmv3w9ItcCn3NXued6ZSoZ0lbeB6zgliXoGOsCLo=; b=i6P+5gylpNJ4dBBtTHUG92OMdEQ06NrL28VAzRZ/0ioUKAOjiSCkR0XMmZW82yjpD78z8a Evv6CIVFrcPDgb/ozLHG9xbAAeh2mCJX/V/Zo+4rkgTZ06xGmSW84Xl1ISBeQdaOjCIRou Efg0OuxmuRPhhQ8A/yCOGnR6MEhhngE= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-4C3Uio9VMDSWrt0wBYbxaw-1; Thu, 14 Aug 2025 12:23:41 -0400 X-MC-Unique: 4C3Uio9VMDSWrt0wBYbxaw-1 X-Mimecast-MFC-AGG-ID: 4C3Uio9VMDSWrt0wBYbxaw_1755188620 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-244582c20e7so12981235ad.3 for ; Thu, 14 Aug 2025 09:23:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755188620; x=1755793420; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VeyAmv3w9ItcCn3NXued6ZSoZ0lbeB6zgliXoGOsCLo=; b=JCRjXVM0x4iHth1af7HksP9w/sYgl0RC/GKtXkx8aDiuHVmKqpguVePn0th+1cvPll TnCk5Ho1OXSEh0i0XoiRHHqmFhBDv6n+uw2Gp7C0i8plsu3ovW1l+/5Gp60RoY0ASjO6 NY7CK41qiCr+ugoIxqjLAJUCwTmQrNrOLrH9OfJs84LpH50X0pM6BZBpQuEKaWoK1TN/ RWCSFd2zWxCNAeqD+QMe+O0XjnLeG6dkXltb6jxJkSfgw8T+16AljnlwbL99OCmJEQDX tYb2dLKCVa9MceBBJpaof4k4Li889MBTpHoWarUtDd+AGZHFOK1hAwwUS17vDWcsdk2Y kLYw== X-Gm-Message-State: AOJu0Yx95ZWp68qSRE1SJ2frE1CI+zLoDMRvuY5kVm4qPYpoHGHIaOKT SCLgXnw0T9HdxAsSJRG2htOP/i1Tx/XRkx72zjTPyWi+UBqC/mdvhBxnlNxbzkC5HkIjw/GpkwU lWup0M0toLLogXVEIZcBFOSMR0RuyMh2gwnqH5dOaNd5dTEvhbyDJCllqQKze+l3Kk86nDiE= X-Gm-Gg: ASbGnctQAsXVEx8pn/YfP4zz389T2txYckSYPVUTZqoWC4rxLFhJETIq0KCdbSyvPJA xptr89LTHoJUmBTDi16uqVl6MI34fsq6W6lXGYgba4MAaeAGoL9KcAAk/GcgoWSdaAl8FdDfVAX 0/OTm9Y2zs0YWzNCCTGPqSeesCxaH5PmUhJrftcfOAZ5CLr9+e+ZrBmdveBHmZS2d0Hnx1Nwuo8 rM8Ncypts45Ozu4Ouq7U8bDs0VGRQESALQw/cuUQY5yO5DCT570ZqjTtShvjuEX+dJtJ4dd09MR 0rZ7lxB+N2Wbx9gjEZI1h8Cj9VAs34knJglKMs3m3sV/eqJYOkI= X-Received: by 2002:a17:903:3bac:b0:234:8e78:ce8a with SMTP id d9443c01a7336-244586d8923mr61699735ad.48.1755188619832; Thu, 14 Aug 2025 09:23:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGvIaOaJXgSsfEr43CRH9e+lCCw0njU/G/WVLxOyqjYEZniy5K8UYXjOtfqLnKjOaTu38reUw== X-Received: by 2002:a17:903:3bac:b0:234:8e78:ce8a with SMTP id d9443c01a7336-244586d8923mr61699315ad.48.1755188619353; Thu, 14 Aug 2025 09:23:39 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:9a69::1000? ([2804:14d:8084:9a69::1000]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-24300f8c9d1sm71561515ad.129.2025.08.14.09.23.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Aug 2025 09:23:38 -0700 (PDT) Message-ID: Date: Thu, 14 Aug 2025 13:23:35 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/1] gdb, configure: Add enable-binary-file-format option for configure To: Tom Tromey Cc: gdb-patches@sourceware.org, Eli Zaretskii References: <20250707201657.972546-2-guinevere@redhat.com> <20250806141722.3247763-1-guinevere@redhat.com> <87wm75nc8g.fsf@tromey.com> From: Guinevere Larsen In-Reply-To: <87wm75nc8g.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qPCrQkkBExBbVo9y87cA3Y3MudVEysubXzQP169EuGo_1755188620 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/14/25 12:39 PM, Tom Tromey wrote: >>>>>> "Guinevere" == Guinevere Larsen writes: > Guinevere> GDB has support for many binary file formats, some which might be very > Guinevere> unlikely to be found in some situations (such as the XCOFF format in > Guinevere> an x86 system). This commit introduces the option for a user to choose > Guinevere> which formats GDB will support at build configuration time. > > I think you addressed all the review comments. > This looks fine to me. > > Approved-By: Tom Tromey Thank you! pushed! > > Guinevere> Mach-O and elf support are also dependent on BFD support being compiled > Guinevere> in. In case one of those was requested and BFD does not support them, > Guinevere> the following error is emitted: > > I don't recall - was there a reason this isn't entirely BFD-centric? > Like, some option to disable formats in BFD and then gdb would just > adapt to this? Mainly because it wouldn't work with the format of --enable-binary-file-format (I think anyway). These attack surface patches were my first experience with autotools, so I wanted to make things as simple as possible while remaining consistent. -- Cheers, Guinevere Larsen She/it