From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68927 invoked by alias); 18 May 2018 20:46:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68916 invoked by uid 89); 18 May 2018 20:46:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=remote_state X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 May 2018 20:46:06 +0000 Received: from ESESSHC006.ericsson.se (Unknown_Domain [153.88.183.36]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id C1.24.27207.C8B3FFA5; Fri, 18 May 2018 22:46:04 +0200 (CEST) Received: from ESESSMB501.ericsson.se (153.88.183.162) by ESESSHC006.ericsson.se (153.88.183.36) with Microsoft SMTP Server (TLS) id 14.3.382.0; Fri, 18 May 2018 22:45:47 +0200 Received: from ESESSMB502.ericsson.se (153.88.183.163) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 18 May 2018 22:45:46 +0200 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Fri, 18 May 2018 22:45:46 +0200 Received: from [142.133.48.114] (192.75.88.130) by BN7PR15MB2387.namprd15.prod.outlook.com (2603:10b6:406:8c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Fri, 18 May 2018 20:45:44 +0000 Subject: Re: [PATCH 01/10] remote: struct remote_state, use op new To: Pedro Alves , References: <20180516141830.16859-1-palves@redhat.com> <20180516141830.16859-2-palves@redhat.com> From: Simon Marchi Message-ID: Date: Fri, 18 May 2018 20:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180516141830.16859-2-palves@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN4PR0401CA0014.namprd04.prod.outlook.com (2603:10b6:803:21::24) To BN7PR15MB2387.namprd15.prod.outlook.com (2603:10b6:406:8c::25) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:BN7PR15MB2387; X-Microsoft-Exchange-Diagnostics: 1;BN7PR15MB2387;3:/73Q7FGfyqqDuc9sHul27KoO4gavxUxcvNNN7iHjq8vJeyeOvuBVPCwQZrDSCgifFWwBGQAU9cqv8YFdlk0GPHuD0MGmuDyGpyiLzJWFuqrm0566Qnvit5sFyG0COOv4Us68YDAnt+fXNFXgP7kLITrnGyEc/F/dnmZZicotitbS44dLqOjKbdcYDyzUlT7roLcoTCVRAJCNWJ+eYmv/fXWqXmDFYqj569Sq1LCg7KSqF6djmjbD00s00S2mb6zY;25:Py7ac9+2HFZb79a7B2UyXJGZMNXlNyPVXOCU7AKaze6uZ6PzsYxedpVVAzUrjcDcYzg32FCO5NLEt6qq4JkC8X68G0Yu6jXGXIu3h2i1+Mzhb1TQm3teyNcpFZ9AzEBm5Dg8lknc1M4YY2FnzMfUWOStI2C4uEmwNsv+GcE6jj9AOU8GfNSbjWEjlxvkUjxkE1yim5pSLypz6ja+Bva++iCiW96T0/w8dIhFam21CNps6NV0We36vMAu2L1JPTBQ4w/PiT71jEuJEQWIasentV6knYNgl/d1QhkDKeu0vLXzpbx0qKB7cpuvHwVXlcXiCPtuCuI0Egx0UC5TVyoEJA==;31:G2ZGomfYQ5BVZQ8iUP7U8rV3As7iqMQ1xVj3AdcVLZk7NbuwGiG5VqrmFGpwcPBBUr3Fvqf6R44RIj9lII9eDneQTxEBvTgSqwGF1wUH3nVsotjEzORYCdyvIx8P9c9Bfsaqt8cIJKhecYKPdF720dmw4r7LlIQA86ZT8LewsJeuujSksVwEeY1zNquTxkCuGRcPy55dN0xaVYy4uUcGQ2yLrOfTM88pyn1p+gqugg4= X-MS-TrafficTypeDiagnostic: BN7PR15MB2387: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1;BN7PR15MB2387;20:6m66EmMxBFt2cgPwoAzHMjTtqfnnj/xNCUGVMZiF+0h2XcJAYvFNp0uM7B5x5zyrmvy5flSPmGUN2Oq87KKwOd0IR1cE0cx5nVKU2Xm+sU7L0kUZkIQUcawDUdZxhC9TnRP0NifDUX3KkwbVoNFYKq+xuTcnoDeJgaFHJf4rlpPphlv8cDrAWLfdfrwth8Pm1E8iynUYNZFQZTJFFh2bq9jkvKcPsSJg4+prmO9HjXkYtS0R/ciOEFrPf1LrcZ8BGoqnhVOiexQEMnWdH86uBm3gRsi/8F2rW+1q6o+mW3IKBNnkW/lHv8TPECVqGVRrgxN9L6wFk3HiRq6IwgbGjXDxiWUEbZhe1JaxZnfCRYvF73Pu27xp/q+LgloBc3kFq0OETo2QXFnPNCYh5+g50W+KP5euaD9ra9l87JrhAl5tbHOwEdKXm9/ncHg6ba7zbegFZxholBMJT+c81h7NHISJHG4FxUdDxjlrD9XDybJIkqZgq/XapgeoyHoZYdZV;4:7KpNuAeE6GLcVITl9oUaAqNxZFphO7pAYwhAH2XcIBcNaJrPM3HfygHhAwv2GGYyQxLRwQ2z1zeE1Oz1HumvlEisawLfBEzCY6qvuMGyxzVkWH9h+eFqf23v9nRvZcGeou08AXxfvYBrqgTUQNAnxdemSfXRnviFZCpf6XH6otPkQ/yLtV+1Jt3l+MyB3PE0EywHrsfKKQq7Yv/XR3Z411lhJ0WIQpiB8Lamn9HkmWD5WMjE75qr0dxZQY5b5zmqB3zQXKYe2rfqbvKyE1rpNA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);SRVR:BN7PR15MB2387;BCL:0;PCL:0;RULEID:;SRVR:BN7PR15MB2387; X-Forefront-PRVS: 0676F530A9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39860400002)(39380400002)(396003)(366004)(376002)(346002)(377424004)(189003)(199004)(2486003)(478600001)(49976009)(5660300001)(25786009)(97736004)(6486002)(106356001)(53546011)(105586002)(316002)(186003)(53936002)(386003)(26005)(16526019)(31686004)(6246003)(86362001)(52116002)(23676004)(31696002)(76176011)(52146003)(229853002)(65826007)(305945005)(7736002)(956004)(2616005)(476003)(68736007)(486006)(446003)(11346002)(50466002)(47776003)(81156014)(58126008)(65956001)(8936002)(6116002)(2906002)(16576012)(64126003)(8676002)(230700001)(6666003)(66066001)(81166006)(44832011)(36756003)(65806001)(3846002)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:BN7PR15MB2387;H:[142.133.48.114];FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjdQUjE1TUIyMzg3OzIzOjh6YUJLVlBSU1k4R0k3ZzMydHlQejVLZHB4?= =?utf-8?B?TUVWTTJVdlZPZkM4U0ZiTDNRQmZlRWsvLzhlZ0JrdFVndW5zeFViQmp5Z3Vn?= =?utf-8?B?MmtuaG9yZFVORURYQzk1MjdQZVVpZXJROU81b2x2Z1pCYXJFN3RkWk1iSTBp?= =?utf-8?B?dTZXUlFSa0REWktNRnZOZmx6RXN1NnB1Vkx6WjdKaXEzSTYvRnlYMkgzRVBF?= =?utf-8?B?ZTNZd0dnZTc3ak1iWmtlcVNhTFJqK1lXWjYrZ2wxS1U1Unh1YVNwajZxdXVU?= =?utf-8?B?dVk1Mk5kdERySThCQ2d1YktpUGdNSWFFRUE3VU5IcFV1NVQ3SG9aSHY0Nkth?= =?utf-8?B?cG5EdFBBU1U3YkxELzI3QXg4YmpXYXFkd2lRTHhpMWdRVXVhVTcwNjFCQTV2?= =?utf-8?B?bzdhTVkzTUdocEVuYzZzdmpqeGxCcFB3ZmczRWxYTjJxUDBQVFpRdm56NkI0?= =?utf-8?B?SExQdld6WjlaNDkrSW9BbGQyNFZuai8xMHJzL21WcHIwR2RqMndNd1FKNmZZ?= =?utf-8?B?MzNLQ3pJOGc5bE8xU3VqVDZrSlUwdXlkZHFFdzU3dkRLYmwzQk0wNzlmRTEr?= =?utf-8?B?N21hZVoyQks4TXowSCtId0t5MDR0MWgyRjVlS0dJZ21yNkJ1RDVBUnV4ZXh2?= =?utf-8?B?dUhYaGZzSnVJWkhrM1M3eE9CT0k0TEFYb0hyd3Vna3VHS2ZvT1p4N0NNcndO?= =?utf-8?B?R0dCS050YnMzNU5xSnEzaWVxQXlvcFlxZjhzaUg0WFB3bmI3bTdORzVTL285?= =?utf-8?B?TWpQRTBJUzNEaHp1TmJmNzBKcGJEL1ZneGZDcFZjSkFFYko0NGsrTFlrN05z?= =?utf-8?B?V0x4bnc5d3hSM25tbEFVTkdlZzRtYVpOVTlHc0h1cUlyamQ2VU9RU1RPcFNR?= =?utf-8?B?MXZFUnZHNVlYWmJyMjBMMUJSNFZvT0FaanlxK2V5QnRFa291NThkSEIxS1pP?= =?utf-8?B?MjA1VUFFbkU3clQ0UzVudU1LZ3BVdVV5SlIzYS9ZZGhaSnhRSVNmQkwwWHR3?= =?utf-8?B?cUpQVnFteDJnYTQwckdHaFlQUERLTUF1NlpBcW1SQ1Fjek0xL0pybWRqdUtB?= =?utf-8?B?c1o4T0ZTS0h6NElQTjlWYzRkSkQ2MHlKdy9XWnhsM2RWKy9rUEEzc0xoNTZ1?= =?utf-8?B?SkRlMlVBT3VkVW13YkJvaElXczZmT3hhaHYvU2FpRTN4aFZFeDVNNGppS0d4?= =?utf-8?B?dUJBWHpya0xCcC8wNVJLYUFDWmI0Z1NnVlRQai9BK1lDVnBmbStqR2FrR3cv?= =?utf-8?B?ZTZqZmNhMzQ5ZjJSTElodjBrWUdKbklWUWJ6cHR6K3RKcmpSeFdxMEhmY1hZ?= =?utf-8?B?aDNvdlVxT1pES2ZJM2tmbUtKQWhTRmZUY2I1K0NsZGUzSEtobVgzVkFuRllO?= =?utf-8?B?WnBRSnFlWkpIeUdoclFCVFZQb1FnQVczU0w5Um1WSlRkMzhwckJjbzROU1Vh?= =?utf-8?B?ZkNUT05VV2FwYS94Z0FKT3NOY3NnOFFyMnVXQ1hsanltTmhlUkx5L1BycjFE?= =?utf-8?B?bExLTXZncnlid05XeXFISVZUbVJOc1lORnpjY1ZmRjFVaUc2SVh6aXBGc3dt?= =?utf-8?B?NUFQUDJNZlhseWlFeFJhcVRTbWwwZlhweGJUOFFWU3ROOWF6S3NhcTRYTDJV?= =?utf-8?B?NmpDMXpiWVNBeWZOeSt4UWludEZyeFBBMnFPb2plMnZuNmt0YVc0N3d6UThy?= =?utf-8?B?anJxVVgyZXhtUlo5SXRsNVF0S0Vlb01Ua1ZMT25kK2RSSGl2cm8vMkdzc2FN?= =?utf-8?B?MHJVUTdka2FzeGlPTlpMMGgrc3FLR1FFTDQ4bUJmOXdJR1hnd0ZRSUlvVmIr?= =?utf-8?B?LzJ0cDlSYm9NNmVIN1Azb1UwckpNUTVmWVd4YlZURnd5VkZFRVpsZjh3QTZs?= =?utf-8?B?dFJzZFhNVDN4UDdwWDlSWit6YkRWRUJjY1Q4MnhFRXZsSitveFBEZVRpS2Z5?= =?utf-8?Q?MTWzVUE+b9zRP0cgSqoYLvnplYtGGM=3D?= X-Microsoft-Antispam-Message-Info: 1KLA0CMWVHbG4QBnlPcBgpreI2qTeXJxXclNPnetTGpQY5YI8eUUsJzHwDqlyh6Ig5JZ34+806n0lesix27xQ8Dnop/fsJ7JtcQCWTUB4iCouERdSdXWbV9izjPLdn+IvaXyRSGgjkEb0X7I2pNdEoXLI9RzHeiCoCiBGhqqcyLK18fdepFY9uAkek62tP2P X-Microsoft-Exchange-Diagnostics: 1;BN7PR15MB2387;6:paAvZ+geWYfBvUCXoGHd5AHdmupXNxg929cdGvkpwomzeUdDcISJN7oVPqkE2xlZlyeLM/48pESt8+iJJR//QhTON7E5UFYGj3ZoQ6Ic8FGyahW5W9mSiqx35nI96jco6quZqRqOfK5yENfEzcyE5Ur3xjtgHY5K2ypGZ/z6205uwsa8Jg06E26f3cH+1Pcat1xuFNcYCmTBwikvfcwy/vcak4OdE40W0lQkf3z+Woq7mT+9z0iyd8tpB6rQnSuoLS9cVdebz9r40sFPSfw+CMK04Ffs2FbK15wdE6dxMG7orWVTvYg/NHGjdFrmLi2/c66nprv2J2S1pijVMqCQv4C/TlmEV5SGEri2aWdqVADYERs6REWtFiao2b8+z34dPHoyx4wWTDtRvShtqlKuvr+BM7FWmyHg1W+Xy71R7w7U3XenDhZuZs5W5OpytEk43ozE/LUx+J6lU83Iqz/EhQ==;5:p5tp43K1UxGdWHm9/p/NF3Jqg0dFrdCvuQqT2bt7M9C5YPU7uFzUe97oSG/S63Udzjvba9NnESCJtfvFQrcD7WmIr97o+6REgWq2w5QpMCxSUffXmcyV4AhJj1HvzcCY45kNroc+U1Bg5Huwg0hFCHLJDAhaMLghgQ1zyA1k/x0=;24:J08f0DA8gV6jgyfhMjvvSu54+IAp3WFjDKiGlV7fteZLOqee1W4YqwmQ3YoSXZ/iPhHk8Y2kMPUy2Ij7scq53tWyTuX32WnGrH/+TufdAtc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN7PR15MB2387;7:XwGvuvHwshF/q52JcvMw3fZyUsYY3irSqm978TH1NWpst/w6uNFzq7Lnsq/4QN50j+Y59Cpr0ikkMsvHsQsR2ZTsL206/V+9pYKL1Yv15Zy2QbIqHWfn9+jZO5fBWgfAMf3oazmDaiF1XUWLH4TXh1lvprY2N5qNyabFOqnrhAXJLDPcQ66XEq2n/GPBHxqWwfITTxuy3TZHtHBK1HH7n6WumnYpDHMvPIkUOhzjbhI89noEIk6/1a3PqFfh8fse X-MS-Office365-Filtering-Correlation-Id: c0f4180f-86b1-406c-46a4-08d5bd0053cd X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2018 20:45:44.2029 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0f4180f-86b1-406c-46a4-08d5bd0053cd X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR15MB2387 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00420.txt.bz2 On 2018-05-16 10:18 AM, Pedro Alves wrote: > A bit of C++ification. LGTM, I just noted some questions. > @@ -657,12 +660,12 @@ struct remote_state > process it once we're done with sending/receiving the current > packet, which should be shortly. If however that takes too long, > and the user presses Ctrl-C again, we offer to disconnect. */ > - int got_ctrlc_during_io; > + bool got_ctrlc_during_io = false; > > /* Descriptor for I/O to remote machine. Initialize it to NULL so that > remote_open knows that we don't have a file open when the program > starts. */ > - struct serial *remote_desc; > + struct serial *remote_desc = nullptr; > > /* These are the threads which we last sent to the remote system. The > TID member will be -1 for all or -2 for not sent yet. */ Should general_thread and continue_thread (below, not shown here) be initialized too? > @@ -764,6 +767,20 @@ struct remote_thread_info : public private_thread_info > int vcont_resumed = 0; > }; > > +remote_state::remote_state () > +{ > + /* The default buffer size is unimportant; it will be expanded > + whenever a larger buffer is needed. */ > + this->buf_size = 400; > + this->buf = (char *) xmalloc (this->buf_size); > +} > + > +remote_state::~remote_state () > +{ > + xfree (this->last_pass_packet); > + xfree (this->last_program_signals_packet); Should other fields be freed here? - buf - finished_object - finished_annex Simon