From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40648 invoked by alias); 5 Jun 2017 13:27:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40634 invoked by uid 89); 5 Jun 2017 13:27:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Jun 2017 13:27:28 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9E7DCC0587E1; Mon, 5 Jun 2017 13:27:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9E7DCC0587E1 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9E7DCC0587E1 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 08C9680A2C; Mon, 5 Jun 2017 13:27:30 +0000 (UTC) Subject: Re: [RFA 16/23] Remove in_user_command To: Tom Tromey , gdb-patches@sourceware.org References: <20170503224626.2818-1-tom@tromey.com> <20170503224626.2818-17-tom@tromey.com> From: Pedro Alves Message-ID: Date: Mon, 05 Jun 2017 13:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170503224626.2818-17-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00114.txt.bz2 On 05/03/2017 11:46 PM, Tom Tromey wrote: > While working on the next patch in this series, I found that the > global in_user_command is not used. Looks like I removed the last (or only) user in: 268a799a454ce862f516ff2215290fae08eca7fa ("Make stdin be per UI") https://sourceware.org/ml/gdb-patches/2016-05/msg00123.html > This patch removes it. (I didn't > think to check Insight until submitting this series; and it's not very > convenient to do so, so if someone has it checked out and could look > at it, that would be nice.) Insight master is still based on a gdb from Jan 2016 so it still has the use in the old input_from_terminal_p in top.c, but there's no use in gdbtk/libgui. If insight really needs it when it rebases, we can come up with something then. > > 2017-05-02 Tom Tromey > > * top.h (in_user_command): Remove. > * top.c (in_user_command): Remove. > * cli/cli-script.c (do_restore_user_call_depth) > (execute_user_command): Update. OK. Thanks, Pedro Alves