Re: [RFA 11/42] Move processing_gcc to stabsread

Tom Tromey
2018-07-08T16:56:47Z

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> On 2018-05-23 12:58 AM, Tom Tromey wrote:
>> processing_gcc is also only used by stabsread -- it is set by the
>> DWARF reader, but this turns out not to be needed. So, this patch
>> moves processing_gcc and removes the assignment from the DWARF reader.

Simon> Any idea if the assignment of processing_gcc_compilation in go32-nat.c is
Simon> useful? In looks very strange to me to set that in nat code rather than
Simon> in symbol-reading code...

Simon> Either way, it LGTM, I am fine if you leave it there to stay on the safe side,
Simon> since I suppose you couldn't test that change easily.

Yeah, I have no idea and didn't want to mess with that.

It does seem incorrect to set it there. Here's the email about that
change:

https://sourceware.org/ml/gdb-patches/2000-q1/msg00710.html

Not much to go on, and long enough ago that many other parts of gdb
might well have been very different.

Anyway I tend to think that this port in particular can mostly be
approached with benign neglect.

Tom