Re: [RFA 34/42] Add many methods to buildsym_compunit

Simon Marchi
2018-07-10T04:12:07Z

On 2018-07-10 12:08 AM, Simon Marchi wrote:
> On 2018-05-23 12:58 AM, Tom Tromey wrote:
>> +void
>> +augment_type_symtab ()
>> +{
>> + gdb_assert (buildsym_compunit != nullptr);
>> + buildsym_compunit->augment_type_symtab ();
>> + reset_symtab_globals ();
>
> reset_symtab_globals () is called both here and in
> buildsym_compunit->augment_type_symtab, is it intended?
>
> Same thing for end_symtab_from_static_block and the corresponding
> method.
>
> Otherwise, LGTM.
>
> Simon
>

I just saw that patch 36 removes it anyway, so never mind.

Simon