Re: [RFA 04/42] Move last_source file to buildsym_compunit

Simon Marchi
2018-07-08T17:01:58Z

On 2018-07-08 12:52 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>
> Simon> On 2018-07-08 12:33 PM, Tom Tromey wrote:
>>> All the data members are private by the end of the series, but I didn't
>>> generally try to do that at each step along the way. This is one of
>>> those compromises I mentioned in the cover letter -- where a bigger
>>> reordering of the series might have yielded a prettier series, but
>>> didn't seem worth the effort.
>
> Simon> Ok, no problem then. You can ignore other similar comments I've
> Simon> already sent.
>
> I already sent one other reply but you can likewise ignore that :)
>
> This series is a bit unwieldy. And I should probably have mentioned
> earlier (before Keith went to the effort of applying it...) that it is
> in my github as submit/buildsym-fixups, in case you wanted to check it
> out or something.

It's been mostly fine so far (just one or two trivial merge conflicts), but
thanks for tip anyway. The patches are good on their own I think, so feel free
to start pushing them as soon as they are approved, so the pendant part of the
series gradually shrinks.

Simon