From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106224 invoked by alias); 29 Jan 2018 17:36:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106117 invoked by uid 89); 29 Jan 2018 17:36:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy= X-HELO: mail-wm0-f44.google.com Received: from mail-wm0-f44.google.com (HELO mail-wm0-f44.google.com) (74.125.82.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Jan 2018 17:36:53 +0000 Received: by mail-wm0-f44.google.com with SMTP id v123so35297381wmd.5 for ; Mon, 29 Jan 2018 09:36:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vGtDGcBbcFPyd2xhsZBwv4/EwMtbWFapVqA/7D52K3U=; b=dQqntTAmZeIDc2VSxdAWatBVtl24Xu0371Kv5YuL6JAnFpvzuCqEsZuRi02C1Bps9W hQcOUV4Aeugwppp2ecJzKrNXsNtkC0N33sWQeSVGS7s+4D24uve06gkh6lQ/pi+K3/2v 0m0teznN3guI/KHbPV/NhSwi2Wwe4j6KbmJAh0FNGOgiRRJVPeFDtRwVLP0vAbW6lPpe gAqZccYQxRuCwNfRzQOI/53azFBr98vXHsQJGgGPOcyzNCtEA8j2bFtxSL7Aptgb39B0 Lo+izLzXjABniQYW3aUnv22HNEDRMXMptJ/Lv37b6cXNJDHRZwIeuPxzGHHyJug7FVp+ IT4w== X-Gm-Message-State: AKwxytfyLOgEIMah5Cd1xSIL8rgkk+00BhUkRel3Q/jtA14MdMVy6c6R no5tIYMb3SpTuGacKw/PntLKyA== X-Google-Smtp-Source: AH8x226esNg/OhrBS3OBAm7u6HEHkMQOc3Z3xt1HIR6tm3SANwT9gH6BExJQGnWKPEcYqdZNTXDntg== X-Received: by 10.28.18.143 with SMTP id 137mr4464257wms.31.1517247411214; Mon, 29 Jan 2018 09:36:51 -0800 (PST) Received: from ?IPv6:2001:8a0:f915:7500:56ee:75ff:fe8d:232b? ([2001:8a0:f915:7500:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id x18sm13056664wrg.82.2018.01.29.09.36.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jan 2018 09:36:50 -0800 (PST) Subject: Re: [Regression] Segfault on native-extended-gdbserver + fork To: Simon Marchi References: <20180119161628.21611-1-simon.marchi@polymtl.ca> <20180119161628.21611-3-simon.marchi@polymtl.ca> <87efmaebo3.fsf_-_@redhat.com> <931f8b594f7405649778f66ab2960a40@polymtl.ca> <669ec8c3-caa3-6901-b26c-00a7e20bc0d1@redhat.com> <1b82573ce66790c935eaff87b7565907@polymtl.ca> <8bbb4b6c-46eb-21c3-dad8-327bea8485fd@redhat.com> <5a92a367fa44671fb875fd59528c2bda@polymtl.ca> Cc: Sergio Durigan Junior , gdb-patches@sourceware.org, Simon Marchi From: Pedro Alves Message-ID: Date: Mon, 29 Jan 2018 17:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-01/txt/msg00610.txt.bz2 On 01/29/2018 05:31 PM, Pedro Alves wrote: > On 01/29/2018 05:03 PM, Simon Marchi wrote: >> On 2018-01-29 11:58, Pedro Alves wrote: >> Agreed.  Though I don't think Sergio's original patch is needed if we instead remove the detach_inferior call in remote.c, so your patch shouldn't be based on his. > > Yeah, my patch was a tangent / orthogonal to his regression fix. > It was against master. I was thinking more about the whole > effort to enable "set print inferior-events" on by default > that Sergio is working on in context of: > > And now that I reread that url, I remember that I was actually proposing to drop the print from within exit_inferior. Otherwise, we'd end up with (with both that url's patch and the patch I just posted): ~~ [Inferior 1 (process 2629) exited normally] [Inferior 1 (process 2629) exited] ~~ which is the sort of redundancy I was talking about. Likely we'll end up doing the same to detach_inferior too. So I'll just forget this patch for now, as it'll probably end up unnecessary. Thanks, Pedro Alves