From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109357 invoked by alias); 30 Apr 2019 12:56:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109349 invoked by uid 89); 30 Apr 2019 12:56:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*Ad:U*palves, windows-nat.c, UD:windows-nat.c, windowsnatc X-HELO: mail-wm1-f53.google.com Received: from mail-wm1-f53.google.com (HELO mail-wm1-f53.google.com) (209.85.128.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Apr 2019 12:56:55 +0000 Received: by mail-wm1-f53.google.com with SMTP id b67so2299965wmg.1 for ; Tue, 30 Apr 2019 05:56:55 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id 17sm36801512wrk.91.2019.04.30.05.56.52 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 30 Apr 2019 05:56:52 -0700 (PDT) Subject: Re: Fix compilation using mingw.org's MinGW To: Eli Zaretskii References: <835zrbe36c.fsf@gnu.org> <250801eb-14f6-5a35-0556-cf5797dd8a7b@redhat.com> <83y347cfbu.fsf@gnu.org> <556cefd7-47ce-54ab-a228-2c727aab4179@redhat.com> <83d0lick7o.fsf@gnu.org> <93ccb0fa-8a05-60ff-d1a8-85d5663b8d16@redhat.com> <831s1murm2.fsf@gnu.org> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 30 Apr 2019 12:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <831s1murm2.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-04/txt/msg00642.txt.bz2 On 4/28/19 3:33 PM, Eli Zaretskii wrote: >> Cc: gdb-patches@sourceware.org >> From: Pedro Alves >> Date: Fri, 19 Apr 2019 12:33:37 +0100 >> >>> I will try doing this in common-defs.h, but for the branch, we could >>> set _WIN32_WINNT only in windows-nat.c, as that's the only file that >>> currently cares, which should be safer. WDYT? >> >> Sounds good to me. > > Below please find 2 patches: the first one for the 8.3 branch, the > second one for master. OK to commit (after writing ChangeLog > entries)? Sure, LGTM. A few remarks: - The override in _WIN32_WINNT is no longer necessary. It could be removed at the same time. - IIRC, Cygwin uses the same w32api headers as mingw.org. I don't know whether Cygwin sets _WIN32_WINNT to a higher number already; we haven't heard any complaints, so I guess it does. - We could remove the dynamic loading of GetConsoleFontSize & friends now, right? (for a separate patch/rainy day, not in this patch.) Thanks, Pedro Alves