From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95564 invoked by alias); 14 Aug 2017 13:57:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93976 invoked by uid 89); 14 Aug 2017 13:57:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f44.google.com Received: from mail-wm0-f44.google.com (HELO mail-wm0-f44.google.com) (74.125.82.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Aug 2017 13:57:31 +0000 Received: by mail-wm0-f44.google.com with SMTP id i66so44531507wmg.0 for ; Mon, 14 Aug 2017 06:57:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AVVtebLcHGueuqLXpUmwr/IyTIGZQMed3aB+q37wVH8=; b=Z3sycCG7iBDv9ER/PPu3ElCBXecR9m1oK/RWxD4cxzEF9ZKO0ujXlQD7S9Myo3qbjp qNC8vRWMYchb5xHJ7PNp1NaEssxbFbVCc4lV2yvAjDgbfb9bwttMZ3CQBnc5tfNiF3b7 Sq3VL1jg6saVaMj+5+EhXXELouIArI3WWI/Lt+rRd5zGFpqlzD4x6Tdbn/1XZ5Qglv+q z0IWtrzcKAvAePoPdBHrIUpdZ1pHaFD0XIkkti8jTCbQeAz2ykYOJv6erUZ5h2g8UsCu f5JkIu2qtCGu+0bpUGjQ3weDlPjexR3Ijp3BfUi7lijK4H+SvXqMiRvhKfjC0y7FMHIx wJ7Q== X-Gm-Message-State: AHYfb5jF9XtFPvga3fDVx8w1Zv+wWMRkbP1DqbTaOcxKtXpOG8OXrELc 6EUX1GrluWMMe5O1I904Lg== X-Received: by 10.28.184.23 with SMTP id i23mr4435309wmf.22.1502719049151; Mon, 14 Aug 2017 06:57:29 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ae15:7800:4685:ff:fe66:9f4? ([2a02:c7f:ae15:7800:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id c13sm6402336wrb.87.2017.08.14.06.57.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Aug 2017 06:57:28 -0700 (PDT) Subject: Re: [RFA v2 00/13] various frame filter fixes and cleanups To: Pedro Alves , Tom Tromey , gdb-patches@sourceware.org References: <20170814034030.20863-1-tom@tromey.com> From: Phil Muldoon Message-ID: Date: Mon, 14 Aug 2017 13:57:00 -0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00294.txt.bz2 On 14/08/17 14:20, Pedro Alves wrote: > On 08/14/2017 04:40 AM, Tom Tromey wrote: > >>> So "bt elide" means "elide the elided frames", not "show me the >>> elided frames too". It's fine with me, though I mildly wonder whether >>> users will be confused by the "double negative". >> >> "Elide" means "drop", so really "bt elide" should mean "drop whatever >> frames are droppable". Having "bt elide" mean "show the dropped >> frames" would be confusing. But maybe another word would be better >> here, I don't know. > > Maybe "bt no-elided", to go with "bt no-filters". > > Because "elided frames" are a preexisting concept, and "elide" is > actually referring to that concept. I suggest hidden or show-hidden or something like that. > > @item backtrace no-elided > A Python frame filter might decide to ``elide'' some frames. Normally > such elided frames are still printed, but they are indented relative > to the filtered frames that cause them to be elided. The @code{no-elided} > option causes elided frames to not be printed at all. > > Or alternatively, to make gdb not print elided frames by default and > add a "bt elided" switch to print them: > > @item backtrace elided > A Python frame filter might decide to ``elide'' some frames. Normally > such elided frames are not printed. The @code{elided} option causes > elided frames to be printed, indented relative to the filtered frames > that cause them to be elided. I'd prefer a "hidden" attribute to the frame decorators (or a callback API like the rest of the functions). Returns True or False. GDB would honour this and print/not print the frame according to the value returned. This is better, to me, than a global override printing/not printing all elided frames. The bt command should still have a global override (IE, elide, or hidden, or show-hidden, or whatever) as discussed in the patch, and that would allow the user final and manual control of what is printed or not. I prefer frame decorators to be able to decide what should, or should not, be printed as the default as it's the presentation layer. What do you think? Cheers Phil