From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id F+5vNbA6vWrmRB8AWB0awg (envelope-from ) for ; Wed, 30 Sep 2026 12:37:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1790786224; bh=yJd0Sy70P9+VdyR9CeQj/ORcNID527QvU3jv/APCF/U=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WsMZwwYIQ8CrS2JiaavfLYzu5xArsAUtSN2avIE/UI1r95s8HM+NZVhse+CWHfjtn pE92yNoN1Okb8yq8inXxyJjE4AlDpF4a6xfCiHFWJUj1up4aew0Swx0i4LAEkD3JxS Fm44BZuEeAzyzI4OgLO04VIUdV1pgxkvoMdjViLI= Received: by simark.ca (Postfix, from userid 112) id BF9BD1E01F; Wed, 30 Sep 2026 12:37:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Zm3oFcQJ; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E91D21E01F for ; Wed, 30 Sep 2026 12:37:03 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7A4924BB58CF for ; Wed, 30 Sep 2026 16:37:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7A4924BB58CF Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Zm3oFcQJ Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 0A4784BB3BB7 for ; Wed, 30 Sep 2026 16:36:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A4784BB3BB7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0A4784BB3BB7 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790786199; cv=none; b=JpglP/spxyuX4hmCUYVwC/JQMPikzvDT/UNb0tsYTvEx0A8S4lJY+wpck6fTx96VU2Uyt+vfv4H2WQoZWBVT44nigOJoEaecTpHkervj/H6reTjnHTHttp6uJ7xh+o3RcBhpzlbJv3hm7HnFYxsaD/h2GqDDY135LdX6SaX7y4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790786199; c=relaxed/simple; bh=yJd0Sy70P9+VdyR9CeQj/ORcNID527QvU3jv/APCF/U=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=aPPZe2I5Mk0ytK6jBZz1rJMkSROZCXdlw9uQBNEGnbxG+yDr2G4GbxtcGFzztBkifE2VTm/8djpiGz/QOI+wmoAl2dJHwGXIAEtQFcr5WPJeqC9jPyNC/sx5V1/d6wdvqJp2Vgxeri/PkdMVTRxwKmkflvm/3rF43M3CBsjyWUE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Zm3oFcQJ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0A4784BB3BB7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1790786198; bh=yJd0Sy70P9+VdyR9CeQj/ORcNID527QvU3jv/APCF/U=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Zm3oFcQJxCEMcn6mKGAlTOoLXszMrcvaYm+Xb6ymenFvi+huvF1Al54eVi83ioUSy 4wuWFW0fCXYG/1XS+KuQ3SgO2SyVQ/dMj6MRDtD/dp6WpDdklcvYPd1JG9XTLC5zhl gy4xCeKPvrQQuhrybUdlmWQobZV3xGdSoACWnQz0= Received: by simark.ca (Postfix) id AC6DA1E01F; Wed, 30 Sep 2026 12:36:37 -0400 (EDT) Message-ID: Date: Wed, 30 Sep 2026 12:36:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/9] gdb: simplify insertion in global_symbol_searcher::add_matching_symbols To: "Rohr, Stephan" , Simon Marchi , "gdb-patches@sourceware.org" References: <20260929194119.155169-1-simon.marchi@efficios.com> <20260929194119.155169-4-simon.marchi@efficios.com> Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-09-30 04:20, Rohr, Stephan wrote: > Hi Simon, > > one NIT, otherwise looks good to me. > > Reviewed-By: Rohr, Stephan > > Thanks > Stephan > >> -----Original Message----- >> From: Simon Marchi >> Sent: Tuesday, 29 September 2026 21:39 >> To: gdb-patches@sourceware.org >> Cc: Simon Marchi >> Subject: [PATCH 3/9] gdb: simplify insertion in >> global_symbol_searcher::add_matching_symbols >> >> std::set::insert does nothing if an equivalent element is already >> in the set, so checking with find first is redundant. Replace find+insert >> with emplace. >> >> Change-Id: I869284407cfefb9b2d7ad7305fe04fbdaee25f1f >> --- >> gdb/symtab.c | 8 ++------ >> 1 file changed, 2 insertions(+), 6 deletions(-) >> >> diff --git a/gdb/symtab.c b/gdb/symtab.c >> index c4f76a494abd..4b2c4be8d117 100644 >> --- a/gdb/symtab.c >> +++ b/gdb/symtab.c >> @@ -4880,13 +4880,9 @@ global_symbol_searcher::add_matching_symbols >> if (sym->domain () == MODULE_DOMAIN && sym->line () == 0) >> continue; >> >> + /* Match, insert if not already in the results. */ > > I think we can remove that comment, too. It was targeting the find & insert > mechanism, which "emplace" takes care of. Yeah... I left it because it might not be obvious that emplace does that, so I wanted to keep the comment to describe the intent. I think it doesn't hurt to keep it. Simon