From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67247 invoked by alias); 12 Nov 2018 15:40:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67227 invoked by uid 89); 12 Nov 2018 15:40:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Nov 2018 15:40:19 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id wACFeC1M014474 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 12 Nov 2018 10:40:17 -0500 Received: by simark.ca (Postfix, from userid 112) id 7C5961E74D; Mon, 12 Nov 2018 10:40:12 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 35EB61E477; Mon, 12 Nov 2018 10:40:11 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 12 Nov 2018 15:40:00 -0000 From: Simon Marchi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Add completer for skip numbers In-Reply-To: References: <20181111165446.7069-1-simon.marchi@polymtl.ca> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00210.txt.bz2 On 2018-11-12 07:41, Pedro Alves wrote: > On 11/11/2018 04:54 PM, Simon Marchi wrote: >> Add completer to various commands that accept skip numbers: >> >> - skip enable >> - skip disable >> - skip delete >> - info skip >> >> These commands also accept ranges, the completer works for that but is >> not very smart. It will suggest invalid ranges, for example when >> doing >> "2-" it will suggest "1", which would not result in a valid >> range. >> Also, it will keep suggesting when doing "1-2-", even though it's >> an invalid syntax. >> >> A future idea would be to make a re-usable and well-tested completer >> for >> numbers and ranges. I think it could at least be re-used for >> breakpoint >> and thread numbers (for example with the "enable breakpoints" >> command). >> >> gdb/ChangeLog: >> >> * skip.c (complete_skip_number): New function. >> (_initialize_step_skip): Add completers to some skip commands. >> >> gdb/testsuite/ChangeLog: >> >> * gdb.base/skip.exp: Add standard_testfile. Add "skip delete" >> completer tests. > > OK. > > Thanks, > Pedro Alves Thanks, pushed. Simon