From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YTrPEvDn1WE4XQAAWB0awg (envelope-from ) for ; Wed, 05 Jan 2022 13:48:16 -0500 Received: by simark.ca (Postfix, from userid 112) id 3920C1EE18; Wed, 5 Jan 2022 13:48:16 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 843FC1EAA4 for ; Wed, 5 Jan 2022 13:48:15 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C63BC3858020 for ; Wed, 5 Jan 2022 18:48:14 +0000 (GMT) Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 7BA443858C3A for ; Wed, 5 Jan 2022 18:48:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7BA443858C3A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id E7FF572B20; Wed, 5 Jan 2022 18:48:00 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JTdlh5K93z3w4Q; Wed, 5 Jan 2022 18:48:00 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 55ED57A2; Wed, 5 Jan 2022 18:48:00 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Wed, 5 Jan 2022 10:47:59 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH 0/2] Unify target announce and detach messages Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20220105175916.2969966-1-tom@tromey.com> From: John Baldwin In-Reply-To: <20220105175916.2969966-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1641408480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+IF2HZTZpXz82HPPUWvPv71m6odWsy6DFPYNF0Hw+mQ=; b=g9qWjLNmFzEbX76gZt4buNBlQrKIlw5Z9G/KcWkJhVndoggXvZLsWCp3fvR3SFKIPcorTl s06MakyM3wp1X8xesVOvFOsgNaqummgONv+k4+BO2PCif/Jzsii6WF3ZQm5DVZ+P3gT+Ec apHmdapcgwHVYJWteF1y32OSNAwr9pjjmqxNiYl9bB9hNI2ceJpYUNURW/DMA/2xc6Dqjf P8/8G7SyQrO8RKSR3Aub2cBE4oNmKoXQQtWLemuh2CcMMTAbdmRBpiqXEEyR/Ut1Lh/LNU gcMPQnH5hxlrLj9ZX/UDlN05x1OykIxjMzRBsgq6jrJaedxaUghble7jBr4/ig== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1641408480; a=rsa-sha256; cv=none; b=pqOLN6IZjnuX7IRnI22S/DlXUN4nJwQThNbC/CBUfptP1UKw5tTSZYMYcqyHipgTN5264p xs28V9LAIpPiNIx8eepN+yOxhlu3YGzg8fjOfK7ZVcTFID6ZqXNhlwadVu4gMdyZYltpkJ 0d9btxT2K2bXo9tQSDYK1XWSrOvHUy1LEMxkSD5ptMmFoofggR9735co1FExSOS0JkdevG oZXwXkXFjvYa0Y6ARnjYAiy+AappnaEBEKOkvGrtdOPtYLKnHZgASU9jfxRIyqKWDMyJYD tY/aeotJ8q0O6zfSZJaQsdmCDsg3tBmePIbZ5ylEuJV/fsbriS6gpw3BVGIytg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 1/5/22 9:59 AM, Tom Tromey wrote: > While slogging through all the printf's in gdb, I found some repeated > code in the target layers to announce attach or detaches. > > This series unifies this code and removes the redundancies. > > I wasn't able to build some of these, as I don't have the proper > operating systems. So, those are on a "best effort" basis. Looks good to me. -- John Baldwin