From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Tom de Vries <tdevries@suse.de>,
Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Simon Marchi <simark@simark.ca>, Pedro Alves <palves@redhat.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/remote] Fix invalid pointer in remote_async_serial_handler
Date: Thu, 7 Jan 2021 11:29:29 -0500 [thread overview]
Message-ID: <b7a8e24f-0e01-a0f0-5c8c-53a9b174ce30@polymtl.ca> (raw)
In-Reply-To: <9e91b3c0-96f4-f6ac-411e-2319b3ba38f2@suse.de>
On 2021-01-07 11:27 a.m., Tom de Vries wrote:
> Hi Andrew,
>
> [ cc-ing Simon again ]
>
> Simon did mention in the discussion in the PR that he would submit the
> series, so yes, I was aware of that.
>
>> You said above that your patch is proposed for gdb-10-branch, but also
>> that it could be applied to master. I think that this would be fine
>> applied to the gdb-10-branch,
> Thanks for the review.
>
>> but I think Simon's fix would be better
>> for master.
>>
> Sure, that's fine by me.
>
> I just wanted to mention the possibility of committing this to master,
> and let others decide whether that's a good idea.
>
>> Though that said, I notice your credit Simon & Pedro in the ChangeLog,
>> so maybe they've expressed a preference for this solution somewhere
>> and I've just missed it?
> The patch was written by Pedro, and Simon provided the trigger patch.
> The patch was discussed as possibility for gdb-10-branch, and this is
> the submission for that.
>
> Hope this clarifies things a bit.
>
> Thanks,
> - Tom
I agree that the refcount patch would be good for GDB 10, it's less
invasive. I still intend to merge my patch series in master, but I
am waiting for an ack from Pedro, who is quite busy at the moment.
Simon
prev parent reply other threads:[~2021-01-07 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 13:39 Tom de Vries
2021-01-07 15:15 ` Andrew Burgess
2021-01-07 16:27 ` Tom de Vries
2021-01-07 16:29 ` Simon Marchi via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7a8e24f-0e01-a0f0-5c8c-53a9b174ce30@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=andrew.burgess@embecosm.com \
--cc=palves@redhat.com \
--cc=simark@simark.ca \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox