From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id C3B383857C5A; Tue, 28 Jul 2020 16:28:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C3B383857C5A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 46DC01ED0B; Tue, 28 Jul 2020 12:28:28 -0400 (EDT) Subject: Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works To: "H.J. Lu" Cc: Andreas Schwab , "H.J. Lu via Binutils" , Aaron Merey , GCC Patches , Tom Tromey , GDB References: <20200502022903.175852-1-amerey@redhat.com> <996bd0f9-cec5-119c-19ea-b127cf1bb95d@simark.ca> <87r1svyche.fsf@igel.home> <3209078a-429a-4be7-b151-93c3f4a53655@simark.ca> From: Simon Marchi Message-ID: Date: Tue, 28 Jul 2020 12:28:22 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2020 16:28:29 -0000 On 2020-07-28 12:07 p.m., H.J. Lu via Gdb-patches wrote: > What doesn't work with my pkg.m4 change? (1) It deviates from upstream. I don't think we should do this unless absolutely needed. That's not the case here, the change is just there because you don't want to set up pkg-config properly for cross-compiling. (2) I don't think it's necessarily bad to try to do a link to confirm the lib is indeed there, but as I said earlier I don't think that doing as if the package was not there is the right response. This can happen if you have a mis-configured pkg-config (like you have) or a broken installation (for example, the .pc is there but the lib is not). In either case, there's something wrong with the build environment and I think it's more useful to abort and tell the user rather than silently failing. Point 2 should be discussed upstream anyway, there's no point making a decision local to binutils-gdb. Simon