From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9sFjKe1fZGpOeywAWB0awg (envelope-from ) for ; Sat, 25 Jul 2026 03:04:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pb8y+kUF; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Fo4Y7VLd; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pb8y+kUF; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Fo4Y7VLd; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 973C61E09E; Sat, 25 Jul 2026 03:04:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1B1E01E099 for ; Sat, 25 Jul 2026 03:04:12 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 309CF4BA7986 for ; Sat, 25 Jul 2026 07:04:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 309CF4BA7986 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pb8y+kUF; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Fo4Y7VLd; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pb8y+kUF; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Fo4Y7VLd Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id C53CC4BA2E08 for ; Sat, 25 Jul 2026 07:03:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C53CC4BA2E08 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C53CC4BA2E08 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784963022; cv=none; b=p1iUBMYim7RINzKz5lP0bNUp7EbzFepNaHnX039aL4JLYWy2jK1aC1sKefAiPQALSyJ8pnXkptEghFRf1W1zeNa117F/G/OdPwB2ARX1R1KSvlaUUx2FuHQwEwI/yCzyqFMn0fcS2Tg4NsC4JT/LG2wI1BG0JNAqigxb+K4NsCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784963022; c=relaxed/simple; bh=CJH1+zqtyiEgdwH6LE7/2/+E9jHx43PCrE6J4WsQ7Yw=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=RtqW3p8fvnDBfntFeGYwNY+7QigKQfaQeuszjdiDR9Q8fA/GjdiZgsUl5KPsNpNz0iUgDyi7MSO9zPlB6uucktxb+jiVHTWWe3M+HU8ML2rLw9CMoSmABpHU74aq5Zx9Z6hKbPud6KTOX6HDhpC69Y7WayfY2y4c6QUrJXIAojw= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pb8y+kUF; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Fo4Y7VLd; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pb8y+kUF; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Fo4Y7VLd DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C53CC4BA2E08 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 65DF47CCA0; Sat, 25 Jul 2026 07:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784963021; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ft+rvVSkullUZvCyuqz2LiONSwYLtaIdhwMfa/WXlqk=; b=pb8y+kUFKz7eZp/IzlzuI73NssENkCGRXcg8swDUSZmkWgLjKBXMSXDdMKWCxOXLm/AFJC ZZJ9jE2s8d2wov0VJcLCsNVYBMp3yEHcaNHwUFTwTDBYFo5SfsRtzf8DoPQNPatLlkztBp KmbCe04dlcpHXWALTyP2BozC8c+9Q2A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784963021; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ft+rvVSkullUZvCyuqz2LiONSwYLtaIdhwMfa/WXlqk=; b=Fo4Y7VLd10fkqxGh9xVYR0dC9t57gTQBc53NTZC9HSAP0EOmPDpxLfqx9mqbx4j6PtJefr Ie/JM31oJ06GErDw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784963021; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ft+rvVSkullUZvCyuqz2LiONSwYLtaIdhwMfa/WXlqk=; b=pb8y+kUFKz7eZp/IzlzuI73NssENkCGRXcg8swDUSZmkWgLjKBXMSXDdMKWCxOXLm/AFJC ZZJ9jE2s8d2wov0VJcLCsNVYBMp3yEHcaNHwUFTwTDBYFo5SfsRtzf8DoPQNPatLlkztBp KmbCe04dlcpHXWALTyP2BozC8c+9Q2A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784963021; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ft+rvVSkullUZvCyuqz2LiONSwYLtaIdhwMfa/WXlqk=; b=Fo4Y7VLd10fkqxGh9xVYR0dC9t57gTQBc53NTZC9HSAP0EOmPDpxLfqx9mqbx4j6PtJefr Ie/JM31oJ06GErDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4E1C9779B9; Sat, 25 Jul 2026 07:03:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XHWjEc1fZGodbQAAD6G6ig (envelope-from ); Sat, 25 Jul 2026 07:03:41 +0000 Message-ID: Date: Sat, 25 Jul 2026 09:03:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] [gdb/testsuite] Fix race in gdb.threads/leader-exit.exp To: Keith Seitz , gdb-patches@sourceware.org References: <20260723114042.703464-1-tdevries@suse.de> <20260723114042.703464-2-tdevries@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/24/26 7:49 PM, Keith Seitz wrote: > Hi, > > On 7/23/26 4:40 AM, Tom de Vries wrote: >> >> The problem is that after the pthread_join is executed: >> ... >>    i = pthread_join (main_thread, NULL); >>    ... >> >>    sleep (10);  /* break-here */ >> ... >> there's a race between: >> - the breakpoint at break-here triggering, and >> - the "Thread exited" message for the main thread being reported. > > While I cannot reproduce this on my local hardware, your analysis > is sound. > >> Fix this by: >> - adding a loop before the break location >> - waiting in the loop until the "Thread exited" message is seen >> - sending ^C to get a prompt >> - setting a variable to exit the loop >> >> Likewise in gdb.threads/non-ldr-exc-2.exp. > > Sounds like a plan! > >> diff --git a/gdb/testsuite/gdb.threads/leader-exit.exp b/gdb/ >> testsuite/gdb.threads/leader-exit.exp >> index b5e6f558ac7..22f27d2d6e8 100644 >> --- a/gdb/testsuite/gdb.threads/leader-exit.exp >> +++ b/gdb/testsuite/gdb.threads/leader-exit.exp >> @@ -30,6 +30,28 @@ if {![runto_main]} { >>       return >>   } >> +# Wait for the "Thread exited" message. >> +set re_thread_exited {\[Thread [^\r\n]+ exited\]} >> +set saw_thread_exited 0 >> +gdb_test_multiple "continue" "continue to thread exited" { >> +    -re $re_thread_exited { >> +    set saw_thread_exited 1 >> +    # Get a prompt. >> +    send_gdb "\003" >> +    exp_continue >> +    } >> +    -re -wrap "" { >> +    pass $gdb_test_name >> +    } >> +} >> +gdb_assert {$saw_thread_exited} "thread exited" >> +if {!$saw_thread_exited} { >> +    return >> +} >> + >> +# Let the inferior to exit the wait_for_exit loop. > > This comment got a bit jumbled. Superfluous "to"? > >> +gdb_test_no_output "set var wait_for_exit = 0" >> + >>   gdb_breakpoint [gdb_get_line_number "break-here"] >>   gdb_continue_to_breakpoint "break-here" ".* break-here .*" >> diff --git a/gdb/testsuite/gdb.threads/non-ldr-exc-2.exp b/gdb/ >> testsuite/gdb.threads/non-ldr-exc-2.exp >> index ead262cc2b5..dfc34f42afe 100644 >> --- a/gdb/testsuite/gdb.threads/non-ldr-exc-2.exp >> +++ b/gdb/testsuite/gdb.threads/non-ldr-exc-2.exp >> @@ -37,6 +37,28 @@ proc do_test { lock_sched nonstop } { >>       return -1 >>       } >> +    # Wait for the "Thread exited" message. >> +    set re_thread_exited {\[Thread [^\r\n]+ exited\]} >> +    set saw_thread_exited 0 >> +    gdb_test_multiple "continue" "continue to thread exited" { >> +    -re $re_thread_exited { >> +        set saw_thread_exited 1 >> +        # Get a prompt. >> +        send_gdb "\003" >> +        exp_continue >> +    } >> +    -re -wrap "" { >> +        pass $gdb_test_name >> +    } >> +    } >> +    gdb_assert {$saw_thread_exited} "thread exited" >> +    if {!$saw_thread_exited} { >> +    return >> +    } >> + >> +    # Let the inferior to exit the wait_for_exit loop. > > Same nit in this comment. > Hi Keith, fixed both nits. > Question: Since this test file now relies on sending the target > an interrupt, does it also need the same "require" on gdb,nointerrupts > that leader-exit.exp has? > Thanks for spotting that. I've added this, and pushed. Thanks for the reviews, - Tom > Reviewed-By: Keith Seitz > > Keith > >> +    gdb_test_no_output "set var wait_for_exit = 0" >> + >>       gdb_breakpoint [gdb_get_line_number "break-here"] >>       gdb_continue_to_breakpoint "break-here" ".* break-here .*" >