From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58909 invoked by alias); 13 Jun 2016 15:09:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58890 invoked by uid 89); 13 Jun 2016 15:09:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 13 Jun 2016 15:09:19 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 599CAC049D4F; Mon, 13 Jun 2016 15:09:18 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5DF9Hmp004368; Mon, 13 Jun 2016 11:09:17 -0400 Subject: Re: [PATCH 07/12] Create sub classes of 'struct breakpoint' To: Yao Qi , gdb-patches@sourceware.org References: <1464859846-15619-1-git-send-email-yao.qi@linaro.org> <1464859846-15619-8-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: Date: Mon, 13 Jun 2016 15:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1464859846-15619-8-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-06/txt/msg00237.txt.bz2 On 06/02/2016 10:30 AM, Yao Qi wrote: > Nowadays, there are three types of breakpoint in GDBserver, > > - gdb breakpoints, > - reinsert breakpoints, used for software single step, > - other breakpoints, used for tracepoint, > > but we only have one 'struct breakpoint' for all of them. Some fields > are only useful to one type of breakpoint. For example, cond_list > and command_list are only used by gdb breakpoints, while handler is > only used by other breakpoints. > > This patch changes 'struct breakpoint' to a base class, which has fields > needed by all breakpoint types, also add three sub-classes to > 'struct breakpoint' to these three types of breakpoints. > > gdb/gdbserver: > > 2016-05-20 Yao Qi > > * mem-break.c (struct breakpoint) : Remove. > : Remove. > (struct gdb_breakpoint): New. > (struct other_breakpoint): New. > (struct reinsert_breakpoint): New. > (is_gdb_breakpoint): New function. > (any_persistent_commands): Update command_list if > is_gdb_breakpoint returns true. > (set_breakpoint): Create breakpoints according to their types. > (find_gdb_breakpoint): Return 'struct gdb_breakpoint *'. > (set_gdb_breakpoint_1): Likewise. > (set_gdb_breakpoint): Likewise. > (clear_breakpoint_conditions): Change parameter type to > 'struct gdb_breakpoint *'. > (clear_breakpoint_commands): Likewise. > (clear_breakpoint_conditions_and_commands): Likewise. > (add_condition_to_breakpoint): Likewise. > (add_breakpoint_condition): Likewise. > (add_commands_to_breakpoint): Likewise. > (check_breakpoints): Check other_breakpoint. > (clone_one_breakpoint): Clone breakpopint according to its type. > * mem-break.h (struct gdb_breakpoint): Declare. > (set_gdb_breakpoint): Update declaration. > (clear_breakpoint_conditions_and_commands): Likewise. > (add_breakpoint_condition): Likewise. > (add_breakpoint_commands): Likewise. > * server.c (process_point_options): Change parameter type to > 'struct gdb_breakpoint *'. OK. Thanks, Pedro Alves