From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gf2sIIx3MGnh9RUAWB0awg (envelope-from ) for ; Wed, 03 Dec 2025 12:46:52 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=BxCSYBgb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 81DF91E08D; Wed, 03 Dec 2025 12:46:52 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A9E0E1E08D for ; Wed, 03 Dec 2025 12:46:51 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1EFCB4152D38 for ; Wed, 3 Dec 2025 17:46:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1EFCB4152D38 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=BxCSYBgb Received: from us-smtp-delivery-114.mimecast.com (us-smtp-delivery-114.mimecast.com [170.10.129.114]) by sourceware.org (Postfix) with ESMTP id 5920D4303963 for ; Wed, 3 Dec 2025 17:46:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5920D4303963 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=labware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=labware.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5920D4303963 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.114 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764783983; cv=none; b=pHKT4LCrC2Ajd/643jwowJGsEZit/IavsnFVVBVuJmlgML5g8jowQYKu4l+MQvn3jUJNPSp/7FHgvLLS+EfsbetGalriASNau+h/u1eply+AV50RxlmUF4ZxB76O8fQiN6Gax8p0+Paic7hXBbog36zzpkwx367HXmaZGwSXMUg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764783983; c=relaxed/simple; bh=48Q4GPiFlpAGudtCY9Tma2UzzT7R2kAyFtW+ihf7r5g=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eJmI0A3vjeBFiT2Xl6cGzrtsk+X9/v/lCIPXZjHVZy5zHthen2U4iqMR17cZizweCtUtLZBqXBGcSDRrev9tuy9V2p0wx38vpuNMIGS9+HRJzH/rVW2VAZUHWCbUOsSMahGOBNwjxgk+6myL7CJ3vmj8ww9ukfzyuM+L6MqTgwY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5920D4303963 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labware.com; s=mimecast20220511; t=1764783978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=48Q4GPiFlpAGudtCY9Tma2UzzT7R2kAyFtW+ihf7r5g=; b=BxCSYBgb3ImCIinUi8vK/bouJiDqbzqEpPHT/AU08XEj7XImF+e/kHOIbv/84Rgo7r15yy 6/32NS4bm3PUan5VZ4qwmh+Xr91II5NhEDXYQNo54qJnEuN/ALkjzdVuBrlJqSp/BGlZTJ cPSWnBay7Mtd3e6Xw5VOnnufpYjX2UI= Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11021132.outbound.protection.outlook.com [40.107.208.132]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-7-yhvmnS3kP9KSe04zNj-MzA-1; Wed, 03 Dec 2025 12:46:17 -0500 X-MC-Unique: yhvmnS3kP9KSe04zNj-MzA-1 X-Mimecast-MFC-AGG-ID: yhvmnS3kP9KSe04zNj-MzA_1764783976 Received: from SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) by IA1PR17MB6335.namprd17.prod.outlook.com (2603:10b6:208:425::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.9; Wed, 3 Dec 2025 17:46:12 +0000 Received: from SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e]) by SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e%3]) with mapi id 15.20.9388.003; Wed, 3 Dec 2025 17:46:12 +0000 From: =?iso-8859-15?Q?Jan_Vran=FD?= To: "tom@tromey.com" CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH v2 13/13] gdb: update message in symbol_file_add_with_addrs after changes in readnow_functions Thread-Topic: [PATCH v2 13/13] gdb: update message in symbol_file_add_with_addrs after changes in readnow_functions Thread-Index: AQHcXXyMIk8DqPM2aEm+hyTMfXjBFbUOp5wQgAAV5YCAAAQhiYABfNGA Date: Wed, 3 Dec 2025 17:46:12 +0000 Message-ID: References: <20251124195535.2116845-1-jan.vrany@labware.com> <20251124195535.2116845-14-jan.vrany@labware.com> <87ikeo94hb.fsf@tromey.com> <576dde3ff5c99574ff024b6590c255ea356b1a1b.camel@labware.com> <875xao9061.fsf@tromey.com> In-Reply-To: <875xao9061.fsf@tromey.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR17MB5365:EE_|IA1PR17MB6335:EE_ x-ms-office365-filtering-correlation-id: 877de15e-329f-4d30-8e4f-08de3293d9a2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|1800799024|366016|38070700021 x-microsoft-antispam-message-info: =?iso-8859-15?Q?GE7zPQSnzfB0yROgybQH0ICpB/HU20Catm4zi9Pm3hvrm7YneraNTDFcw?= =?iso-8859-15?Q?joor7E7kBDHnxmLinB0V7FpbFn++3i/C2ijMeqy8mOu0KZcFGmAeJBpz4?= =?iso-8859-15?Q?IHQjE7bnJ8IbN9OZdbIpj4XOZYMpAN0bcjDf+lXXW0e8KEAiMQmzN4+Nr?= =?iso-8859-15?Q?t5FVn8w7YLsQHqMdAgQRTpPhpQnP7CHI9xEmybXMfBmbHjhaB2flqTTBH?= =?iso-8859-15?Q?FD7bmp7extcQBriMtMwVyx7eWjhxryYPbpDh7p2mSoA9ml+WAs/lEdwl8?= =?iso-8859-15?Q?O5WZLRBApEK/tlw/2ONKZ9BsR44dbFYletZagO71TykpCqymLLEEw4ZyI?= =?iso-8859-15?Q?P3telZ0KGb064Jyk9sf8Mr3JVrkmMoPg96idz08WlpRJZWdKsgyJUW9ue?= =?iso-8859-15?Q?XpzNH86PcS3o4lLPfnzOUvq/qN2JQ9btSfMT7Kf6GoCx6Wi2KrsqzvwLL?= =?iso-8859-15?Q?PrFr6BHt0aq0mJqpsnndxP6e1g/ZF4jm6pxKUpWYtRN/9HR1DG6m7gfgV?= =?iso-8859-15?Q?mcy0xV+K1idbNYSEEKAS/0lbcNs7hp1RTfkQZovTEUlF8kpQSUnIU9Pld?= =?iso-8859-15?Q?I8Q3FKSGCjHnpfOf4+Gd6ga4yHYExc6EQXCuKANmQeG6wX4OAv22q/AMz?= =?iso-8859-15?Q?ESa2OyGjzpUKQXAR54ffoiGA6DPi0GqMqvswp2gOfZiN6EHGNxOD7yMTK?= =?iso-8859-15?Q?ciwh4BMQpVkNdIzIe2Cs8QXBZFuwyYZ0FmBtphlQzTjemmqbvrI/9Truo?= =?iso-8859-15?Q?pEA/BMziNz4hYH59wHJwToU10OFiJWoEYCagJPMI2Bb/gSY3tME5Z3Eni?= =?iso-8859-15?Q?91UBtEepVep86hQL8URmskaNbxRmzdgMcNRfLLlgKoJo3iBS8yrkX+58m?= =?iso-8859-15?Q?uOWcwpkloYVFW5JzAtzA2BhYvH+whsP00hvTMezbRxwkI1oySraGZW6DA?= =?iso-8859-15?Q?8MytMd1Mjf2AHTQJlAuWAK8oFxYECVueFVO+1irNaUxvbnofUL05iwCw6?= =?iso-8859-15?Q?9MsV3TqPrxHdJ7TjVGrpuqV8pqmaeeiof2Du2lfG8tsJ/Ip9bUJUFmUsA?= =?iso-8859-15?Q?3dE7Yoftywu/74SS3ZbsQ7/+7k4c42L2mi/nboak0Onir2puHmto4MX7/?= =?iso-8859-15?Q?QE01Xt8VsfFTTXogE/u4j6kQbLs1wnBrlXVxS8NtK2yM1zOZS22Yz4Ybe?= =?iso-8859-15?Q?q994dUQkMXApf+mnAbxZdhZuR1PDT/B29Wq3LIjCujBXh3vDgp0VA4fvL?= =?iso-8859-15?Q?5bWZKpRKv8y2W+EFjKsXe2ulRsm3/Gw5uEcFYgWsWLt1nM3QJhNryoPFX?= =?iso-8859-15?Q?254znAmTIkS1SUqfnzuLFuTv5y2xsCnWe4y2Rw2DiOHENWUsq6/BZayKm?= =?iso-8859-15?Q?3RnirQ4q5kQatDzAwnAYSnxWNn2GUdOmA1XhwkKQ0oNZqesb7JhXpgudo?= =?iso-8859-15?Q?csoLOnovJ4AznB51IUZparRfSZzz43B3ypNJtMOY+rz+pHx+yCBiIHoI0?= =?iso-8859-15?Q?jAzJ+Kc2wG4anL7ryWn28QwtJmVL5Fi+U1NlfOiTiEDJvbVCT3naYoT/P?= =?iso-8859-15?Q?Hcg929oB6MlCdebX7ikH08Inp8d7j9VJcjj6UfQKadAwD+ZoKqJJo0?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR17MB5365.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700021); DIR:OUT; SFP:1102 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-15?Q?P79Tq2nwI0GE8ybk1ZLyyzpJoZDDY6migPVX1cQ7svfjWeJTwsHVZeXWT?= =?iso-8859-15?Q?72zSJq12uT/hD5AjwLjnBYsxLCIXSURsn5lTQWxHgo9KgCd7uk10nXrDI?= =?iso-8859-15?Q?okz5oM4NHzQP4Uhn8s7BE4Dp0BZ5JsUlURjm7pRmoQOCu862i7ZkyE/hc?= =?iso-8859-15?Q?NX3DLJUjV2ljBdYLUJuGAzyvoK+UAEapjNF3vhhOclm/f9fpw3rzP0+/l?= =?iso-8859-15?Q?2YaQY6yHIk5q7prkdg+BLgb7s5lKqb4dSq1lSqSThqQrDDVkXHNUNGW+S?= =?iso-8859-15?Q?hx2HCIe6ahi9aTqcQOFCXykUk53CUZ4rYaUEmcPqBLXt+OylZ5z6KGyjk?= =?iso-8859-15?Q?i16b3s3vLy1PxJZ24hB4FEcgsa3R44suE2AJI0ugLyzz+493iyLvKeEht?= =?iso-8859-15?Q?y1DDfSkTHxQH5MgsDHhvR8nuWlMoBaGgMNOwQYnVYd1hJrPNEkD51Y1MU?= =?iso-8859-15?Q?grgLC5UG8/iByVgj1RrDiLom9dkszm3tLXrelDFdtwg6238dXcCto3qNz?= =?iso-8859-15?Q?AfihRvVkslwOlFs7rEfpKOU4ogGntSl8yY6HEHCu5zJg49CO5keR2ysUW?= =?iso-8859-15?Q?hhip1nBZN8M3bHryZ7MqU6NgyBKZIb+dOIoD/YbA8Lv1arbp/9SxNynxH?= =?iso-8859-15?Q?oaYBWLMQJTvAZrAACI0tJPyxw6GA+M1zAFqt2MN9dYW2cVuKTv8Rpwg2u?= =?iso-8859-15?Q?6BGx2z2rN5Snua6PhRMIUG+oA1mrFgnV3Hqy+Sc5h6lz5WgOYFRiRfNdF?= =?iso-8859-15?Q?ajJ0GHR617HvjXkGUcublt/Igml8fL7hnJGRgopTb+Vm6pnlEU7s0oEJe?= =?iso-8859-15?Q?gE4xcc0KR/P9tZrPcbRWCWhoiCsGjDOPGdc9Se2fmsw+cTUiyVMD6csPA?= =?iso-8859-15?Q?oWSlvFYO291G12RxDSwzQN3/rHG3cECf7+XkyOWAF/uOFR7uhrLtr7uyt?= =?iso-8859-15?Q?Sg/+DnGwtKWNcHSUVwnRNqJVD3eaOxfIv4FaKBcLs/TtJLSoPc40i9wWK?= =?iso-8859-15?Q?sSEQzRP3h2MIM9tGNkFsuSo/88AoUW7VmrsY2+NvC7vKu0EZQlL8qxzIU?= =?iso-8859-15?Q?Ov0xCaK5Yrtk1e5Afu3FAfDZh+ybm6p1Du/bg2uCZ2QDhRBMqqL2VrbvE?= =?iso-8859-15?Q?JusWhT9ddswGVgsXPHrvx3sQx0n4IoOODjV4NFENviC/IqQgoZ1vuBRkf?= =?iso-8859-15?Q?1w2kBhi9DWTICa+GfTwX8uBAb0Zy6jLEGojWD0M7WaW0UEsIq5k3kwuXv?= =?iso-8859-15?Q?rsZGy7tk6JZsBTocR3pUcMIQ8dqDWcNh8KKakV3ytA9+4A/XhTNgbgGCp?= =?iso-8859-15?Q?DlV5L3tgEJt4f8+M+XIClAq3p7J+rJcaVGe1Q23DxZC5oBPqJHWCvKHH3?= =?iso-8859-15?Q?RxtT0Z3SBEfHgrnSEnBb/WHKgpArKHN5+IZ1uHthyATakykkeP7VuOzc8?= =?iso-8859-15?Q?SLIz3dj3wZQezQILNpAauSLHyf/2cgHUD/Xr2AgLnMTCz3G4lFGJw/b5v?= =?iso-8859-15?Q?7zq5cq4LSe0MUO6jORU5MBK0O9RCl8YLcW2KpUOC7yEQvgJxI/EODejO2?= =?iso-8859-15?Q?wi72zWLhANJf69nfc+F0IRW6dY9b+jZh5Tv4OxeD3gn8VbNZDSXoaTU4P?= =?iso-8859-15?Q?Z12FRFiEdsU/vcWAVmnMAcBFN+gWo7pyp9fP0MmFJtXe2YuGEBlSBNKu8?= =?iso-8859-15?Q?6T0z?= MIME-Version: 1.0 X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR17MB5365.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 877de15e-329f-4d30-8e4f-08de3293d9a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2025 17:46:12.5615 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2caKfILCdR7KILFF7sZhOOn61MR5lfSijquqTkd+j6fy/cZInEW0pYM2s0pCyWuNwL7KwduyFREYmzXX2aSLZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR17MB6335 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GuIJ8ajC0cDbeqekElVmRHNtLpxSImq7rvyFvpa97ok_1764783976 X-Mimecast-Originator: labware.com Content-Language: en-US Content-Type: text/plain; charset=ISO-8859-15 Content-ID: <2F6C7BCDC1A8F44F9F2C1B022AC702FB@namprd17.prod.outlook.com> Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Tue, 2025-12-02 at 12:03 -0700, Tom Tromey wrote: > > > > > > "Jan" =3D=3D Jan Vran=FD writes: >=20 > Jan> Maybe better way to go about it might be: >=20 > Jan>=A0 1) introduce new quick functions, say "default_symbol_functions" = with > Jan>=A0=A0=A0=A0 the code from this (V2) series. > Jan>=A0 2) then DWARF's readnow_functions may inherit from "default_symbo= l_functions" > Jan>=A0=A0=A0=A0 and override what's desirable >=20 > Jan> and then JIT reader would just use these new "default_symbol_functio= ns". >=20 > I am not overly fond of the name "default_symbol_functions" but I think > the general idea holds. On a second thought, it won't be that easy. One cannot just implement readn= ow_functions by merely subclassing "default_symbol_functions" and overriding expand_all_= symtabs() to do what it does right now.=20 The problem is that compunit_symtab is not instantiated and installed into = an objfile until call to dw2_instantiate_symtab().=20 So even if one specifies -readnow, more work is done when objfile is loaded= , but still CUs are not instantiated (no call to dw2_instantiate_symtab()). If then correspondi= ng ::search is=A0 implemented so that it iterates objfile->compunits() then it won't see them= .=20 This is why commit "gdb: implement readnow_functions::expand_all_symtabs" f= rom this series calls (new) dw2_instantiate_all_symtabs() from dwarf2_initialize_objfile().= =20 And if we do call dw2_instantiate_all_symtabs(), then doing the same thing = in expand_all_symtabs makes no sense.=20 In other words: if we want to keep current readnow_functions::expand_all_sy= mtabs() then it would well mean keeping other methods too and then we may well keep it as it is.=20 Still, for JIT reader created objfiles (and for future "Python JIT API"-cre= ated ones) we will need "default_symbol_functions" so we'll end up with "default_symbol_functions" = alongside existing=A0 readnow_functions. I'm fine with that.=20 And yes, I do not like name "default_symbol_function" either, I just don't = have a better name right now. Jan >=20 > Tom