From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79992 invoked by alias); 18 Feb 2020 12:35:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79949 invoked by uid 89); 18 Feb 2020 12:35:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,LIKELY_SPAM_BODY,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-qt1-f194.google.com Received: from mail-qt1-f194.google.com (HELO mail-qt1-f194.google.com) (209.85.160.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Feb 2020 12:35:42 +0000 Received: by mail-qt1-f194.google.com with SMTP id c5so14319390qtj.6 for ; Tue, 18 Feb 2020 04:35:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=df9i3ALrJ0ztRduFD+dqDWifNf8Wr/59IhwAnPK/nFE=; b=cxxO8U70T7yH3jMXi8ievzgRjFCtH/YSho7B6TCV5Fi8LQy2ssuU2OUE6RMujcnbai sH5xL5ebIsaDmEO0k1Lgp/vPh9/JKf9gC52Apz/Zw6OkZdXfbdVgMmrLxtu0HvP+/aTy xeJo04A7uJnAdlP+XXUynyVoSvjL2RkBad85Awj0BLrlwKg/41xka7xEgsSN5LMKhsd3 w/xXmgfpPrWtwrVTl4gseQO268ox1etWcisrQ2pkURzQCYrDjpEHIhceVXr8pQebuKd9 msFiU8FMF1KBJUP+U9Gz7WIf+fUFeEaHg/VYucNnk9XS0JMFtEjXmQvJSaHNpSrniZMH ctMQ== Return-Path: Received: from [192.168.0.185] ([179.177.236.155]) by smtp.gmail.com with ESMTPSA id x197sm1824148qkb.28.2020.02.18.04.35.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Feb 2020 04:35:39 -0800 (PST) Subject: Re: [PATCH][gdb/testsuite] Be quiet about untested dtrace-prob.exp To: Tom de Vries , gdb-patches@sourceware.org References: <20200218120235.GA9051@delia> From: Luis Machado Message-ID: Date: Tue, 18 Feb 2020 12:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200218120235.GA9051@delia> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00715.txt.bz2 On 2/18/20 9:02 AM, Tom de Vries wrote: > Hi, > > When running gdb.base/dtrace-probe.exp, I get this on stdout/stderr: > ... > Running src/gdb/testsuite/gdb.base/dtrace-probe.exp ... > gdb compile failed, ld: error in \ > build/gdb/testsuite/outputs/gdb.base/dtrace-probe/dtrace-probe.o\ > (.eh_frame); no .eh_frame_hdr table will be created > ld: crt1.o: in function `_start': > start.S:110: undefined reference to `main' > ld: build/gdb/testsuite/outputs/gdb.base/dtrace-probe/dtrace-probe-p.o:\ > (.SUNW_dof+0x88): undefined reference to `main' > ld: build/gdb/testsuite/outputs/gdb.base/dtrace-probe/dtrace-probe-p.o:\ > (.SUNW_dof+0xb8): undefined reference to `main' > collect2: error: ld returned 1 exit status > > === gdb Summary === > > nr of untested testcases 1 Odd. I'm running this natively on aarch64 and i don't see the same. I only get output in gdb.log. > ... > > There is no reason to be this verbose about the failure to compile. > > Fix this by using quiet as additional option to gdb_compile in > dtrace_build_usdt_test_program. Note that the error message still occurs in > gdb.log. > > Tested on x86_64-linux. > > OK for trunk? > > Thanks, > - Tom > > [gdb/testsuite] Be quiet about untested dtrace-prob.exp > > gdb/testsuite/ChangeLog: > > 2020-02-18 Tom de Vries > > * lib/dtrace.exp (dtrace_build_usdt_test_program): Use quiet as > gdb_compile option. > > --- > gdb/testsuite/lib/dtrace.exp | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/lib/dtrace.exp b/gdb/testsuite/lib/dtrace.exp > index 9aed481f32..8f861c9de4 100644 > --- a/gdb/testsuite/lib/dtrace.exp > +++ b/gdb/testsuite/lib/dtrace.exp > @@ -52,7 +52,8 @@ proc dtrace_build_usdt_test_program {} { > } > > # 2. Compile testprogram.c. > - set options [list debug additional_flags=-I[file dirname $out_header_file]] > + set options [list debug quiet \ > + additional_flags=-I[file dirname $out_header_file]] > if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}.o" object ${options}] != ""} { > return -1 > } > @@ -65,7 +66,8 @@ proc dtrace_build_usdt_test_program {} { > } > > # 4. Link everything together to get the test program. > - if {[gdb_compile "${binfile}.o ${binfile}-p.o" ${binfile} executable {debug}] != ""} { > + if {[gdb_compile "${binfile}.o ${binfile}-p.o" ${binfile} executable \ > + {debug quiet}] != ""} { > return -1 > } > } > Then again, it wouldn't hurt to prevent noisy output. So, this LGTM.