From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KsXiIcqKlGnx/D4AWB0awg (envelope-from ) for ; Tue, 17 Feb 2026 10:35:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1771342538; bh=9YpHcIrrfNM0LlgTusryJuMtGdBrO8hJl8Mv+VTARJI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oMzoWABtxXqfG4DTp8QbJZDctBtp14z/cLb3yt3raDfw2UTzIG2UKtMfTYQfuMAc1 ukBKObyY3NP9LGfywgRDzRUxZpvt1hxXoob5+O3zBEOHay069Ne9DUpShBlEYlnueM +J1CNfyHs9ePtQeiay+fNLqfMzoRoXb6cSAX57LU= Received: by simark.ca (Postfix, from userid 112) id 45C041E0BA; Tue, 17 Feb 2026 10:35:38 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=ji0DSXqv; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0F2911E089 for ; Tue, 17 Feb 2026 10:35:37 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 924DF4BAD160 for ; Tue, 17 Feb 2026 15:35:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 924DF4BAD160 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=ji0DSXqv Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 10F7C4BA23EE for ; Tue, 17 Feb 2026 15:35:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 10F7C4BA23EE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 10F7C4BA23EE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771342512; cv=none; b=TqUg0PkflHaQXH+7FWUpne5vqJ5h2BWJ9VInod70+fYqGyTSKFwKz8TpQqYBfEbLS8grjbxLIBBpj8dxveKINvdZlJNIctf3YYw/02Ik5HpCsu3q0BMs9h0rwlqXcP6sdJSOZ/bQjA4R4FpFwNDSzKKGEJn/x4MHidh8guQNb68= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771342512; c=relaxed/simple; bh=9YpHcIrrfNM0LlgTusryJuMtGdBrO8hJl8Mv+VTARJI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=LNv8+8EoiVYfEMpa9uQnZWAqi4zFwUBWzk5sZjmdiAEaKpHZmwMwkYSudFjFosQ7Kn9eOSFZzdh0s293S0yOvS2uD7OKa8FLjKQwVaXJSstBmqHw4flEMBAi6UW0OTA2xTL/uFwtFMZdgtxIsDIxu1Qsxbru7PMz1DHU8G2kWcE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 10F7C4BA23EE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1771342510; bh=9YpHcIrrfNM0LlgTusryJuMtGdBrO8hJl8Mv+VTARJI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ji0DSXqvTToZZqdaDJ/EGYd6klYqth8VbwSsvXZ/+RXXgKW6cIgyeOB0cIgW/dGi9 RHYmUNv8unTw6vQFVNMMt0j9JQG8cYgfQ7KY6wag85DFFlzEjMll7gpYR3nm6I98X4 gkK+wF+L1+pu2Yc11qi2+m48N67Nnk1pTQWzxEoE= Received: by simark.ca (Postfix) id 25DF91E089; Tue, 17 Feb 2026 10:35:10 -0500 (EST) Message-ID: Date: Tue, 17 Feb 2026 10:35:09 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] GDB: aarch64-linux: Reorganize gdb/arch/aarch64-gcs-linux.h To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org, Chris Packham , Luis , Tom Tromey References: <20260214045504.361392-1-thiago.bauermann@linaro.org> <20260214045504.361392-2-thiago.bauermann@linaro.org> <5cebfbfa-a192-4359-97d9-83455d40fdc6@simark.ca> <87ldgsx8dc.fsf@linaro.org> Content-Language: en-US From: Simon Marchi In-Reply-To: <87ldgsx8dc.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-02-17 00:10, Thiago Jung Bauermann wrote: > Simon Marchi writes: > >>> diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c >>> index 028de981588b..b2dd192a7b56 100644 >>> --- a/gdb/aarch64-linux-nat.c >>> +++ b/gdb/aarch64-linux-nat.c >>> @@ -51,7 +51,7 @@ >>> #include "gdb_proc_service.h" >>> #include "arch-utils.h" >>> >>> -#include "arch/aarch64-gcs-linux.h" >>> +#include "arch/aarch64-linux.h" >>> #include "arch/aarch64-mte-linux.h" >>> >>> #include "nat/aarch64-mte-linux-ptrace.h" >>> @@ -1013,7 +1013,7 @@ aarch64_linux_nat_target::read_description () >>> active or not. */ >>> features.vq = aarch64_sve_get_vq (tid); >>> features.pauth = hwcap & AARCH64_HWCAP_PACA; >>> - features.gcs = features.gcs_linux = hwcap & HWCAP_GCS; >> >> This one could stay HWCAP_GCS, but I don't have a preference. > > Luis prefers keeping it as HWCAP_GCS (and also renaming > AARCH64_HWCAP_PACA to HWCAP_PACA), so that's what I'm doing for v3. > >> If we want to ensure / prove they are the same, we could add asserts >> like this in the nat/ header: >> >> static_assert (AARCH64_HWCAP_GCS == HWCAP_GCS); >> >> That assert would only be checked when compiling natively for an aarch64 >> system (where HWCAP_GCS is available), but it's better than nothing. > > I mentioned this concern mostly for completeness, TBH. IMO it's not > worth adding this assert unless we're actually bitten by this problem > (which AFAIK hasn't happened yet). I wouldn't expect it to really catch mistakes, it would be more for self-documentation. Simon