From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id dAJmGJ+W52LnXR4AWB0awg (envelope-from ) for ; Mon, 01 Aug 2022 05:02:23 -0400 Received: by simark.ca (Postfix, from userid 112) id 527FE1EA05; Mon, 1 Aug 2022 05:02:23 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=K4y3uCIj; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 76FEE1EA03 for ; Mon, 1 Aug 2022 05:02:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 09A813858031 for ; Mon, 1 Aug 2022 09:02:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 09A813858031 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659344542; bh=74v0AYByqixe094kJQQwMYT4WJs9fPmUFZGTZWx0uws=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=K4y3uCIjt1rSNi3W3Fwq/MVtB9O4b31qn29pMYrfs8re5p7Jo7u4pClVVWKd5vIGV EqLQQCTelivAPlVvo+EWaPG9j9m0mvJrHkRgU3wNITbK5D+oychMdBZQk13SUwbQhH QbsbsF/NS4O+ougvCqx0AQX2uGoXLoUfouZeq+Ms= Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10071.outbound.protection.outlook.com [40.107.1.71]) by sourceware.org (Postfix) with ESMTPS id 24D6A3858D39; Mon, 1 Aug 2022 09:02:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 24D6A3858D39 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iVOZwN0b9dnLZazAn5MOD0lU/ogphGDYtOwrTs3bwyYIWusw1OmdRcadQ1tmDWOGi5dudt9FGiYe+acuSXzoxPHaCaOTdBTTP7JIxZrClBpvb98jK51MbZT4bT9jZCIgWTnatwtN1wCDik1lZyvxmhDYBkHdVfhOEvoT7z6bLipdv5LyuuqMjYIVOq0PkqrYBt/B5ApeoyDI7kHSPAb706gQH2B4g4e1WNC6PJWIfcXHglIXa0ZfB7F8R6WFOnIHLtPEag8FkWhilA1EGuDOKRrtvlqEQwV8KsLWTdpPVO0fhYad3tDEtQnTIM1IuYSVo8zWz151hFesH6GUql+ecQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=74v0AYByqixe094kJQQwMYT4WJs9fPmUFZGTZWx0uws=; b=MgR8gar4n0TaqjKfuO6eW7cwAbATVfS/n2jqwPMR/tW6mq2kqMe0WvvwY9tFqxj4RZqh0DnnIr/KtMxLPL0wU8jtW4JX5sOWIYc192GTZhRhJTltsigsMF5uvwxK3vQ0SpIigVE6wmdVwklePH7z+UiUx+y6/dlt6FD5oCZ0hF4Y7WTY2Ev1ZtLS9JtPztpJ89dvty88yn1lHqZvnBkAfa0loomPjasPFQUem2gG4Ak44yIU7Wh2HdLUUXHWD4UMgQLvkAZZNG46JDiD8+tWe7zBMF2ScBXezwWsWpchQiCbD6vESsDR8lDeo/XaTqwAZqEEwUFDMkFr+dKwXdFpDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM5PR04MB3252.eurprd04.prod.outlook.com (2603:10a6:206:6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.13; Mon, 1 Aug 2022 09:01:59 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::f1f6:f171:49e9:b68a]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::f1f6:f171:49e9:b68a%4]) with mapi id 15.20.5482.014; Mon, 1 Aug 2022 09:01:59 +0000 Message-ID: Date: Mon, 1 Aug 2022 11:01:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Get rid of fprintf_vma and sprintf_vma Content-Language: en-US To: Alan Modra References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0052.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::23) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: da308531-b4db-4ccb-9df4-08da739c7dcd X-MS-TrafficTypeDiagnostic: AM5PR04MB3252:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MTDbATLuwL0077QPx36YWNKbRQVl/6SC7lHqigBHXXazAY0xBMsdNVAnp1JSC9ZMBSJCTiJM6B/d+M4vSHfaWmLxhllSrIuN7lF3iRnIkBTBDnI3HJoowxkrdHpn7O32T44Yhr2oBK/GPxew0HT3gB4gYmIkQBGg6smeZEV4NPpzK/rFTHOl/Gty/xx6yhvYpYya+Y09Fji35al+SniUdUuiy7JdKFMmDrvQ7KTJGQA5pcyZ+G/1gRDzndw6yLkRnBce4F648/pJWI7A+0dHAm27Df9VOyypzS7yjqPtxc/r596Z3iS3awVYCw0EEl216gY7mvOYRPvUWvpFlR8Iv1uAyj8p4LbOCVgSVvbtYhsd4+MwOGt8hC6afcGStn8TM4vu3Rh7xnXSo/vhYL94bku65wilE79ZP2YR39msfbNh1/gRFl5wL5pcib1DIqCn+HUIZFGUm4CWyftipIp/LAYSnnAnUgx9VejL93/2LZUytPyb6iITMN5b90PSqmIoemwjTSpW7Q4Rxb4HFxTgXZ2vGSr8eAPGepn+tPNKLYjUPDLKCZuJ93I7R0ZQJ6ulwu8mW+c/ZRww0PWDgPtX6XcRZpUYGp3sHTmsxy6n/1KHM86lYIFqwT2n/8hXGK7UbDPiSFKwlhpijgDt6CR3WnTUT0jDIAkPNcC0rBHdqjO52gH0CyYGp+pMNRoNbp7JFRyP3TtOMqbEJduvxPLT6JgJFcRR8q7cmy0kWIF6O8LIntxycrsoGyEOGLNdCKS3cDywaPa7kdZ27ZudhjPVrkc6PJRqlHdyuVepvWjUsyGz7/MkHLXrrWRFWHgzISj12TJwYOoUkqFoB3hmocmo9kvXbZA/Yunb22VuLIkNca8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB6551.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(366004)(376002)(346002)(39860400002)(396003)(38100700002)(2616005)(6506007)(53546011)(2906002)(41300700001)(186003)(83380400001)(26005)(6512007)(8936002)(86362001)(36756003)(316002)(31696002)(478600001)(4326008)(66946007)(66476007)(8676002)(6916009)(31686004)(5660300002)(66556008)(6486002)(26583001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amVWZUpibmxuQzRodEpMdE0rUzVKZ2ZtbWgxSlUzTE5yVmQ1SEhVUFFYR2l2?= =?utf-8?B?Y3pLc2puM2x5YWE5eFpQMGZVZ3hxZEttSGlMajNWaE5KYUc5NnBXS1hyU003?= =?utf-8?B?TEVOREV2aG5XcGxSKytacDBIM0x2dXdqR1I0bjh1L3FTakNTM3dzRDZOb3dJ?= =?utf-8?B?c2x5QnA1aFNHOFNaSzByd1JXTEhkV1YxZXZUZzUyeERNdFBjVHdPeGM2anN1?= =?utf-8?B?cnNFaDgzWWkwTi92dmY1U1FYcUJ0d3hWVFBqNW5pQmNRWFJQd1FxRkJLMGt3?= =?utf-8?B?VFpkT1QrUzN5ZmdEallHR3kyd1JNSzZvWkVQTUNhckxueDJPRU9vVnU5R3RC?= =?utf-8?B?TE9oVVhwdmtXaHF0RGtiQXJoYjBaUTFwbHFNY21pbDFEWDVSRHRwQjZPc1gx?= =?utf-8?B?NGl6OG9KeVVZQ29ya1kvemY1WkJwYTB4ejh5M3RwZjJ5QkhNQkg4WnVrZnBz?= =?utf-8?B?TVZ5RmxLd2lvT1FZOUtUdzRpY0Nxem42cVJBT1I5YkZOZW44OFRGdnZDUWpo?= =?utf-8?B?aVNmMURFcy81WEZ4bFBGekx5V2ZZSlcyV0ZjbUF1YVRkSTdaKzlHRklPUXNT?= =?utf-8?B?a21YZWhxRjEzVEVGdElJcTNtNjF4bkdNRFh1OWxNZ3dBNGx2NTA0RWFudi8x?= =?utf-8?B?WVViUkpHbEtLcnlPbnY3TzY0eDlPV2tiWkRkMVM5Wkl1UlF2QU9MSW5hdlAv?= =?utf-8?B?OU9CaHV3WE5BMzJUdWxldzFMT1UrN0thS2NVdW9rSDBBN2R6dm9ES2JsSDdM?= =?utf-8?B?bkF5MUdQQ2ZBSTcvQ2NMSHorWnZ3Ty9HeGl0dGFVNGVqTzAwL29Sbys3bnNu?= =?utf-8?B?WUtJNTA0anBOTExyWkRWVWZLMU9KeTlmc3RpVzVKSDZaUml2dU1wclM5bmVa?= =?utf-8?B?K0FGME1vWkF4Q0FKM0ozckRVSy9lQ3dQYlBXYXJXdUZNTW1ldTdXRVdGa1dV?= =?utf-8?B?NDI2S1dudzZxNEpPdHlhMUdOSjV5N0ZoL2FTU2REdW03L1dYcUMzc01tRzBh?= =?utf-8?B?ZEZiS2dETVJla3hqVmJHTDlqL1YwaGJBVkdtUnYrUDhwMjJncndxOTlMaVZL?= =?utf-8?B?dXhOZ2l0T1oyK0pOcTFrdFQyVFg4MDl0dnRvVVhUWmJsUGRIeEpIeDZPUmxD?= =?utf-8?B?bW5tZC85Y3lFaGkzUXB0QjFLazd6Q1VrRGFGejZmeUw2N1l4M2N1eFh5Y252?= =?utf-8?B?RFpvcTl6eHBuODdPZ2pOcUVNc2ZyQ1hxenZyY2FMZnJTZ2crenB1SldVRkVD?= =?utf-8?B?M2U0WFozejFKNk9mM0Nmd3A1ZStVakRsZkxqQktMcVBLNStTUmJvOExNbUpD?= =?utf-8?B?RTVpbnd0TXpCZWZqcncrMzZ4Q29nRUtwNGpKbFVJbnEvclZBMWVJbnVjSVhz?= =?utf-8?B?M2pBRm1EOXJBa242N3kvQndqdXZSWXZWUGhBYmlhakdWMXNYTWFBNDJxZldh?= =?utf-8?B?RGEzYWRwVHBhZmF1Mjgxc1R1UkJEWWhsY0pHbHhJdHJLcGJUanMwRVhYbURh?= =?utf-8?B?d285LzNtNVVnRVJ4aCtKMFFibUZoTWtwKzJjUUFwSmRESWFiSmU2SVo2K2Z0?= =?utf-8?B?RzVvaE5XalJINlk3L1FrVFM5QXdnWUJvbVpyLzVid3J5Q3Juei9QSi9yMW5o?= =?utf-8?B?Y2FDb3NxeTBnZVpXNTF0RlFuVXdKeHNNQnZwc3JMWHhPS0g5S3NOK21rT090?= =?utf-8?B?cjk1V1FKS1lSdmIvbnVUaFhxdVR3Q1d1TDA2SWtwNE1iUHFzMmdHT2pKbnZE?= =?utf-8?B?WlZ3WE4xL2dBWXRXbTZ4TjJwQnlwUkRyZytNZ2prNDFHYWNsbFdzaForRUhw?= =?utf-8?B?WWtyeStTdFRLYUJlamRyWVNFdTYzRDR0Uy84MklNZDA4bDM3dUI2WEUxVkJ3?= =?utf-8?B?YkJmOGVHVTBpbXBNQ21jb1pXNXZzd2NwSjNweUVjM2lUN05SaWYwYmYwY2dr?= =?utf-8?B?NmZGaXBCeVo2K01XeWJXMm1qQVYyWkFpZTNaNlZKUjNmNDdEMlhFWnZpRmVR?= =?utf-8?B?dkcvK1dqS2JQTndFN1JnZzNueGdrdVpOcU4vWXozbkhpZitzRDBHaGlSMVRV?= =?utf-8?B?NDhUN21aSWpvTFBYd1F1d1Q0VUkrSWMvME8zdEhrajdEN1hBSHM4d0hmZUEy?= =?utf-8?Q?WPPOW9SLPeNAWF7mLKu8CT34s?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: da308531-b4db-4ccb-9df4-08da739c7dcd X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2022 09:01:59.0784 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nbmYdpZzCpizBhVclTmDYPDXQxl2SOjVeS+EYe6jMUCKmlT7wo9zwQ6xfvz8SrO7BigW4con+220j7d4WkDyXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3252 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jan Beulich via Gdb-patches Reply-To: Jan Beulich Cc: binutils@sourceware.org, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 01.08.2022 06:33, Alan Modra via Binutils wrote: > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -2377,15 +2377,8 @@ offset_in_range (offsetT val, int size) > } > > if ((val & ~mask) != 0 && (-val & ~mask) != 0) > - { > - char val_buf[128]; > - char masked_buf[128]; > - > - /* Coded this way in order to ease translation. */ > - sprintf_vma (val_buf, val); > - sprintf_vma (masked_buf, val & mask); > - as_warn (_("0x%s shortened to 0x%s"), val_buf, masked_buf); > - } > + as_warn (_("0x%" PRIx64 " shortened to 0x%" PRIx64), > + (uint64_t) val, (uint64_t) (val & mask)); > > return val & mask; > } > @@ -4913,12 +4906,8 @@ md_assemble (char *line) > i.types[j].bitfield.disp32 = 0; > if (i.types[j].bitfield.baseindex) > { > - char number_buf[128]; > - > - /* Coded this way in order to allow for ease of translation. */ > - sprintf_vma (number_buf, exp->X_add_number); > - as_bad (_("0x%s out of range of signed 32bit displacement"), > - number_buf); > + as_bad (_("0x%" PRIx64 " out of range of signed 32bit displacement"), > + (uint64_t) exp->X_add_number); > return; > } > } Just as a general remark / question, seeing these changes: Wouldn't it be slightly better to use the # modifier in cases like these? It's one byte less of literal string space and results in zero to be printed as plain "0" (no 0x prefix)? As to the patch - I'm happy to see these two helper functions go away. I do recall running into issues resulting from their use. Jan