From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120959 invoked by alias); 16 Oct 2018 20:12:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120826 invoked by uid 89); 16 Oct 2018 20:12:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=letter, HContent-Transfer-Encoding:8bit X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Oct 2018 20:12:11 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w9GKC5Sl003305 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 16 Oct 2018 16:12:10 -0400 Received: by simark.ca (Postfix, from userid 112) id 32F911EA70; Tue, 16 Oct 2018 16:12:05 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id EB5271E514; Tue, 16 Oct 2018 16:12:01 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 16 Oct 2018 20:12:00 -0000 From: Simon Marchi To: Tom de Vries Cc: Gary Benson , gdb-patches@sourceware.org, Pedro Alves Subject: Re: [PATCH][gdb/testsuite] Rewrite catch-follow-exec.exp In-Reply-To: <983cb35a-7547-ddf1-1a27-e7b157377997@suse.de> References: <20181005101122.GA23867@delia> <20181009135155.GB12668@blade.nx> <8f8ffb94-5a0c-8b2b-d541-eaacd7d1f42c@suse.de> <20181010092735.GA29557@blade.nx> <20181010134423.GA23926@blade.nx> <20181011074744.GA7677@delia> <750f69f3ea27d2ca530c896eef51e9eb@polymtl.ca> <983cb35a-7547-ddf1-1a27-e7b157377997@suse.de> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00351.txt.bz2 On 2018-10-16 13:07, Tom de Vries wrote: > On 10/16/18 12:11 AM, Simon Marchi wrote: >> On 2018-10-11 03:47, Tom de Vries wrote: >>> [gdb/testsuite] Rewrite catch-follow-exec.exp >> My build of GDB (and probably some on the buildbot too?) uses >> -fsanitize=address, and on it the test does not pass.  On a build >> without -fsanitize=address, it does pass.  The failing test is: >> >> FAIL: gdb.base/catch-follow-exec.exp: [lindex $result 3] == 1 >> >> and the value of $result is "17872 exp10 0 23".  This is because ASan >> exits with 23 if it detects leaks. > > I had trouble reproducing this, until I tried -fsanitize=leak. > >> If there's a way to set >> LSAN_OPTIONS='exitcode=1' in the environment GDB runs in, it would >> probably make it work... >> > > I've fixed this by changing the test from == 1 to != 0. Ah, good. >>> +if { [target_info gdb_protocol] != "" } { >>> +    unsupported "not native" >> >> Please add a comment here, something like: >>> # Even though the feature under features being tested are supported >>> by >> gdbserver, >> # the way this test is written doesn't make it easy with a remote >> target. >> > > Done. > >>> +    gdb_test_multiple "" "run til exit" { >>> +    "runtime error:" { >>> +        # Error in case of --enable-ubsan >>> +        fail "No runtime error" >>> +    } >> >> Please use a lower case letter for the test name. >> > > Done. > > OK for trunk? LGTM, thanks! Simon