From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
Tom de Vries <tdevries@suse.de>, Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFC][gdb/cli] Ignore error in gdb command script
Date: Thu, 20 May 2021 11:01:38 -0400 [thread overview]
Message-ID: <b69eccc7-3db9-64ac-1c11-e9469c3eade6@polymtl.ca> (raw)
In-Reply-To: <a5823dfdf3a2d27287ac56fefba6c5d5c90fe849.camel@skynet.be>
On 2021-05-20 4:02 a.m., Philippe Waroquiers via Gdb-patches wrote:
> Not too sure to understand what is meant by 'follow-up' patch as the approaches
> are not really aligned: implementing the 'setting approach' later will then add
> a different way rather than extend this one.
>
> For what concerns the naming of the ignore-errors command (discussed in another mail
> e.g. as it it makes 'ignore' abbreviations ambiguous): it is worth
> mentioning that 'thread apply' and 'frame apply' have -c and -s
> arguments to indicate respectively 'print any error and continue'
> and 'silently ignore any error'.
>
> So, maybe the naming of the new setting could be
> set error-handling [abort-execution|print-and-continue|silently-ignore]
> (default value abort-execution).
>
> If the 'setting approach' is not the initial absolutely to do preferred approach :),
> then the command could be:
> error-handle [-a|-c|-s] [--] COMMAND
> (with -c being the default if no flag specified).
I agree that we should choose whether we want a command or a setting,
but not add two things to do the same thing.
And I think Philippe has a good point about the naming (that applies to
both if it's a command or a setting) to ensure extensibility.
Simon
next prev parent reply other threads:[~2021-05-20 15:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 9:59 Tom de Vries
2021-05-18 11:12 ` Marco Barisione via Gdb-patches
2021-05-18 13:57 ` Tom de Vries
2021-05-18 14:10 ` Simon Marchi via Gdb-patches
2021-05-18 14:42 ` Tom Tromey
2021-05-18 15:16 ` Tom de Vries
2021-05-18 15:32 ` Tom Tromey
2021-05-19 6:25 ` [PATCH][gdb/cli] Add ignore-errors command Tom de Vries
2021-05-19 7:32 ` Andreas Schwab
2021-05-19 7:36 ` Tom de Vries
2021-05-18 19:16 ` [RFC][gdb/cli] Ignore error in gdb command script Philippe Waroquiers via Gdb-patches
2021-05-18 21:59 ` Tom de Vries
2021-05-20 8:02 ` Philippe Waroquiers via Gdb-patches
2021-05-20 15:01 ` Simon Marchi via Gdb-patches [this message]
2021-05-18 14:23 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b69eccc7-3db9-64ac-1c11-e9469c3eade6@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox