Re: [PATCH 3/5] RISC-V: Add linux target support.

Jim Wilson
2018-08-08T18:19:22Z

On Wed, Aug 8, 2018 at 7:41 AM, Andrew Burgess
<andrew.burgess@embecosm.com> wrote:
>> +const struct regset riscv_linux_gregset =
>> +{
>> + riscv_linux_gregmap, regcache_supply_regset, regcache_collect_regset
>> +};
>
> Could this not be static?
>
> Also, I think 'riscv_linux_gregmap' and 'riscv_linux_gregset' should
> both have comments against them, I'm pretty sure the expectation these
> days is that every definition has a comment....

I added the static and the comments.

Jim