From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112297 invoked by alias); 7 Jul 2018 14:06:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111959 invoked by uid 89); 7 Jul 2018 14:06:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 07 Jul 2018 14:06:15 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9B2C31E08D; Sat, 7 Jul 2018 10:06:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1530972373; bh=GX44FaOJTxZmYrfps90Y4WVBzd10EjybGgJ2F13ayS0=; h=Subject:To:References:From:Date:In-Reply-To:From; b=KPnrZPv34gBMsPuMB/f/upTE8Lfj2kC8QQdMARakAEDB7DwmALGIPR0SGsEbVKXuq /UFXnUjeIrZohFy4LYnxkSd7z+pqNp2sdGMFTLkdfROc0G9xR3vnkEj3Ojg4Xjefef o1o321pC0z/+g8+xp5TLnZjG0+YuH8B1t17r3ut4= Subject: Re: [RFA 03/42] Add assert in prepare_for_building To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-4-tom@tromey.com> From: Simon Marchi Message-ID: Date: Sat, 07 Jul 2018 14:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-4-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00168.txt.bz2 On 2018-05-23 12:58 AM, Tom Tromey wrote: > This adds an assertion in prepare_for_building. This was useful for > verifying whether some subsequent changes were valid. > > gdb/ChangeLog > 2018-05-22 Tom Tromey > > * buildsym.c (prepare_for_building): Add assert. > --- > gdb/ChangeLog | 4 ++++ > gdb/buildsym.c | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/gdb/buildsym.c b/gdb/buildsym.c > index b747a082b5..9e0c39a4a4 100644 > --- a/gdb/buildsym.c > +++ b/gdb/buildsym.c > @@ -1025,6 +1025,7 @@ prepare_for_building (const char *name, CORE_ADDR start_addr) > gdb_assert (pending_macros == NULL); > gdb_assert (pending_addrmap == NULL); > gdb_assert (current_subfile == NULL); > + gdb_assert (buildsym_compunit == nullptr); > } > > /* Start a new symtab for a new source file in OBJFILE. Called, for example, > [I failed to reply-all, so I am resending this] The code paths in buildsym are not very obvious, so it's hard to verify that this will always be true, but on the surface it makes sense. Given that it survived your testing, it LGTM. Simon